From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A55847A0B7 for ; Wed, 8 Jul 2026 14:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783520717; cv=none; b=hG0ghtjb5f9Z/5+uXlAFtBK/i0q3fY0h1TDMS1FMdF5ZRjzhnPGqMi0nzG1IJojZHqQMfBI4VOWNpmpEHSblnkHq2ePkuxmMzRQvEtYlRhmZfNh1Sg314qL6mf2Z+Jn+sCNa9UkSxDR+R9SxbbA51NV1X+BNb3SJVCqkcduQc/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783520717; c=relaxed/simple; bh=sSmsdnmJrwAPWW1KiyJRt8MCa+4Zum/gNQgF63z/D1o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=azUMloxi4EVsGO+Gg+9bynTWJnAtxCsN8p0SOWFZP5X8BtN+W1l/fDNEO6PoyCgsEo3kec5gaL1I5u+T4cRPdu3zOSx9A4AZUj7AaAXgngpTlHKwYkq98j2E0/kMtzY5gzegNRWokMJ5zsNfQ9SeOQ8SALS+PEEEoDUGZJgrzx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PyP7HEO3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KysYUSt/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PyP7HEO3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KysYUSt/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668C3VD52727502 for ; Wed, 8 Jul 2026 14:25:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GvPOfAqnErBt8ztKSYP7B2XU9RLRHl2bIpX+eaysQj4=; b=PyP7HEO3JF6XT+gG EJuLTNmpvlkCRZfJUJSEB8ReOvor7VAA44TxaSxdLDVWeJhZ6vdU3jOojmVKBHtl ks1eKw/63ND/vu+kjFJcAMFIQVKNeu62WpXECEAsV+Zx5uViAopvuE18Hue+ETs6 vSMurlyjcDwN+wwrH9JXxDvSlwPsxelBvAnh44CsYBtQIlnLvB6Vc4pq9JjgFEnb B2REVAaXWJDnIJtMRZK9aa5158Eyen0EhQpPn7Sv2N+wEe9MlW745VtzHyXR3x8f crwjvf1Bhs8ylRMHihreF1s8nJw2Wg7FZElD+gi2mcfUVv4Bio04PUNzn4lAMJl5 EttpbA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9c6ab0mp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 14:25:14 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8f0f45415cfso12440306d6.2 for ; Wed, 08 Jul 2026 07:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783520714; x=1784125514; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GvPOfAqnErBt8ztKSYP7B2XU9RLRHl2bIpX+eaysQj4=; b=KysYUSt/n7df9m0u4H206uG9MrZS1BzYIxUq55BC+0E4SJSU1QFpj3u9vt/pp3zr1m MdezqKTfQlOvoAB+ETVxmqibI14Q92FSWj4nqF3EPcOYyBnLq+hzkU5VMUBun6Z00+yR +nYoxfH7jtgRhq8wjCSHftLv0BfUf2kzPkObYqHspPM1vCR0LRWN+TnANX7LAuTMIykT vHNnY0nhnJrUr+CyFefENO5ZLizsQa47ty4tB6s75ZguM6YB2dTGhG2tXWnaEv5BaiFW qfLV97345i+i7wMLrG1Bt6I6GJwJgIzFdURmfHwfBXknvGOkyJJMlG2x+UOczRFVoPwN VUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783520714; x=1784125514; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=GvPOfAqnErBt8ztKSYP7B2XU9RLRHl2bIpX+eaysQj4=; b=LQXhcvkmHPw/gbjD8oYr2LbL4CLbCByle+SsWTXO2+oY5uLFL36++B3S3d+UqMLGI8 AkPwfQWsXeWQnSkqQG+h4GMQ4Hu07ad+dQcjM6FddMnW82hyPwUnDxcgEW/ooAZ5owHZ tBdTssv8m4Fv+WxAKYSm4TyLUYoapt9hF+q085hTS+x2PlGBuWwop3Q+vOsEvJgG6Jsi KV2fkGRW7RJGTPB6giT4ERgSpxaTvCgXQoBgRDnD1VSBZ5XT9FYzFvKzd4zi0sKr7Wxy FD+E6/7AI1/yr98gaAnRDTwWO9eREpAlP21vOp3jOD+k5WzuZ0FrKOgpK+gWvN4DyiEJ YOnw== X-Forwarded-Encrypted: i=1; AHgh+RoIWRlCHDTboeCPlBqpdfoXmsL+B/detSqTvR3FE+ghnSiq4XxrBWinec6GTv4aOk8ywbnjt7AVFGvcxRA=@vger.kernel.org X-Gm-Message-State: AOJu0YwWpGk6c2/LrVOJ/c7I5pAaYggo+iROzsAQAEiI7vwxtfGr+LtJ gSWhv7BHBoJhCsCVa1/R8GKp8tGNiPEAMkeB3C8IN+Xdd0i6Fp98qcOlAKD5LLEzxgk25TJIer2 Un6JW9P2vORWfuS7KJOIfDHma+hvt3jX6Px8KbzbfiPG3z3a3+w5SqootQvwqTDVSFsY= X-Gm-Gg: AfdE7clQN4DzolBaIUHkTo09UrK+n4x/sW+kPF6aEJha3hRwRWJF+5tpja0xhX0Ar4H R+Lvk4WqfdMw+dMPhWOVsOBx6FeFiUHOpgV5MaN9s4lZhT2J74oX47glfJzGWOqIlbvWAFACeLm sexhO2NqWitSpLdYCe5qdI3uZlLnJhYCmqmCCsBLC9hac+jPqv+e3QT2sahoPP0ph8nmAJPSdZX UIKVSb1G678O/zvba4P5mtM7hp/j/6KJU0BHE/HPMeJ8k2Mzg1tKOTqUZOMKuwx0IwkzTQ3t6VG N6fpPz1KTG3D45QEJM3YywehtJc6b3WDNGb9CsWyIQt6Tv/Er0J8VwqN9KpoCDigcm1E4AZt+rH UV9DIAqF097Nlmz+NOYBf/xzrkyDfOO7sq2ziz7+CJlRX/JOb8RLfMpKm2i5eEeVwgGwhRfOZCJ r9SNrJiN+PKTAfirBscETq9+6/ X-Received: by 2002:a05:622a:1e1a:b0:51c:ecf:4eb3 with SMTP id d75a77b69052e-51c8b3cc299mr27193131cf.44.1783520713484; Wed, 08 Jul 2026 07:25:13 -0700 (PDT) X-Received: by 2002:a05:622a:1e1a:b0:51c:ecf:4eb3 with SMTP id d75a77b69052e-51c8b3cc299mr27192631cf.44.1783520712722; Wed, 08 Jul 2026 07:25:12 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13c1c4dsm4527420e87.66.2026.07.08.07.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:25:11 -0700 (PDT) Date: Wed, 8 Jul 2026 17:25:09 +0300 From: Dmitry Baryshkov To: Gaurav Kohli Cc: Daniel Lezcano , Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants Message-ID: <2tu35aavp7sc2npni33ky5bve57idzy3bzp2pk7eh5lryq3r4v@gmm3dhayu4cf> References: <20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com> <20260703-qmi-tmd-v4-1-3882189c1f83@oss.qualcomm.com> <977711ef-c1fb-4735-b82a-4ca2f4797f51@oss.qualcomm.com> <8ad14017-bce7-485e-9677-9cbf8ecb2742@oss.qualcomm.com> <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> <1aca8d60-8e39-4532-9095-a5260bba76ac@oss.qualcomm.com> <9dc4b29e-e9fb-421a-b789-eb16a68ff915@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9dc4b29e-e9fb-421a-b789-eb16a68ff915@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE0MSBTYWx0ZWRfX2bbczD2EBfZA ZColDIxqze4JEWiUVg9foyjlmR3vcLydmxgpeu4k3RAwxrpqlNyoOtm6RC8RhpMpYC4KFrf1HUI zKWA85qjlrIef5LwQl0Plr7JtcarDDd0xCsr3swmCnhBt8EzUEX8wLMgmhKo04jQhwKnSm+DTPQ PIoox6pQ4hsbMYKrxaH0SVr51LbRq2WOgwoFUNCVRbS1Eelk0Nm+X/9FKj+etlMWvkbHnZSUag0 MHb2Yi4QkoY48r5Qlq2fUvM3tBVMj9ukb55Pv3SIg8crg2ATbrze4SGh+PlNlkqkvBCv1ORBSyW YfG7hMZRJCqfGa4mKINR9gghxkcjkq7/znudyH9ahnnyBwzBVDRD7QWo6fAX2o/2SBaxT/BIGJn Su2Ol71FrYj8YRNQlkL69oQod8WWmdtbqE6OiL3VP2xuu5KF/Vk2KfQgzwUqmmlK8JSjvEUMVtE SqUKrotAj6HzIx1vCIg== X-Proofpoint-ORIG-GUID: cu_mUHX4xNgxjW4DZM2K8dscWI-S8Fgk X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE0MSBTYWx0ZWRfXzP7P6FSUYyxG Z9cnrjxGg/VVaifsRX5MQY0K9ypvWXzqgq2Ns09qo8it149MELLU1ikFRwC6Cz+Px8bD2HNKD6r 2LHq9QbQdCdf+7K7q1b7ve64jXEKqx4= X-Authority-Analysis: v=2.4 cv=UehhjqSN c=1 sm=1 tr=0 ts=6a4e5dca cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=DU7i0n-ryPtEfpeWOdgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: cu_mUHX4xNgxjW4DZM2K8dscWI-S8Fgk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_02,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080141 On Tue, Jul 07, 2026 at 03:55:13PM +0530, Gaurav Kohli wrote: > > > On 7/7/2026 1:04 AM, Dmitry Baryshkov wrote: > > On Mon, Jul 06, 2026 at 08:11:35PM +0200, Daniel Lezcano wrote: > > > On 7/6/26 19:47, Dmitry Baryshkov wrote: > > > > On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: > > > > > On 7/3/26 17:42, Dmitry Baryshkov wrote: > > > > > > On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: > > > > > > > > > > > > > > > > > > > > > On 7/3/2026 1:23 PM, Konrad Dybcio wrote: > > > > > > > > On 7/3/26 7:03 AM, Gaurav Kohli wrote: > > > > > > > > > Add Device Tree binding constants for Qualcomm Thermal Mitigation > > > > > > > > > Device (TMD) types used by remoteproc-backed thermal cooling devices. > > > > > > > > > > > > > > > > > > Qualcomm remote processors expose thermal mitigation endpoints > > > > > > > > > through QMI. These endpoints can be registered with the thermal > > > > > > > > > framework via the `#cooling-cells` property on the remoteproc node. > > > > > > > > > > > > > > > > > > The QMI TMD protocol identifies devices using string names (for example, > > > > > > > > > "pa", "modem", and "cdsp_sw"), while the DT cooling-device binding with > > > > > > > > > `#cooling-cells = <3>` requires numeric device id in the form: > > > > > > > > > > > > > > > > > > <&phandle device_id min_state max_state> > > > > > > > > > > > > > > > > > > Define common TMD device index constants shared across currently > > > > > > > > > supported platforms. If a future target requires a different mapping, > > > > > > > > > additional target-specific constants can be introduced while preserving > > > > > > > > > existing DT ABI. > > > > > > > > > > > > > > > > > > Signed-off-by: Gaurav Kohli > > > > > > [ ... ] > > > > > > > > > Why are you using only those TMD devices? > > > > > > > > > > > > > More constants can be added as needed. > > > > > > > > > > > > Kodiak is one of the supported platforms. > > > > > > > > > > What would be the benefit of having more than thirteen cooling devices > > > > > declared in the thermal framework and having only a couple of them mapped in > > > > > a thermal zone ? > > > > > > > > > > I agree there are more TMDs but if they are unused for the moment, why do we > > > > > need to add them ? Can we do that incrementally ? > > > > > > > > That's what I am trying to understand: why the implementation uses only > > > > the selected two devices, if the modem on Kodiak supports others. How > > > > can we find out, which TMDs to use on other devices. > > > > > > My understanding is that is an initial thermal setup. Gaurav will add them > > > step by step while setting up all the thermal zones instead of sending a big > > > patchset. And TBH, that will be much easier to review. > > > > In such a case it should be noted in the commit message and/or cover > > letter. > > Thanks for the review/guidance. Not all TMD endpoints are relevant for > kernel thermal zone binding — some like BCL and cold temperature are handled > from userspace when needed. The constants here cover only What if there is no userspace? Or the userspace is different from what you expect? I doubt we have TMD-speaking userspace yet. > what is needed for modem and CDSP thermal zones on the currently posted > targets. Again, SLPI, ADSP? > > Will add a note in the cover letter clarifying for current tmd's. > Please let me if this is fine. > > > > > > -- With best wishes Dmitry