From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F4F17D2 for ; Sat, 4 Jul 2026 00:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783124242; cv=none; b=n5fpLMbd7JYFO1XH0+9OfyWLQ+VLNZJCAsdGjhDac452gt3JiRF8PeRCriNqJ0nxYDkel0uniMmw/avXQYV/nYS0Z6p40AeEHYUDvJ9YoIQc+8rE38Toq1u9d8SlP43D1hk/WhJK6JIa44L3zuqc1YycNudWEqswWxGzNf7iSUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783124242; c=relaxed/simple; bh=9C5RJUSt8UVdMbRPJGWBOVXu5hZdn4wcQY2xt5fYMVc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gWRDhcQ5GZRKnlpavxO/XYpfKg0ncoztjOtdQA+a+Ck1C2R0SlfgkdeYd7MwPGOAFgvUjOqdlRQ4Jn8KPU2KDJ+wRnQnmjQJGoOXv+n/eaJwb5GDLvInexB7pG2AHN27bl6ihRhCmepr1oscqYpGTw4t4F37ty6mq1ySp+5xwtA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zpd1yJu/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bCypjqai; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zpd1yJu/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bCypjqai" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663KPVe2890241 for ; Sat, 4 Jul 2026 00:17:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=H1z754F1g7bGdP8+fIZCnGTO 6+ITPOdx9vaa+Dfdatw=; b=Zpd1yJu/ZFq5Y53hjKfLmS55cLjQV6esll05S78T wZJ9VBczYGJoN6uCovB5MIl2bLlgBId+pU4azWepZ+5fX28azaBY/RCsfbFpTVuR sATEqhh9HR/cMMCWwiebJnPsPBwa6NknX6ks5sDPAlJLnitLQxaSZo/YngVIM0NH TrAIzwcGQhJ3lmugzWKUFNx9UZ7VXwJF6U+SUTk1m0uYoRJ/aQyEO6iN1kDujoRI DfJQ2OT8Zj84KT5maSVo3Zq5YE3oqPqmYNPbYbT/XB7PtGX8JSkgE4O/TvntkvQ+ 8BN3fjpb6mSzs9JnPRS89LT+tPOJ77YYSGAkYJLQrxhm5Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f67j03ebg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 04 Jul 2026 00:17:20 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c33f48ee4so11156401cf.1 for ; Fri, 03 Jul 2026 17:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783124240; x=1783729040; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H1z754F1g7bGdP8+fIZCnGTO6+ITPOdx9vaa+Dfdatw=; b=bCypjqai3LEVeFW6OmxHaOXBtg0OyTpHiq+gdUkH2Vf1kQjDdqJpyV7nXHxJiRaVZX 5xGtxElvXGfsx1Rc0sJL0wZgJuZ//m80am2FoCfCa81TzlguTXyOF9nQTwz/VBq6ivyP SIuZQ93dBy2Fy9DZr9LxSUIYJeqHC8TJXKZd8/kYGDc/DCTpcUodcgQV2bpVfB6nO5en 9th7gHRM5ANyr6xNyXe3P74QLuNdFDnkcHz/OpGiwel6FpcHi3wyVjV5pIg+QJVe5JSN dlSDNX0Gzz1ATMVL9ThgNT4ZJVtVSXZa9IYibcHTXZZEbKWQewtjT7hbde/6vV47Raks u+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783124240; x=1783729040; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1z754F1g7bGdP8+fIZCnGTO6+ITPOdx9vaa+Dfdatw=; b=qpt4PHV4Y9tUCHEQaBZIHKEeDq4/eFbEfNU4v7l8ox0uNtEvGtbc7uo1SNbYIKCPnK e4tNc5lQaN1iLDclCxg/FEmtHR2T74d9yFxftkIuROaQ4L28g7hcQoUek0KhM/1J5PI3 4dMK96TpcimIZ5vmS27OlolyfRzhbhkRGxHhJldnptW8sIL5Ai3QIGex/dvVV1/jK42s MTRur1cKgeuV2xKbBQLjOOPO/KniRLOzFP96/PkX+TnR72VisHr0nJohhNxB3g6Pk3sd xQXMlkN1K5s7dGt1q+mmkA/U5tl7n40I5sGeqHA/aMePbSwN/FT8zxSXEnEWVhg8xnwp NdKA== X-Forwarded-Encrypted: i=1; AFNElJ+LY1Sez3G4rKPW1vKYHS60MZoXXm+hQF7PXPT18iaonA0/BXhbRfy1VHxfv78tXAiGAu2yS0FGRTpsRZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzHkXnp5Dq8pg/G4CpQcdc/zrzUforctrDR91uOsNfaJy6Jm/W1 5K8BMFNaQskbq54UF37LBOndp0II5gEsiIyxu7xFKaWtYWgjtYNzRQkqEPB0oE7qIz/3FoNUn28 yxYB4Ph2uX1aj8iiqUt3LUoMCGI1DH/dZhvgicTkdAv36I0d44NkQogX+ZVyi8rYNJkw= X-Gm-Gg: AfdE7cmcONyv3LWr8KRSejLcaJ3N5pTpgF/7y+IMkWBTNcmfFYra7pXxpivxxU5FP21 aNVxd5PoKtnTY4WX6rQynFvw9a9OCzgURcFeaqwkgtRPoa4tpMbjFurzsTIkeWbQboEq43DBtR6 Tpo+rOGQjxGvblMFHqjQ3HboyWTCJuUPGjdAhsGVLeyGasjiw/w3PkuE3ARiFVxtwj5yg1UAb31 NHuJJo9vRx/fMDBx7HQB+jqkzm8/JBxEphE4b/pHNGRDhP2Pg2BPSvdY83DIu7hDgFq4U44yJV/ syOc6KhHQqotZ/svFtF1hBNGXmsZzJLFKA4In3w5eVfFkfq+LcMY5EI/u9ZSkzzQZ779kS+IHnz sFePmw+juP7CUdSgnkGqtaM5crvnHidMko3QPH386936FXuVa+KZFstIK3vPAj+6JGUOXf7To9C 5rdrrdJtH59IUOLMA+AWmkqzLn X-Received: by 2002:a05:622a:4c05:b0:51c:df0:1b34 with SMTP id d75a77b69052e-51c4c2c3da8mr25420571cf.33.1783124239714; Fri, 03 Jul 2026 17:17:19 -0700 (PDT) X-Received: by 2002:a05:622a:4c05:b0:51c:df0:1b34 with SMTP id d75a77b69052e-51c4c2c3da8mr25420201cf.33.1783124239238; Fri, 03 Jul 2026 17:17:19 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed1377052sm866292e87.21.2026.07.03.17.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 17:17:18 -0700 (PDT) Date: Sat, 4 Jul 2026 03:17:16 +0300 From: Dmitry Baryshkov To: Imran Shaik Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Dmitry Baryshkov , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 07/19] clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup Message-ID: <2vcr3x46sx5d4aogdcw3k7bqwe7bf7i24d436eb6o6gdi3zwwj@3duglhhchfx2> References: <20260703-shikra-dispcc-gpucc-v5-0-cc13826d4d5a@oss.qualcomm.com> <20260703-shikra-dispcc-gpucc-v5-7-cc13826d4d5a@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703-shikra-dispcc-gpucc-v5-7-cc13826d4d5a@oss.qualcomm.com> X-Proofpoint-GUID: Buhg8ohxLpVkOdDk0mk9mMIzeKAcP8Gr X-Proofpoint-ORIG-GUID: Buhg8ohxLpVkOdDk0mk9mMIzeKAcP8Gr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA0MDAwMCBTYWx0ZWRfX+RwJ5BQPVI5C lW7La6yUOsdXaHLjWcH/G1Z4+JmccGbYX0ZV+n/qgvV9VKKf+GP7qq6oMk3fL8pVX0AiTFteOeB OfvJK6YFmc8bfryORpeulP0dV6eKpHA= X-Authority-Analysis: v=2.4 cv=Yuc/gYYX c=1 sm=1 tr=0 ts=6a485110 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=bvhocwI2OAlG0vE5sJUA:9 a=CjuIK1q_8ugA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA0MDAwMCBTYWx0ZWRfX4mht2Q35qX01 FKdCiFFpJ5G9ZhRezzrrpw8vA+pQ0kXZO/pmJrY5rmOqVdwmj2yFZkXbaaAsTUk68ciSeyAM8ug HO78Pm/+O9KT/4mjDzCdXhn2QFWuXIIYCmFLtpfqBev8Yu01sFuo97X1L4ydrtjXNGomWGawOMq 5I4DMCqirMj45x50OrN55RLfydZh561rV8D0zVvlPsD89SVaNtaiHm8JhOEXkMPCDVV9X7pzPO/ 2co7HOLMx55eGbJpvaJUuj6V/ZlTgHXY73UwHCKelstkh/niTY/0vr15H9es4Avo1wG7IEMw74M JEiyu8XWxL+awvwq7KdAxtD2h/yvgPFynYB4UHPfRMk7S7KG1GtzA/z6xOyobIyXMioEV+vKmat Hk/07OIvETlrcgQPzU+Vp6kM1Buzmn9erfzauxwLpkxyNNcZOyIDsmjl2jlRcE0bnGjWU7JSE9v MmCqr83VWVGPKu9DOcA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_04,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607040000 On Fri, Jul 03, 2026 at 12:01:29AM +0530, Imran Shaik wrote: > Update the QCM2290 DISPCC driver to use the DT index based parent clock > lookup to align with the latest convention. Why? Missing the reason for a change. > While updating the parent data, > fix the MDSS MDP clock source parent to use gcc_disp_gpll0_div_clk_src > instead of gcc_disp_gpll0_clk_src. This parent is currently unused by the > frequency tables, but should be corrected to match the hardware clock plan. This sounds like a fix. Please never mix the refactoring and meaningful changes in the same patch. Also, I believe, Konrad suggested that the change in invalid. > > Signed-off-by: Imran Shaik > --- > drivers/clk/qcom/dispcc-qcm2290.c | 36 ++++++++++++++++++++++++------------ > 1 file changed, 24 insertions(+), 12 deletions(-) > -- With best wishes Dmitry