From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8BB43E077 for ; Tue, 11 Aug 2026 11:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786448370; cv=none; b=aN8Fbr5jrw8Hkj1QXk0XQMhD/drQZJwfOilSzWG9XzAnPB31fsOF+gqIiUIFQt3Kn5q9Ii5IfcJ7pfFK5B/XFMeEY8braLLFAtMT3oNt7Xt+v3EvDcnIlk82SDT9SeVkyJLkMlBjam3zS7E9HvcPdfzp6Bbw+gmWdQ/fUzbcl7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786448370; c=relaxed/simple; bh=FTn18kVaEozOZjK+4BFDCaG5UjbXJh6K05640NPhXtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=agdUVp7n6Gs7/3C7KhIw3ZzFTs5J7xszTefyWkAkMcPIJy5LA2UiK3VS+gIUhhFtHxLnegcuHCWmTdj82tSjbyNqDOpib6FzQAdetVyUE5/PqW2DsqL4Wxxoq7CmQT3OcyJJMeMCp42vWZtbZOv9UZsYJN8uwI5pPD2AyN1hCuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gwOieEKu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gwOieEKu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CA841F000E9; Tue, 11 Aug 2026 11:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786448368; bh=Krrkb4GTaAxnE8gRQpTXpOP7iACr+puNNwdjj+aGSmo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=gwOieEKuQYtmfuvad1CGHIB0AyEIzLKSuQMhLAg880EX+Uyoy3GAYdsHZDhjlPsi4 FWmUwjweR8Qfpfev+YibwTHYfiJk5qA5KUDhfQdIrDoFroATZesePISGR51n71SiFo aRFpYjV1NAjlBgmZ4MIzJYwuMAPP66ufPhxW26PDEoGIa5GVr6wWL7GvUsv0kqh1Lo cxNf1dnCttcC1Hg09z4ASiidq4i+ZxUE7WVgnvG6rwcWAvuRI90Sr5lOb0FYBgnANp d4g0G9MaldKmvNQKU8P6U2sWNUObdH8cd7V/4PwW3MZEkgtlEuY2oa12aernvLFTdB 7x8UjliRJIwqg== From: Pratyush Yadav To: Chenghao Duan Cc: pasha.tatashin@soleen.com, rppt@kernel.org, pratyush@kernel.org, graf@amazon.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kexec@lists.infradead.org, jianghaoran@kylinos.cn Subject: Re: [PATCH v1 1/2] kho: remove useless phys increment in inner loop In-Reply-To: <20260807075128.542806-2-duanchenghao@kylinos.cn> (Chenghao Duan's message of "Fri, 7 Aug 2026 15:51:27 +0800") References: <20260807075128.542806-1-duanchenghao@kylinos.cn> <20260807075128.542806-2-duanchenghao@kylinos.cn> Date: Tue, 11 Aug 2026 13:39:25 +0200 Message-ID: <2vxzh5l051jm.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Aug 07 2026, Chenghao Duan wrote: > The statement phys += contig_pages * PAGE_SIZE at the end of the inner > for-loop in kho_restore_vmalloc() is redundant code. The variable 'phys' > is local to each loop iteration (re-assigned from chunk->phys[i] on every > iteration) and is never referenced after this increment, so the statement > has no functional impact. Remove it to avoid confusion during code review. > > Signed-off-by: Chenghao Duan Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav