mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: ggo@tuxedocomputers.com, stable@vger.kernel.org,
	regressions@lists.linux.dev,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: amd-gfx@lists.freedesktop.org, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Hamza Mahfooz <hamza.mahfooz@amd.com>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Christoffer Sandberg <cs@tuxedocomputers.com>
Subject: Re: [REGRESSION] drm/amd/display: Radeon 840M/860M: bisected suspend crash
Date: Tue, 17 Jun 2025 17:42:35 -0600	[thread overview]
Message-ID: <3002633a-5c9e-4baa-b16a-91fdec994e02@amd.com> (raw)
In-Reply-To: <fd10cda4-cd9b-487e-b7c6-83c98c9db3f8@tuxedocomputers.com>

Hi,

Thanks for reporting. Can you please create a bug at 
https://gitlab.freedesktop.org/drm/amd/-/issues/ for issue tracking and 
log collection.

On 6/12/25 08:08, ggo@tuxedocomputers.com wrote:
> Hi,
> 
> I have discovered that two small form factor desktops with Ryzen AI 7
> 350 and Ryzen AI 5 340 crash when woken up from suspend. I can see how
> the LED on the USB mouse is switched on when I trigger a resume via
> keyboard button, but the display remains black. The kernel also no
> longer responds to Magic SysRq keys in this state.
> 
> The problem affects all kernels after merge b50753547453 (v6.11.0). But
> this merge only adds PCI_DEVICE_ID_AMD_1AH_M60H_ROOT with commit
> 59c34008d (necessary to trigger this bug with Ryzen AI CPU).
> I cherry-picked this commit and continued searching. Which finally led
> me to commit f6098641d3e - drm/amd/display: fix s2idle entry for DCN3.5+
> 
> If I remove the code, which has changed somewhat in the meantime, then
> the suspend works without any problems. See the following patch.
> 
> Regards,
> Georg
> 
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index d3100f641ac6..76204ae70acc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3121,9 +3121,6 @@ static int dm_suspend(struct amdgpu_ip_block
> *ip_block)
> 
>   	dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D3);
> 
> -	if (dm->dc->caps.ips_support && adev->in_s0ix)
> -		dc_allow_idle_optimizations(dm->dc, true);
> -
>   	dc_dmub_srv_set_power_state(dm->dc->ctx->dmub_srv,
> DC_ACPI_CM_POWER_STATE_D3);
> 
>   	return 0;
> 


  reply	other threads:[~2025-06-17 23:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 14:08 ggo
2025-06-17 23:42 ` Alex Hung [this message]
2025-06-18  2:16   ` Mario Limonciello
2025-06-20 11:55     ` Georg Gottleuber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3002633a-5c9e-4baa-b16a-91fdec994e02@amd.com \
    --to=alex.hung@amd.com \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=cs@tuxedocomputers.com \
    --cc=daniel@ffwll.ch \
    --cc=ggo@tuxedocomputers.com \
    --cc=hamza.mahfooz@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®