From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673C4C4332F for ; Mon, 6 Nov 2023 08:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbjKFI31 (ORCPT ); Mon, 6 Nov 2023 03:29:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231288AbjKFI3X (ORCPT ); Mon, 6 Nov 2023 03:29:23 -0500 Received: from 19.mo550.mail-out.ovh.net (19.mo550.mail-out.ovh.net [178.32.97.206]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9A2D77 for ; Mon, 6 Nov 2023 00:29:19 -0800 (PST) Received: from director2.ghost.mail-out.ovh.net (unknown [10.108.4.253]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 15F8027E77 for ; Mon, 6 Nov 2023 08:10:49 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wwxds (unknown [10.110.103.14]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 3C6D81FEB6; Mon, 6 Nov 2023 08:10:45 +0000 (UTC) Received: from RCM-web8.webmail.mail.ovh.net ([151.80.29.22]) by ghost-submission-6684bf9d7b-wwxds with ESMTPSA id 7H6TDIWfSGVAfQQAGogUGA (envelope-from ); Mon, 06 Nov 2023 08:10:45 +0000 MIME-Version: 1.0 Date: Mon, 06 Nov 2023 09:10:44 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Krzysztof Kozlowski Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hector Martin , Sven Peter , Alyssa Rosenzweig , Julius Werner , Evan Benn , Florian Fainelli , Broadcom internal kernel review list , Maxime Ripard , Oleksij Rempel , Justin Chen , Baruch Siach , Ahmad Zainie , Marc Zyngier , Linus Walleij , Jamie Iles , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention In-Reply-To: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org> References: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <300293570c0d29d5d4a39762121b5bef@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 31.11.218.106 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 11495438051932285714 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedruddufedguddujecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeggfffhvfevufgjfhgfkfigihgtgfesthekjhdttderjeenucfhrhhomheptfgrfhgrlhcuofhilhgvtghkihcuoehrrghfrghlsehmihhlvggtkhhirdhplheqnecuggftrfgrthhtvghrnhepjedvlefguedthfefleehgeeftdeludeluedvgfeffeevhfevtdehteejteefheegnecukfhppeduvdejrddtrddtrddupdefuddruddurddvudekrddutdeipdduhedurdektddrvdelrddvvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-11-05 19:41, Krzysztof Kozlowski wrote: > The Devicetree bindings coding convention, as used in most of the files > and expressed in Documentation/devicetree/bindings/example-schema.yaml, > expects: > 1. "allOf:" block just before "properties:" (or after "required:" for > more complex cases), > 2. additionalProperties/unevaluatedProperties at the end of the file, > just before the examples section. > > Re-order few schemas to match the convention to avoid repeating review > comments for new patches using existing code as template. No > functional > changes. It's surely going to help a bit but for a long time solution maybe you could consider adding proper check to Rob's bot and/or checkpatch.pl. -- Rafał Miłecki