mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Jörg Otte" <jrg.otte@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"bluez mailin list (linux-bluetooth@vger.kernel.org)" 
	<linux-bluetooth@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [V4.1] Regression: Bluetooth mouse not working.
Date: Fri, 17 Apr 2015 09:51:52 -0700	[thread overview]
Message-ID: <300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org> (raw)
In-Reply-To: <CADDKRnBiB+z2iMc+04ZzntRkGhVW5isNQ+sLt-UVPg3mo+Q7jg@mail.gmail.com>

Hi Joerg,

>>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte <jrg.otte@gmail.com> wrote:
>>>> The BT mouse is "death" in v4.1.
>>>> The BT mouse has been working in 4.0 and previous kernels, so this
>>>> is a regression.
>>> 
>>> Any chance of bisecting it?
>>> 
>>>              Linus
>> I will try that.
>> 
>> Thanks, Jörg
> 
> I first tried to bisect over all. But than I got an unbootable kernel.
> Then I did a bisect over net/bluetooth and I get the following fist bad
> commit:
> 
> 5f5da99f1da5b01c7c45473a500c7dbb77a00958 is the first bad commit
> commit 5f5da99f1da5b01c7c45473a500c7dbb77a00958
> Author: Marcel Holtmann <marcel@holtmann.org>
> Date:   Wed Apr 1 13:51:53 2015 -0700
> 
>    Bluetooth: Restrict HIDP flags to only valid ones
> 
>    The HIDP flags should be clearly restricted to valid ones. So this puts
>    extra checks in place to ensure this.
> 
>    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>    Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> 
> :040000 040000 b51ac3634c9d44f4d9df0e7f548b524954b99c76
> 63bfb47283609849f1b3b8f05fe61743ccddfee6 M      net

thanks for bi-secting this. I looked at our existing userspace and restricted it to the flags that are currently in use. However it seems that I made a mistake. What version of BlueZ userspace are you using (bluetoothd --version).

Regards

Marcel


  reply	other threads:[~2015-04-17 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  9:36 Jörg Otte
2015-04-17 11:55 ` Luiz Augusto von Dentz
2015-04-17 13:44 ` Linus Torvalds
2015-04-17 14:51   ` Jörg Otte
2015-04-17 16:43     ` Jörg Otte
2015-04-17 16:51       ` Marcel Holtmann [this message]
2015-04-17 16:55         ` Jörg Otte
2015-04-17 16:59           ` Jörg Otte
2015-04-17 17:02           ` Marcel Holtmann
2015-04-17 17:19             ` Marcel Holtmann
2015-04-17 20:18             ` Linus Torvalds
2015-04-17 20:35               ` Marcel Holtmann
2015-04-17 21:03                 ` Linus Torvalds
2015-04-17 21:26                   ` Marcel Holtmann
2015-04-18 10:18                 ` Jörg Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=jrg.otte@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®