From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A0AEB64DC for ; Mon, 3 Jul 2023 14:41:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229454AbjGCOl0 (ORCPT ); Mon, 3 Jul 2023 10:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbjGCOlY (ORCPT ); Mon, 3 Jul 2023 10:41:24 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC6BAE70 for ; Mon, 3 Jul 2023 07:41:18 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-992f6d7c7fbso350007566b.3 for ; Mon, 03 Jul 2023 07:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688395277; x=1690987277; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KsxT2CXzmHNRKMKyTxxMYK1jnDo5PSeQbIe7Vn7ruhs=; b=ibuP6poiRv2NCpv0GANe5BUUMAtho2Sim6bzfVUn+CrFEk0BeMJH5r82Rsm/lrHb4B FZ6udm9GNduaB5PVVVvfx085xYtTTDg2yvhr1xAElZaSw/DNo+jVEX9j72mskdOTx1+L 1gkkzTEkGsY+VhnT/EgfPPoAG692VJYniEIMJV3O5lPX0aBxe9Zii4MJZoJZbLLQJq+T zDQlamtXX523PrGN0SNns51BDHWiqG5wBA0qk8M0uOXFfOph57kVHiQKKzOLLBpH4ats 3p6worsobf8sD/soHqHA9k+YonV6arMhM/smOcC69I92l0dLRjdLL65JOwv29W2G5BmN +RRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688395277; x=1690987277; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KsxT2CXzmHNRKMKyTxxMYK1jnDo5PSeQbIe7Vn7ruhs=; b=EC7eVmlIk9/ou4UPtmbsEvGMbSrzhHv6LhzPnabzmAMRGVs7A7eDupjF1+B1xRDjDh pGdhgBjzZ+0/KeTkNBe8pUyAKW4VYaJweTmOgJcv6NxvGO1ro1AkZO9aSqviIIQUddX9 sGuQNSmRsdot597vKox/Cjna2O4KcRSwGT0U7VHd6GARb5DJloCv2EIXPYlJMQUZGfYM zTF9bOEwO93Iyv/jIydLoZk9qUuC8MM7tWf4tVPgOJa/t3tVseEmLmB8qWlXQHkABGbT ph9DcnkC/AYMcDmfyme4ufJgh2lFkWpFxiPsjhRKt99Mi5IL+ikKsGIpHAsfQDtC4XeZ bvZA== X-Gm-Message-State: ABy/qLbWUhaMKM5wRkYNjpy5OzZquA+3gAhzSgvgWFq8t9EMcKjIzT9a wn2Jsqpg2IX4M+Gl0zW10DsJfQ== X-Google-Smtp-Source: APBJJlGk9ekQfg4hjV5s18OXGN4VoU+I+0II8jd3rHixUG8SYz65UZyLq9XhnjMqiiDFTkFoY/5w9w== X-Received: by 2002:a17:906:2dc5:b0:992:58fc:bcb8 with SMTP id h5-20020a1709062dc500b0099258fcbcb8mr6529593eji.56.1688395277328; Mon, 03 Jul 2023 07:41:17 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id l16-20020a1709065a9000b0098d93142ce1sm11957949ejq.109.2023.07.03.07.41.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 07:41:16 -0700 (PDT) Message-ID: <30070c0d-df8c-2ab4-bc54-7801b6b7d49b@linaro.org> Date: Mon, 3 Jul 2023 16:41:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/5] dt-bindings: serial: geni-qcom: Allow no qup-core icc path Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Andi Shyti Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org References: <20230703-topic-8250_qup_icc-v1-0-fea39aa07525@linaro.org> <20230703-topic-8250_qup_icc-v1-2-fea39aa07525@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2023 16:38, Konrad Dybcio wrote: > On 3.07.2023 16:01, Krzysztof Kozlowski wrote: >> On 03/07/2023 15:31, Konrad Dybcio wrote: >>> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path. >>> Allow such case. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> .../bindings/serial/qcom,serial-geni-qcom.yaml | 26 +++++++++++++++------- >>> 1 file changed, 18 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >>> index dd33794b3534..a0acba57bc06 100644 >>> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >>> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >>> @@ -25,14 +25,6 @@ properties: >>> clock-names: >>> const: se >>> >>> - interconnects: >>> - maxItems: 2 >>> - >>> - interconnect-names: >>> - items: >>> - - const: qup-core >>> - - const: qup-config >> >> Instead please keep the definition of the fields in top-level properties >> with the widest constraints, e.g. >> interconnects: >> minItems: 1 >> maxItems: 2 >> >> interconnect-names: >> minItems: 1 >> items: >> - const: qup-core >> - const: qup-config > Sadly the issue here is that the qup-config path exists, but qup-core > doesn't. Ah, right, then: interconnect-names: oneOf: - items: .... - items: ... Best regards, Krzysztof