From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D041366552 for ; Thu, 5 Mar 2026 08:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698103; cv=none; b=Pc2bioSbOmdqdu5P9ClxPdVom+1rdRb0lBWCyBmVz0wwV+LcnABK576O4r9N3E1dSWmn07dB+tG7EtfNVS3sVdVp2YOdnrCCKoTAdifGRceIzQkTnNYDy44SLpG9GXQOLC5PD6yVwiHbZ1Jxu1EBLyGUXGhFIyjuTZ9wZEYqY9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698103; c=relaxed/simple; bh=0mu40XqlmT9C1K5v14IN1e21NLNB2K/mZDZbVz5wGR4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NHeLu88sUSEDilmF4nXjKWbxU1bbYcDLG9tCrByu4JzxvuhL/bGJ+Y0+6S+xiaFhhPQAQQuEfsPBjML0gVqs/hCsZAOlBrWFyYEP7O99C9Wsvb+Y9bF4epF2xRhnQS45mYBHsDOFtI8GsIQWubILkzAH9AzEhUif1DZNbj6qzjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CcGZcqCV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZFTYU19A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CcGZcqCV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZFTYU19A" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6251CFlR3473621 for ; Thu, 5 Mar 2026 08:08:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1Tu9sOHON+DSOPBlmrUYoifOv0lkJ+YvIm7FtkVs0cE=; b=CcGZcqCVNrYtQjs8 WjggGerePfHnvl6pWPGq1HxUOl6y6UnD4PkK14tR6vpCVwFV7ljXqK5xePGJlCSr eqJ5AqDrDEd6ScXdgOHfZcmAPViPpUpWA68aa271K15SVZhn5gLdHfyMabqrX0d8 /1QURoDQHYVFOV9TvbATB04H0In9AaBWHJa5BScUs6iRGkK144zkuTLQy6Q6NtyF 6N3wOPxo/N4cPsBZBfy7iNFw0MAuQcWn41Vyrm6xtedwB46CXM7QJM1N/hd0xFLI iZahZcKlWq6ydFc5eALixxrpZ49EUvdbgwRoGrmevulBC0fWj7FCREOgDLtAWzOP UgZTnw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpj183ug1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 08:08:20 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae3e462daeso24188155ad.0 for ; Thu, 05 Mar 2026 00:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772698099; x=1773302899; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1Tu9sOHON+DSOPBlmrUYoifOv0lkJ+YvIm7FtkVs0cE=; b=ZFTYU19Az8GdaNP0Yq4c3qvTQ5x9OHhA1/OxEcmJAvJm/rCFB2Xvgtrgb3N9pmx1uS 4pCw4AL5fVF/z4rNWOq7VLIBf+LVHUaKschhQzEywMIDdxvepqnC44W7nOO0sWZkR3UT pB2Bz6I5TABueYs975iD+IE++/+BeIM1G7Rf0D+W1QVNB74govvmKoA4PsN0yAbpf0Jp DXxNyrMp2ee6o8knudkuOagr1bMomdwgILXJpxq4sVHAOU6bcAZV6QVoRbcg9chi6uil m94r6o6k+FTuMVZcDq0IcUPqqtnD/z/QD8SZETDTNNNz+wK4vYAyIM4AYVXD5D3VW5hD Rtbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772698099; x=1773302899; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Tu9sOHON+DSOPBlmrUYoifOv0lkJ+YvIm7FtkVs0cE=; b=HiUEy3mzBW/ce1VDNKYs7rx71yYJc43b9F9BdBLYKWosz6LfTmeclBjf5nYtr65vcO dNCeFhl7FIonMU0tzuLq00H+6oaoJmYqzR+DyVrYJz5GVKpJWkfApZ7zfTnnoWFp5l7c /8PGYpxMtGQKym4XfsRvXaumetEJAqjaf0wcWas7jWuSaEnUOrgnsBcuKX+75tr1uU1w 4nduFQwA594Bqy/cidNKgxKi2UXMXCnCQnSwTlxRbad4MoD4bt44D+oMVomjo5K+WKTB zzQh6GG9q8dipoWV3jTLN4d3F4D9X39j01yYL7GYtJyvUdDD+CvsRJS4fmdUkH6clUxY ot0A== X-Forwarded-Encrypted: i=1; AJvYcCXZlgWiikf0A/NwmyAHIiq/8wBBuKvDcm9NPRrTZ9Oet+BVvrVww8ZKkpTRUWvvrFeeELlTTvw7wpTml1k=@vger.kernel.org X-Gm-Message-State: AOJu0YwjA6VnGCc/gBBdkrEBpDkoRxuRa0bQJNxkO8Xlj4NOCuF8cIc1 DTZgVzphK4a2B8Ao2ypjuD1rbA1nUJGmE3rPsnEgCztH0vbL56wW4nb8apr1Kns6r9Hx8MB0dy2 8GCIyqXyNg9UvktFbKb9MI8RXsRlVl/DpQUktSEh3hdvhGvJDaTs/cLUJEVqW2SARtEA= X-Gm-Gg: ATEYQzxGJt9e7eU+AwiH1LJn4L5iiXf3qj7XtjrPjoULETQX5tfXD4WSI7stCPQxlea RJQtfAHc6NLa/FXIFXXbWJnwqLD1ZLae+EyLBPZTEVmJdh5NW3VuWgLieU6gHj68Sm7B4gawrlf fOu329aPAocL3JkHbMFNiYSh93EKalbudi6Ibx8yzphGkVSoLdkhsobOv/JP693/yzYb6oNd8gN TOoLw0ICjSRopTAsErLq0TH4uE9ofM+2Ea93aoQKCUw34CcFiLor777zIT15NKFVD5EXWFFdFuC qseV5bPf7CFMga5MpCnooHqSH5OCmFiN4tsv78MMtE9nW4pkLbq3rH1/KNWDzkb21A3kxPR29aj z1zKitsKIobmsFif5ZMMGSkry7KHswt51c9fGqg46XaAqoFa0 X-Received: by 2002:a17:902:f78a:b0:297:cf96:45bd with SMTP id d9443c01a7336-2ae6aa0943fmr49881495ad.19.1772698099283; Thu, 05 Mar 2026 00:08:19 -0800 (PST) X-Received: by 2002:a17:902:f78a:b0:297:cf96:45bd with SMTP id d9443c01a7336-2ae6aa0943fmr49881165ad.19.1772698098846; Thu, 05 Mar 2026 00:08:18 -0800 (PST) Received: from [10.239.97.158] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6df578sm220846945ad.81.2026.03.05.00.08.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 00:08:18 -0800 (PST) Message-ID: <30122c93-7447-4f7b-b546-e4dcf80476a0@oss.qualcomm.com> Date: Thu, 5 Mar 2026 16:08:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: btusb: Allow firmware re-download when version matches To: Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com References: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Language: en-US From: Shuai Zhang In-Reply-To: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: j1w95B4zRF8iDDnRFexTABVB2WsVCLRy X-Proofpoint-ORIG-GUID: j1w95B4zRF8iDDnRFexTABVB2WsVCLRy X-Authority-Analysis: v=2.4 cv=Ed7FgfmC c=1 sm=1 tr=0 ts=69a939f4 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=XLcW7MSiMK0kOx3OsRAA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA2MyBTYWx0ZWRfX0B0vwmBAKpMM GMmfq6G8+DAh7SIm5Vv9HXVuLMDGZVzL2W3cWqIwaqnBzu9VwuyXZr74CUWYROnf0bWk7Ki/OMR L3uMv4kHenEJ0xzrPQBcJAptWEU8bZc1JOJn8fLiw4mjerzcL0LJcHjJwcsoelHKTld4fst9Pgt /PUCt0XN/rB/RW8vHsgHS4Za6QKYKo20k94vtmuL6NETVLRkHwohcnUbNjPt4bbSGlHRnssdKDC m/rLK8lzS8NypC8D9bqj9a7+8YRWIR0WAEVk4EK269OIiZGav81WvZXIGO4MnK/dwgAZXOV88r0 dz5AJ7RrOeROnAsMLcaBHgKus2bOtMUAJkOpKqfA433N4K+Vph3d+/TIh5VKCqwKAjbjJII/85W zd5Zq+IQqVMpnhPc4YENhbiN+VdTHMOubB7wtREds3lu0UErDWK1u7PDYV/9gyQkYnO0iGXjMmC 5Y6rlNJMMEziMNIPXEg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_01,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050063 Hi On 1/8/2026 3:43 PM, Shuai Zhang wrote: > Since USB can disconnect at any time, if it disconnects during > the BT firmware download, the BT controller firmware version may still > be updated even without completing the download. > > When USB reconnects, the BT host detects the same version as in the > firmware file, which prevents the firmware from being downloaded again. > > Therefore, remove the equality check to ensure that after > USB reconnection, the BT host can still download the firmware. > > Signed-off-by: Shuai Zhang > --- > drivers/bluetooth/btusb.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 646de80c7..991064a25 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3503,7 +3503,10 @@ static int btusb_setup_qca_load_rampatch(struct hci_dev *hdev, > "firmware rome 0x%x build 0x%x", > rver_rom, rver_patch, ver_rom, ver_patch); > > - if (rver_rom != ver_rom || rver_patch <= ver_patch) { > + /* Allow rampatch if version is greater than or equal to firmware version. > + * Equal versions are acceptable for re-flashing or recovery scenarios. > + */ > + if (rver_rom != ver_rom || rver_patch < ver_patch) { > bt_dev_err(hdev, "rampatch file version did not match with firmware"); > err = -EINVAL; > goto done; Could you please let me know if there are any updates? Thanks, Shuai