mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pablo Sun <pablo.sun@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"Rob Herring" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8395-genio-1200-evk: Enable GPU
Date: Thu, 12 Sep 2024 19:38:10 +0800	[thread overview]
Message-ID: <30184391-12a6-c095-7862-35c7677b0ede@mediatek.com> (raw)
In-Reply-To: <01020191e5383829-7eb375ea-ee17-419e-b173-30df46f61863-000000@eu-west-1.amazonses.com>

Hi Angelo,

On 9/12/24 15:52, AngeloGioacchino Del Regno wrote:
[snip]
>>
> 
> The range should match the target device's Vin constraints; in this 
> case, it
> should be no lower than the minimum working voltage of the Vgpu-in of 
> the Mali IP.
> 
> The drivers will be responsible of setting the lowest possible voltage for
> enhanced efficiency (power saving), taking into account the fused chip 
> quality bits
> (in this case, the MediaTek SVS driver!).
> 
> You should, at this point, check the constraints of SVS, as in, given a 
> reference
> voltage (in this case, located in the GPU OPP table, the voltage 
> associated with
> the lowest frequency of the GPU), what is the maximum voltage 
> *subtraction* that
> SVS will do on the VGPU?
> 
> After the subtraction, may this voltage be lower than 0.546V? :-)

Thanks for the clear explanation. While there are no explicit constraint 
in the maximum voltage subtraction in the SVS driver, I have
confirmed that the fuse data of MT8395 is written in a way that the SVS
driver would never go lower than the minimum recommended operating
voltage of DVDD_GPU in the datasheet[1], which supplies power to the 
Mali IP.

I have sent patch v2 to remove the always-on property and add a note
about the fuse(eFuse) data in [2].


[1]: 
https://mediatek-marketing.files.svdcdn.com/production/documents/MTK_MT8395_Application-Processor-Datasheet_v1.8.pdf?dm=1724252510
[2]: https://lkml.org/lkml/2024/9/12/285

Many thanks,
Pablo

      reply	other threads:[~2024-09-12 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 14:32 Pablo Sun
2024-09-11  8:57 ` AngeloGioacchino Del Regno
2024-09-11 10:35   ` Pablo Sun
2024-09-12  7:52     ` AngeloGioacchino Del Regno
2024-09-12 11:38       ` Pablo Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30184391-12a6-c095-7862-35c7677b0ede@mediatek.com \
    --to=pablo.sun@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®