From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: timur@tabi.org, broonie@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, fabio.estevam@nxp.com, caleb@crome.org,
arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de
Subject: Re: [PATCH v4 00/17] ASoC: fsl_ssi: Clean up - program flow level
Date: Wed, 17 Jan 2018 01:11:29 +0100 [thread overview]
Message-ID: <301c4cb1-d0ad-4fe8-0388-059d355b4c2e@maciej.szmigiero.name> (raw)
In-Reply-To: <20180116235258.GA6849@Asurada-Nvidia>
On 17.01.2018 00:52, Nicolin Chen wrote:
> On Wed, Jan 17, 2018 at 12:38:09AM +0100, Maciej S. Szmigiero wrote:
>
>>> Example of uncovered tests: AC97, PowerPC and FIQ.
>>
>> I've tested the whole series in the AC'97 mode on an i.MX6 UDOO board
>> and everything seems to work fine as long as few small changes are made
>> to patches 13 and 16.
>
> Thanks for the review and testing. Really appreciate that. I'll
> take care of those issues in the next version.
Thanks for these cleanups Nicolin!
> And I believe those issues are confined to AC97. So Caleb should
> be able to skip his test if only these two places get updated.
> (Thanks for keeping testing on each version.)
Yes, these required changes only affect the AC'97 mode, there
shouldn't be any functionality change in the I2S mode.
Maciej
prev parent reply other threads:[~2018-01-17 0:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 23:16 Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 01/17] ASoC: fsl_ssi: Redefine RX and TX macros Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 02/17] ASoC: fsl_ssi: Keep ssi->i2s_net updated Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 03/17] ASoC: fsl_ssi: Clean up set_dai_tdm_slot() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 04/17] ASoC: fsl_ssi: Maintain a mask of active streams Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 05/17] ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 06/17] ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 07/17] ASoC: fsl_ssi: Clean up helper functions of trigger() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 08/17] ASoC: fsl_ssi: Add DAIFMT define for AC97 Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 10/17] ASoC: fsl_ssi: Set xFEN0 and xFEN1 together Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 11/17] ASoC: fsl_ssi: Use snd_soc_init_dma_data instead Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 12/17] ASoC: fsl_ssi: Move one-time configurations to probe() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 13/17] ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init() Nicolin Chen
2018-01-16 23:39 ` Maciej S. Szmigiero
2018-01-15 23:16 ` [PATCH v4 14/17] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt() Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 15/17] ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode Nicolin Chen
2018-01-15 23:16 ` [PATCH v4 16/17] ASoC: fsl_ssi: Move DT related code to a separate probe() Nicolin Chen
2018-01-16 23:39 ` Maciej S. Szmigiero
2018-01-15 23:16 ` [PATCH v4 17/17] ASoC: fsl_ssi: Use ssi->streams instead of reading register Nicolin Chen
2018-01-16 21:26 ` [PATCH v4 00/17] ASoC: fsl_ssi: Clean up - program flow level Caleb Crome
2018-01-16 23:38 ` Maciej S. Szmigiero
2018-01-16 23:52 ` Nicolin Chen
2018-01-17 0:11 ` Maciej S. Szmigiero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301c4cb1-d0ad-4fe8-0388-059d355b4c2e@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®