From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41BBD1AB530 for ; Sat, 12 Apr 2025 10:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452908; cv=none; b=rNvGJ46ISCI0ZfF8bbQvd1+HwAjeJfiDdHfvJqSShju42IiWF0rLiOjm0XlNvFyzwDofrClxk8hw6kLnhb6AO5o3Wdw2oxDCxKgfx9Sa80+bTw30YmiV1U5pbEGwdYs39pA93rakT2exVnCVci0+iL26xyEWmAs/FuKfa48pGh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452908; c=relaxed/simple; bh=ec9o+usvzaDmx3DGgMMTtjczEBdGtLbMmGO/AqUrtyA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XXSJPKRue2ygIV7kEUawclg+QkCfvIgY9NMXpMUojk7X/cY3CVfXlZU8Es2Kd31gRynDdPO77mc3imDkbFecTfO5WJ2qEha43CRNQOxNkYkJh+jmmNNLnOpEtWoPPoSLybzeJA+xMOPZedA/vs85FBjXpWrg6WeMcmGsu6JF4No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F1PVhk6Z; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F1PVhk6Z" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so30185005e9.2 for ; Sat, 12 Apr 2025 03:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452904; x=1745057704; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A7fHQVByAhO5ET8TfAMvUtvtE+Jqiz2kAUnhQyP8lMo=; b=F1PVhk6Z51Oudl1g3lLBJ7pmr+ufCqsoQq0K6obGNgVmnzRPgWJHKWJIX9hJYKD0Uc lfwWu0B2MwIh5JzpyCpbQmpg2xiH1QYa2NLhoqjoEstoZ6RJW0VNaig2UhCeM0ghI5jm ucdk2tTHqK45RBjtLPdOFN8EFadyvOxAy1IDaUkSXGxmyLwTGga+JRO1fdKmjNneGGHR gXA9aucLQhEbmMWzFlahBWHD0DA+5zH1zor3Yxw5SKItJS+Hj43VdN4MEjA3Vv570ZRy DoiFckxN+pynPNJsqT/YD5YNeRP27vOFYrk8Ue8d1a0Bm4VkjsfcDfDHDj22QTYo5VcX c14Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452904; x=1745057704; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A7fHQVByAhO5ET8TfAMvUtvtE+Jqiz2kAUnhQyP8lMo=; b=a03FdTMJjXJn26m84HgVTP/sWC52RvD5QHyrUnno+Jw0ecOo80a1Wurb8tzO7KnDOU EMS6iKhqBaV/X9LxOOUnW8SZTp+9x0hcAn08FWbaqBY9FXuWWmWeUvBUEPtApedtwEp5 8MPIGqdBA53zScBxjQUSRF5vRDWZgKf+yNVGO2O5NMyFbIPDHXL8m6A9SLPbqm/4ECFC ROuVeZRBe2hRFx4DM8ys9PuiyCHucpmKzaXOFyzLZesELVutNaii3hp4dYPC66/Z/vnx Aw3ef1DAzFtPCJhJVazW1822k8uLRhZUL/6n1/oxKWVd013a25eOC6xd6fJA0PAVaAD4 IfgQ== X-Forwarded-Encrypted: i=1; AJvYcCWmxcA/zqoiHyjXnanNDyJW4Pcy6hKWkv5Gq2ADIfPcUONTbDKtSrek/1PBWofzcUN9G2+lkRsUkjnwuRA=@vger.kernel.org X-Gm-Message-State: AOJu0YxgA+bbV1CDNlNSV+7/0/Aaf99ggWBHm7aLfN9lUn3OGLxJZlt8 VbvEnOpegfxf3ifJ6d11X8b3FPKnJLVlGzwF7XNfEgmpA81DsvVJ0/EeCNDtMGQ= X-Gm-Gg: ASbGncvfcfX1PvA6d/RO2qzfuzcAi11wgr21i3sQ95upqUo+kUm2ey6QIoJE/3DjfA+ iVMfnTad7pCT3pQkGIdrKdl/h4SCrUVakP8EA/K6qpWWcRNp79a2+P22ddTFH3Jmz5CKF0lCPRu Hxu3osDowNhEn3JLEK6TL6m5OQOvnyLPiSMLnMG3zgeEdG8ox2yDG5z77GKVkvnS76+LETG1sGA i6LHMCA5oJj0v0a1nHE35EfzLO/k6DXgWJCgFrdAVhlORNJFpv3MVWl2I8U62+UInTpqcWdEDz8 PtSb9tOpRa8iCaGN72iO53+HNngABFzmHtLC21ILgMebNw== X-Google-Smtp-Source: AGHT+IEb2YD4p8Gn575c6+UDDJnXqr10gazTooH6MgrOd67+x5QilRkEOOPF4Jo0Z3LOPZCEzBmVgQ== X-Received: by 2002:a05:600c:3848:b0:43d:988b:7732 with SMTP id 5b1f17b1804b1-43f3a94d9bbmr52535175e9.14.1744452904493; Sat, 12 Apr 2025 03:15:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43f23572b5bsm110862445e9.28.2025.04.12.03.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:04 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:00 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() Message-ID: <30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: This code is intended to reject strings that start with "_sysfs" but the strcmp() limit is wrong so checks the whole string instead of the prefix. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter --- drivers/gpio/gpio-aggregator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index dde969f29ee2..b4c9e373a6ec 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name) * for devices create via legacy sysfs interface. */ if (strncmp(name, AGGREGATOR_LEGACY_PREFIX, - sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0) + sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0) return ERR_PTR(-EINVAL); /* arg space is unneeded */ -- 2.47.2