From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574964483A6 for ; Mon, 17 Aug 2026 15:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786982256; cv=none; b=qbhyJjCKcu+9UjnxEbtXdcMRUyUYZ92q+AQ0SGhY9IC0E6Mg4hu6SdtVeJDijT2hALDalVI/KZR62tCsehZhnc+zXWXbswCpe1cHfCpeIhDEvNRYeWl7a2Wl/SX57qy3uNmNi6qeNvSmbPwe4l27WC9ehBG6D/z5ygL7OGMhcsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786982256; c=relaxed/simple; bh=emNPuRCAyxU3Gn6X+B2FnhI+z52aNUB6G0TLtPQJiWI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hZM94Zr2ei82x65fVGZ3xzBml/And7q++pLEOZQmv4x8gSDYZkB8LIPlvQaJUSqb887ywBWBjGzknlOfUx78I0IA+8ClEtTsR4Jx8tvB5Tqnf6ofx6/duf91IojJI65K+hPnirmn4yd6hyg5nFcCG3hSVuliI4CKpxFt+wRrwOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GnwFx4dN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SWopLTob; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GnwFx4dN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SWopLTob" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HFYYR63790426 for ; Mon, 17 Aug 2026 15:57:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jxcqqZMcfMQG0NRazNx3M9ckLAOYPTmpP07Foy6k8GI=; b=GnwFx4dNXJOck/32 lh8S0LUpRjNWIkYURELTU8rv18AsJKu8lilSCK6u/YgXq+eO5zRkKK3Si/ODV8xE lH+obl33oBaaDqqIDa4rmwwlKGwFu0Vlx9HkN64UVo1wYTKgNaOLrTwIk2YFTLRW 5BxsPmUrVltriuvzZ+Fllkxt3o1snIwZ+gICy05W9pCuQXxv0SSS3n8KY1ZJlyOL j9t+lPkau0N27xFR9O2KCbyWx8fK1rI5SgpaphB4xAGhgf+c4S9GHljxX245RKrW DxH+iO0XmCbRmpIOYd2lfG7LJUkYTSjr+9huQqFGoMajSyKqQTzQ+x4g8tXL/bF9 2Yz8Uw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3y7ksn3m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 15:57:34 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51ca37ce4c3so4117351cf.3 for ; Mon, 17 Aug 2026 08:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786982254; x=1787587054; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jxcqqZMcfMQG0NRazNx3M9ckLAOYPTmpP07Foy6k8GI=; b=SWopLTobvOJ7ee4Cz9Sq8bA+l++7dwWy+nPFkKO3nHH2Flmz++aBVT9KVfV8sLAjL7 oGj6hLe0QNHXNAF4H7ulw6rT8Lk58npi02Iq/BnzAu1E4Zi/YAsuzdFPQbNgVxC4rInF inf8j0k89P4DEKWz4fj2VYeypEOlU5G/Cq+qbb5ZXbO94DfPHRdQDEUvXBRaOZzvWP1a X6ZKf+O6hCUCs3UyP491SLi6o9YnfZkxz53oYGIT6y2jUJfWMQT3qA41p0PsrUJN89ph DzLtCBp72Ns7E6wuUxmhW2FLpOJ1ATJFEabkNOU7sSULcT4yTSf10E+uZv85EGCs1gfR DUHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786982254; x=1787587054; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jxcqqZMcfMQG0NRazNx3M9ckLAOYPTmpP07Foy6k8GI=; b=Pcfo9kROoNr6Z3mSq40hrAKoed+e5bxl9BydqZUNvyckLF6CyXsC1tZHL/rP8/bQzL /B3FTXtVh78iTdT9d3Bs8sWqj4D4T8jQ5uHj0DFC5QG90/ixEuSYkdxI5uQa2XzV90ru U6dZ2Nq6Ye3wYUBrn+pxk9MXMqY29LQQRv3wL3aGVVohZwrRxftbjGtg4LVdJ+Vyr0uA 3ZYB3mjtKF8CjuyfR7hwrsHxwdk2FJ6Sk4kLCF/Ur+UhNsqbD1pbJJKMkcAFjDk7+8u9 I1Ym492lb1tjB+6J6DgKmvu2Drb5UX66WZNDwd9UBQZ+cqyxTwz5nHMnXHvhFA8j+Ubq M+8w== X-Forwarded-Encrypted: i=1; AHgh+RooXyVWMdfO+RN0o3HMmtT1vRhLOOzk7BBpkJUnSlBxgaj8kZUPwWX76TjtzlEB14STHu72qGWJpAgxJmM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7uLHaKkQ5qn40Jm8HwM74AR7OIGNMIni54LSAvj+FMIb0mWJf aQBRLDie+XRdPwtQ8qfhe4rOnQgeeu1VhZR+D1pyGC8i94HdwgblOyTAQGbhhOh7aMPiSY7G4XD e6xZXSb7/uqNU0yjWmt453/OnvRdVZcHvvtg300H8HidfWz1ym3U3xpixxy8SB0jgxAI= X-Gm-Gg: AR+sD11j4SLYyKbD+VUnjSz2bAkhgQf9Y3PPc9lpdUooPiPAvn0M2FheQcs/KH+BygK aAIoyTQpjMWrGLZXStKdjoLZuCkydIcms4HW4Err/NrOaBhxJThQFXjXK9tysbs+2eHhekYIYJt JkkuIrk+6R53Ee0fiVbsbYkJa94m/vKRNVDwPA29gTyv2MG8PUrsmpepSo7m1hulr+B7H11CdKS 4wooJjQBuoQBJxYiq4USUYprhPDLosBNaZlC46J8CqtSdZnDN6CKanGX2HSYOTNGGvdHSf4eB3k NHa44hw9HmyP4bdvDLvgStvaghtgU9j6evgvIH0YtTntZYsujqTe+dPd80UNYQIE2Kjoe1Wpc3b hy3su3mPWxBxFpVwVq9JGbjo0 X-Received: by 2002:a05:622a:1a86:b0:52d:9db2:7924 with SMTP id d75a77b69052e-52d9db28d13mr113108981cf.1.1786982253498; Mon, 17 Aug 2026 08:57:33 -0700 (PDT) X-Received: by 2002:a05:622a:1a86:b0:52d:9db2:7924 with SMTP id d75a77b69052e-52d9db28d13mr113108391cf.1.1786982252961; Mon, 17 Aug 2026 08:57:32 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d85319b1sm921569a12.13.2026.08.17.08.57.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 08:57:31 -0700 (PDT) Message-ID: <3021cb06-7219-4e54-8188-e9cef09aa1ec@oss.qualcomm.com> Date: Mon, 17 Aug 2026 17:57:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add LeEco Le2 To: Adam Skladowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260810-next-patches-v1-0-79a779d76173@gmail.com> <20260810-next-patches-v1-5-79a779d76173@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810-next-patches-v1-5-79a779d76173@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NpYbyLjIPFgVJF-NI5U3TEDLCvl95Dux X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEyMiBTYWx0ZWRfX/pc0KfQ7K9C7 z0kZoeWwhHmpFnKktRWgUZVmI73T+jHT2HJsb3wSJgF5q+sf0NnfF/IqhV6e7biN7dcUCBQwRFu oUEKD5qLX4V17FvqOkWm8QxX1UJfmb0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEyMiBTYWx0ZWRfXzUqE2Z4tPidb 1+5ARIXdyczlhhtdKc6wGTGeouwRDOkDyG78X2Fh23GK1267k9u/xAYGAOZOsAuRgszyimP0Nl3 55ll23S+0A8El5/VQvJ7cgd4v/afWObCOGH2H16R813JqSHqPy72Tt73KaVM23eKpgzC8xPl8ZG C3w7chXy/M83mGY8SlAVF5b485sV9oLtcHnFahD2CI+xm2cExThGPMpw8WzcY9+PbKMPC4QGDOG /nbCdTuvlXRbqqiQ6koUiLcpLYkpKWmGW9NR/tasPITAOh5wGYvHwjJL2ujqQZHjfjxF1Hm5y2n ySTftO/ra2rWYxkdy822LdxSiVNq+bQ3VAdth72LiHlB6ArCwyI1aPGVILjSZ/eSgengJcmQMQX eyyunYVbW/g4eZDeiLkT9JmLxALLMVw51an+HH9xNpfFYR82Ek3gTWfJj1DmAoeOWiKu/kogl0u sLeWyMn2vlrTZ7DJkuA== X-Authority-Analysis: v=2.4 cv=HYEkiCE8 c=1 sm=1 tr=0 ts=6a832f6e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=c_BSE4CSJTi7_uz2YGEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: NpYbyLjIPFgVJF-NI5U3TEDLCvl95Dux X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_02,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170122 On 8/10/26 6:55 PM, Adam Skladowski wrote: > Add a devicetree for the LeEco Le2 smartphone, which is based > on the Eldarion/MSM8976 SoC. [...] > + reserved-memory { > + > + ramoops { Stray \n above > + compatible = "ramoops"; > + no-map; > + reg = <0 0x9ff00000 0 0x100000>; > + record-size = <0x10000>; > + console-size = <0x60000>; > + ftrace-size = <0x10000>; > + pmsg-size = <0x20000>; > + ecc-size = <16>; > + }; > + > + /delete-node/ memory@83000000; Referring to nodes by their node names is fragile. In this case, you fell victim to that since this node doesn't exist. The more modern approach is to assign a label at the definition site and then do /delete-node/ &foo [...] > +&blsp1_i2c4 { > + status = "okay"; > + > + rmi4-i2c-dev@4b { Node names must be generic, so touchscreen@ > + reg = <0x4b>; > + compatible = "syna,rmi4-i2c"; > + interrupts-extended = <&tlmm 65 0x2008>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + vdd-supply = <&pm8950_l17>; > + vio-supply = <&pm8950_l6>; > + > + syna,reset-delay-ms = <100>; > + syna,startup-delay-ms = <500>; > + rmi4-f01@1 { Let's keep a \n between properties and the following subnodes [...] > +&blsp2_i2c2 { > + status = "okay"; > + > + haptics: haptics@5a { > + compatible = "ti,drv2604"; > + reg = <0x5a>; > + enable-gpios = <&tlmm 109 GPIO_ACTIVE_HIGH>; > + mode = ; > + library-sel = ; > + }; > + > + tiusb320: tusb320@47 { I'm not super sure what this chip is, typec@ or extcon@? > + compatible = "ti,tusb320"; > + reg = <0x47>; > + interrupts-extended = <&tlmm 21 IRQ_TYPE_EDGE_RISING>; > + }; > +}; > + > +&blsp2_i2c4 { > + status = "okay"; > + led-controller@45 { Let's add a \n beforehand > + #address-cells = <1>; > + #size-cells = <0>; > + > + compatible = "awinic,aw2013"; > + reg = <0x45>; > + vcc-supply = <&pm8950_l10>; > + > + led@0 { > + reg = <0>; > + led-max-microamp = <5000>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + }; > + led@1 { And an \n between each subnode [...] > +&otg { > + status = "okay"; Let's keep 'status' last and with a \n before it > + extcon = <&tiusb320>,<0>; The second extcon is optional, you can drop it from the chipidea bindings: minItems: 1 items: - description: vbus extcon maxItems: 1 - description: id extcon maxItems: 1 Konrad