From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Luoxi Li <kaixa@kiloview.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH] mm: Remove unused has_isolate_pageblock
Date: Tue, 22 Oct 2024 11:02:42 +0530 [thread overview]
Message-ID: <30227b5e-a15a-4c77-b35e-db04fde0686d@arm.com> (raw)
In-Reply-To: <20241018092235.2764859-1-kaixa@kiloview.com>
On 10/18/24 14:52, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
>
> Remove it.
>
> Signed-off-by: Luoxi Li <kaixa@kiloview.com>
> ---
> include/linux/page-isolation.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h
> index c16db0067090..73dc2c1841ec 100644
> --- a/include/linux/page-isolation.h
> +++ b/include/linux/page-isolation.h
> @@ -3,10 +3,6 @@
> #define __LINUX_PAGEISOLATION_H
>
> #ifdef CONFIG_MEMORY_ISOLATION
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return zone->nr_isolate_pageblock;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return get_pageblock_migratetype(page) == MIGRATE_ISOLATE;
> @@ -16,10 +12,6 @@ static inline bool is_migrate_isolate(int migratetype)
> return migratetype == MIGRATE_ISOLATE;
> }
> #else
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return false;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return false;
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
prev parent reply other threads:[~2024-10-22 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 9:22 Luoxi Li
2024-10-18 9:24 ` David Hildenbrand
2024-10-18 15:35 ` Muhammad Usama Anjum
2024-10-18 18:59 ` Johannes Weiner
2024-10-22 5:32 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30227b5e-a15a-4c77-b35e-db04fde0686d@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=kaixa@kiloview.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®