From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbbJFVsR (ORCPT ); Tue, 6 Oct 2015 17:48:17 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:57356 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752313AbbJFVsP (ORCPT ); Tue, 6 Oct 2015 17:48:15 -0400 From: Arnd Bergmann To: netdev@vger.kernel.org Cc: davem@davemloft.net, Jiri Pirko , Ido Schimmel , linux-kernel@vger.kernel.org, Elad Raz , Scott Feldman , linux-arm-kernel@lists.infradead.org Subject: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Date: Tue, 06 Oct 2015 23:47:44 +0200 Message-ID: <30258520.VaA2vDyUiY@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:EQ9Q4GkIsVgOA5iC4ewbyRKIM2d/OVyxxi7dnIAKkItcIik208q YTYdcVZCzvWGRojqEioHyaOnZhbe5DlaE67dRP6WQFoE1tBoC5vKlM7LMHnnWa/Ji70OiJj WnzOYPoErgNNxwHZtCT9X8EEOV7uayXrveMOhyXdbm4YBPzACmNDPpBV8VmIKIvtuBswn7s corESEZ1PGnHyAVljBE+Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:9iPIlzOVvXQ=:uR79yiSDqQ1oDryG8dqMxM JYfsr860eILJdXOeLw8nS3wa1bi5sIzgVkDi05UcTF7DJLXkPVUKDFOgsVhdYVT3x97Pt+eUq aDNfdyv9QjF0Ggv2uvJpQKVh85sA1yIXDw1WXg41t1L/bnMvvxgFDYczohTg/UFusIe6jZETH FTt/ARPntAkihy1NNm+4XCHSJp+8HJPGUgJqm/dZp5XeS4Sm0bXflpTrJ+xcsWO2mNmrUOuWt EkIOC8Z+NvC57wF0J0sS4OWljP2eRx1s7Ne7nL8MpX7Nqj3InIOj/hwTX3ROMeaZqB48+07nj O4RPPzWTTKUxCG3jcs4690H9hnkmjh3Gh2aD8YH8nBfSqqmQudPhWhj8spp9qQcZrV9wzk852 2pHUpkg1DmKQvBfSTSZ9ovBeHifCzp6qc7RxwwzToOWbF/lgKYpq03WcMmidLvZJ8h6I3Cfyx gj7qF4qK5nSTKbrwBn58/8jVsxtKpEjWUHwqm0hZi1HVRKYAfC0zyL8oVS8TI1Mt4bdZDHKMJ PJZqc4sZv5VcHjks7FLNbrz4KKIl8RJJzhIR6z0LQ3v5AWPeXSZdIwixHQSgTqxDOKxklLz3y pxgul7hJbDSica/H6oUE0vz9dOSwfVnZnUk1eSDz1zRwZCTfG01bJcrAUnjTc6DdgahZqZaif wVom0acuZ3T72PgPUsZTBro/1DL2IQs0ZgxgobiN/r3F0BaeimjzNqr54MAlVlySyijYxQq0z eSWhAwSPNjmc1f0i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The recently added mlxsw driver produces warnings in ARM allmodconfig: drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow] linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32' drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be' This changes the type of the local variable to u64, which gets rid of the warning and seems nicer than adding #ifdefs. Signed-off-by: Arnd Bergmann Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c index 462cea31ecbb..cd11e3591741 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci.c +++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c @@ -1567,8 +1567,8 @@ static int mlxsw_pci_cmd_exec(void *bus_priv, u16 opcode, u8 opcode_mod, u8 *p_status) { struct mlxsw_pci *mlxsw_pci = bus_priv; - dma_addr_t in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr; - dma_addr_t out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr; + u64 in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr; + u64 out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr; bool evreq = mlxsw_pci->cmd.nopoll; unsigned long timeout = msecs_to_jiffies(MLXSW_PCI_CIR_TIMEOUT_MSECS); bool *p_wait_done = &mlxsw_pci->cmd.wait_done;