From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7066DC388F7 for ; Fri, 13 Nov 2020 12:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 113AD22249 for ; Fri, 13 Nov 2020 12:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HKrfXTZs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbgKMMRZ (ORCPT ); Fri, 13 Nov 2020 07:17:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43257 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgKMMRX (ORCPT ); Fri, 13 Nov 2020 07:17:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605269842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xp9qh1EbaUKfgVroCHBI6P3BnQzVe6f2/PUfddgShQA=; b=HKrfXTZsYWonHV1xlmnUJtecwuR/ajtl/aMLS1DSM8XK27Ao866fwQkwuU7HKqHBuLHDNd W3CM6/XGmflKpZAfdZB06Ep3eNzOa4ZcS4eTugqnDJ8XUhBmYMDLnf8AH8muSewxz+OSWk fzx8GStOmmr9lthBZCGKsb7yHUd2pOs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-tiXD8sprO3iyc_DpKsC80w-1; Fri, 13 Nov 2020 07:17:20 -0500 X-MC-Unique: tiXD8sprO3iyc_DpKsC80w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CDA8E80475A; Fri, 13 Nov 2020 12:17:18 +0000 (UTC) Received: from [10.36.114.34] (ovpn-114-34.ams2.redhat.com [10.36.114.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB28B75128; Fri, 13 Nov 2020 12:17:16 +0000 (UTC) Subject: Re: [PATCH v3 3/5] kernel/power: allow hibernation with page_poison sanity checking To: Vlastimil Babka , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Potapenko , Kees Cook , Michal Hocko , Mateusz Nosek , Laura Abbott , "Rafael J . Wysocki" References: <20201113104033.22907-1-vbabka@suse.cz> <20201113104033.22907-4-vbabka@suse.cz> <751f6a7b-afa3-fe8f-5df2-5a604b762d6a@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <3028d955-5cc7-aa52-5c07-7109038fdd3e@redhat.com> Date: Fri, 13 Nov 2020 13:17:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.11.20 13:15, Vlastimil Babka wrote: > On 11/13/20 1:10 PM, David Hildenbrand wrote: >>> @@ -1186,12 +1194,12 @@ void clear_free_pages(void) >>> if (WARN_ON(!(free_pages_map))) >>> return; >>> >>> - if (IS_ENABLED(CONFIG_PAGE_POISONING_ZERO) || want_init_on_free()) { >>> + if (page_poisoning_enabled() || want_init_on_free()) { >> >> Any reason why not to use the static version here? > > It's a single check per resume, so not worth live-patching this place. Agreed, thanks. -- Thanks, David / dhildenb