From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>, Vignesh R <vigneshr@ti.com>,
<linux-iio@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lee Jones <lee.jones@linaro.org>, "Andrew F . Davis" <afd@ti.com>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support
Date: Thu, 22 Sep 2016 14:16:42 +0300 [thread overview]
Message-ID: <30294b90-af44-d8cf-d70b-92a9461f1e5f@ti.com> (raw)
In-Reply-To: <0cd3dfcc-2525-c2fb-35ab-1b260c5973a8@ti.com>
On 09/22/16 13:45, Mugunthan V N wrote:
>>> + if (!dma->chan)
>>> + return -ENODEV;
>>> +
>>> + /* RX buffer */
>>> + dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE,
>>> + &dma->addr, GFP_KERNEL);
>>> + if (!dma->buf)
>>> + goto err;
>>> +
>>> + dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n");
>>
>> Do we need _ratelimited? AFAICS, this print is called only once.
>
> True, will change to dev_dbg.
It would be better to remove it. It gives no useful debuggin information apart
from the fact that the driver did not failed to probe.
--
Péter
next prev parent reply other threads:[~2016-09-22 11:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:11 [PATCH 0/4] Add DMA support for ti_am335x_adc driver Mugunthan V N
2016-09-21 16:11 ` [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Mugunthan V N
2016-09-27 19:40 ` Lee Jones
2016-09-30 8:43 ` Mugunthan V N
2016-10-26 12:17 ` Lee Jones
2016-10-30 17:05 ` Jonathan Cameron
2016-10-31 8:16 ` Lee Jones
2016-11-05 17:45 ` Jonathan Cameron
2016-09-21 16:11 ` [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support Mugunthan V N
2016-09-22 6:18 ` Vignesh R
2016-09-22 10:45 ` Mugunthan V N
2016-09-22 11:16 ` Peter Ujfalusi [this message]
2016-09-22 7:20 ` Peter Ujfalusi
2016-09-22 10:56 ` Mugunthan V N
2016-09-21 16:11 ` [PATCH 3/4] ARM: dts: am33xx: add DMA properties for tscadc Mugunthan V N
2016-09-21 16:11 ` [PATCH 4/4] ARM: dts: am4372: " Mugunthan V N
2016-09-25 9:41 ` [PATCH 0/4] Add DMA support for ti_am335x_adc driver Jonathan Cameron
2016-09-29 13:01 ` Mugunthan V N
2016-09-30 3:37 ` John Syne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30294b90-af44-d8cf-d70b-92a9461f1e5f@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®