From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EA143451CA for ; Thu, 4 Dec 2025 14:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764859385; cv=none; b=NBvb6rYf622Zw62w9Qrs+e00zuUqMzucos7VK6c0EHe+PhVpD2p3dJohlUpMG7oDclk/bBk5dWCYm/RmCTGKqN72eEemOuDy2UdkfC04PrNj5In2DYpq4tKc+g1JrizKXkP2eqizF7sGCNsKVKeoluyB4YLDzG2g0nC8NlS0aes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764859385; c=relaxed/simple; bh=AV5mxYzuJRY9QKz5J8npWRK+M05FxuwULtIwjrSBO6w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BxN6+4Vy93nZSJydNfogtFVORmieu0yEVShYo/Ex3PEbOAInCRTWstzbmk46qZ1fQCKDf7za1Jk44L15NBEvyPnSo2QUY8v0nXah0MuMlDjCj+1dIvc3XUNGQIhs+GxGy/IppTB+Ox0ujhjNe+0NPRf5G1T0T4qywftgd/CVAcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iESoctJM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UKCb1Y5A; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iESoctJM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UKCb1Y5A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764859382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5SPciRZnhMCYxxi9bUFLlwchhvtriJcaoeYo268wAs8=; b=iESoctJMDHBk+OFqIwFj+cnu17PmKBqgQyp/JlRJbcE4qCNRTWdc/6gXRT5nDUq7TpKUIk edtfc/j9XAnYkkzLzzwUfXES1Kvb5AZuh0hfSfaZxkWYZ9eg3SIaVIF6XHPLIgt5PYszLs tbDYXnbx9ymFWLFrtgBtUeSLLoIem6A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-sTANoT-oO6ipb1SnU-yXAQ-1; Thu, 04 Dec 2025 09:43:00 -0500 X-MC-Unique: sTANoT-oO6ipb1SnU-yXAQ-1 X-Mimecast-MFC-AGG-ID: sTANoT-oO6ipb1SnU-yXAQ_1764859379 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42b2e448bd9so1197715f8f.1 for ; Thu, 04 Dec 2025 06:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764859379; x=1765464179; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5SPciRZnhMCYxxi9bUFLlwchhvtriJcaoeYo268wAs8=; b=UKCb1Y5ACAFsfXNWbE9weuQCJUW7HCP0MOyi5K/uaoCBKlykoTQENz8CQ5RDdldiDF s+bE7Nh4WTb6eBKI6EPwiUzkb/OdURH6ZqIhuV111u8pqA9F6oFW0MArdygxgsiiQvEq hwuiEp+E3hp0mlN8pl/1JeqYHyLQWmdu8+iK+DnXgSQ4Lh1datrx3AaUrsWJze01FDrS 9g2TGIqrCvAfckhQUftv9zlwW0IpaH8+D3C5YRsAumNKD4cYTo2YgoIMlIGwdonTGrPh 48/5d76dHwW+WTSwAf4i/FkUlsfFmFYeYRP4eJtZELjVv1hG44/wQS0+5V6phxGtVrVs vJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764859379; x=1765464179; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5SPciRZnhMCYxxi9bUFLlwchhvtriJcaoeYo268wAs8=; b=m/hLsulIdO6ar9Jwkr8yn8rHitHlTaMwJDw+NIskn6g44kzx4dtcBzV4ghgQRZ9pGI BVORv/YCrbR9SFLkWa9aPOBPJa2gqPnoM6dwhQ45pYuQOaus4tSyHd0G41ZihAQr8ggy k/SwQqVlb3qcm0TsqC1WeGNu1yT992P1JLizeLve8fANQ/OuiaFbNKRjSIik4u7FAK2W wItXASlfvLDS4OKRzMF8BWUutRO6PFv6klo0IIs4ERRrAEfmKJro7RhlXo768ueRRQzy xuojw6tYO5+13WTXWBKegAk7ValJmh7JAtAj/KCV3/zWG96QBV1H8ir4rEwnIXQLrxzN +Vjg== X-Forwarded-Encrypted: i=1; AJvYcCUldvy3TXnIYm4dLzsF5HYR2iRNxzew1qzrcsrO32mYDdos1wBbgkWQ8SpcGnXmrkTbhsnXt9LhYyERdpw=@vger.kernel.org X-Gm-Message-State: AOJu0YzOANuSyBItrJ+XjlS547GtRqsi4TUInx0gJNNRRBtvsWbMHrc/ xGK81yDFHnSQ9yxlTqNwU1Kgp72JN2KYn1dL2BbsHcMjsb3t4YCrjz1gTOd6QV/e5Crw9+pIU4H giVpIqcVdQ/6NfwfVJPnY6i9z8URhBCQ4ztvaetYGxhEj4Z6b2yamh9EYGTfJlDLSiQ== X-Gm-Gg: ASbGnctehbjXmlBfMgKxhso1MQKpDpQKq/SY4pi7Vjav7Mw8Kb4skfwxlng+slgHQlk JPjR4gZIdFkADagjGtyDqkh4Y0du4AK1HB2wOsX0Jjo9dLB8LIFPOV4hceGi7tSbtxPQdRFZ69A sUrY1hcEPW6MfOuWJHm7VF8GIQC95dwuFer7rj+7zfqQMNdaNs4DKmkWF0hbj2DOQGlJ/slAuoz eIkKFES5cIddKwyQwKnIImJZtGdSOj53rsxmC7u5mRLg9iRLj5gtN5dquY4+4i0I722R7GqPNWv GJrDOvXQNIzP3GZ3aJ59N36qmhY8AAXMkFDzVMccl8M1HkePByX//vwYql9+Vz405ScWGnO6IAD lPdwNgw1FHtN3 X-Received: by 2002:a05:6000:40dc:b0:42b:3c25:ccea with SMTP id ffacd0b85a97d-42f79854663mr3262714f8f.42.1764859379086; Thu, 04 Dec 2025 06:42:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHq5iHKmbwlNS+kV/3eOCvmvglxRGYX2IRDqq4Wl36tZWf7LIh1cmyHgIKvKJm10WNznK22og== X-Received: by 2002:a05:6000:40dc:b0:42b:3c25:ccea with SMTP id ffacd0b85a97d-42f79854663mr3262682f8f.42.1764859378686; Thu, 04 Dec 2025 06:42:58 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfee66sm3527210f8f.11.2025.12.04.06.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 06:42:58 -0800 (PST) Message-ID: <3029c00c-4df4-4389-a031-76d4793a426a@redhat.com> Date: Thu, 4 Dec 2025 15:42:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/2] ipvlan: Take addr_lock in ipvlan_open() To: Dmitry Skorodumov , netdev@vger.kernel.org, Jakub Kicinski , Kuniyuki Iwashima , Xiao Liang , Stanislav Fomichev , Etienne Champetier , "David S. Miller" , linux-kernel@vger.kernel.org Cc: Andrew Lunn , Eric Dumazet References: <20251202141149.4144248-1-skorodumov.dmitry@huawei.com> <20251202141149.4144248-3-skorodumov.dmitry@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251202141149.4144248-3-skorodumov.dmitry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/2/25 3:11 PM, Dmitry Skorodumov wrote: > diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c > index c390f4241621..53d311af2f44 100644 > --- a/drivers/net/ipvlan/ipvlan_main.c > +++ b/drivers/net/ipvlan/ipvlan_main.c > @@ -182,18 +182,18 @@ static void ipvlan_uninit(struct net_device *dev) > static int ipvlan_open(struct net_device *dev) > { > struct ipvl_dev *ipvlan = netdev_priv(dev); > + struct ipvl_port *port = ipvlan->port; > struct ipvl_addr *addr; > > - if (ipvlan->port->mode == IPVLAN_MODE_L3 || > - ipvlan->port->mode == IPVLAN_MODE_L3S) > + if (port->mode == IPVLAN_MODE_L3 || port->mode == IPVLAN_MODE_L3S) > dev->flags |= IFF_NOARP; > else > dev->flags &= ~IFF_NOARP; > > - rcu_read_lock(); > + spin_lock_bh(&port->addrs_lock); > list_for_each_entry_rcu(addr, &ipvlan->addrs, anode) I'm surprised lockdep/rcu debug does not complain above. In any case I think you should replace list_for_each_entry_rcu() with list_for_each_entry(), here and below. Thanks, Paolo