From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B23376465 for ; Fri, 6 Feb 2026 11:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770377220; cv=none; b=HN56g7hlFOYR382FDvh1TWru0fx/4wB/td+2nWBrNRuIcw25viw9Cbu0rf2PuotsvDm31d7ZDlBfrG+BWM19aIeFni5evveZxZN5SwBYnVFMFA1eESA+ZtYiH101TXIlnpxGmL2flEMZ7TZRSaRbr2xcqtEB2ffiV23IrwS2zfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770377220; c=relaxed/simple; bh=Pv+4mxHOkuQGdUlGt/TWxFbKeqDqXomI1Q3G96+VfbU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M8kS5fZiG8VwXdWA+ZmOums3xUt1RH7dg/R7lLfTEp3V5MtUDoG+VvQdxv6H9A1FBq9rOzKE70cOQD+72YM7UO2YgqH1XK8W0iH365a0/CqUx5BFL1L+IdkjiWukZZBJbaJuEmdIZqunQKLY/afhDLAmmjfS/g8Cc7EhmIqk4mE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ONImB0ez; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ONImB0ez" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47ee937ecf2so19248545e9.0 for ; Fri, 06 Feb 2026 03:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770377218; x=1770982018; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kwf4O/lyGf9gvN08ToIQWPbaXEEjGuvKl+rS2tkfhIo=; b=ONImB0ezxDkENZoi5K6K4rjKByrChUJ6OJpRljv+GkC2kuVz5cXbpHJ0JI3TOigkRH uwOsxVH/5DbX8KODdlbYz7kc7uOaKyE15TyjCkqXDaq56P5mLjz/3l/Cp0fMvqmaokm+ PJ4SfffxeXcRQ7Dgt0UkfCyubvdh6VaVmB4xaGLtM+m25b+YB18aUGkMZLGk5HapIhWS Scz4FQ0NOUOSHB2oiHJqqksH8v/lheMhbPdTpDDMrcjWlfOErXXFxmEfqVttwP3H61w9 QA59cmEPPaqgQaVpWdRT3O4UZIvOZow4BNxKDUpd6pq0Y/I+D1KnFsdWJiwxfed2ITTr PC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770377218; x=1770982018; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kwf4O/lyGf9gvN08ToIQWPbaXEEjGuvKl+rS2tkfhIo=; b=kLWDxtrJikFctHLhLWkA8Fe6v7IJ3FQ8j3ntoxClECkapGrsN/1t5q5kU4ZiOA5Q5B zk3ORRUHcNjaA5khZFrFmhiICVhCMcRbpwpZk9pFmLO4EADDhhnRPuXrIPeF2QQbLK+s 15Ou7H7+0m793wzFIowkqOys716RrLufeE6RTElJ/TYXIexE++JbqEpb1xYuzv3UF0gs OYjMYCmz9RYbL4QXI2umFrFLt01joj0e0aYylCDZlElgVwhZXvR9KJ7tsplvYYZ/8C9t 1EN/cDBvPyC2fBNEDZy/Q1Gj5nqMBF4kwVn2dYuO/WHS/AXq75EHuYdg+UG4rWu+FSx1 ekyg== X-Forwarded-Encrypted: i=1; AJvYcCW0mKr3ZCSx7qgpua2g8LGuUG+oz6wLnPDjP4MeVg/7WPTmWHmiPzaFhNp3IyYIGJbq6J/9IFFwxWCqYiA=@vger.kernel.org X-Gm-Message-State: AOJu0YxBxfB5ri1sVDEAhYhRlg6j0Pf7pMopHluelOpNtzkCJdllqnNp vQzyscKPM6ZNH/fuX8s2QOl9xuhukUnl8XQtMdsKMs0H1PkgV3MtwaIve81SkpgbEBU= X-Gm-Gg: AZuq6aLm0XpzhhwT1lOIGBP1AdaBNyd8MnWhqzNnzpyN2H0+eIYHlOB7Eq0aTZpHI3O EndfZhQMleBS5TvPhftuVYq9whcrZHzOatefxoRfPSFsm0E9nqwh7Hj/ybNLM0SAV1C7vHAdjOt OQecVdWeNRmHALBD10K+zJ/yJDHKs13i66I0IeUw4ArBPvzF9f9y0Z2nKTopciMFZIr/W2mYUhz GrJKuO3zTaW4xfgdFwvF58zxBbkCRBeoUxXohz5VqIWgcBR/iZv6qtukBOoJ/sxRC7guUi8WozT oxvrLdl0Ar8MDi4TgefFS2xKuS25k8vaJJ/PiIkfoQ4XYY75X1TI3QgmusCimEsYIJz3yFAwmKF vgyQJUXUm4Qte7MkAXQnHx6Rvq2jUviSYEDc7yEkCf8R3+oxG+3UC53H3WFBnD/X2NgYzrYXU/m nRwh+bPou68+tGOtPyEcYthdhpxUfoiS+ZZEOhh4JQIp7Ep/shxqzM X-Received: by 2002:a7b:c3d5:0:b0:47e:e38b:a83 with SMTP id 5b1f17b1804b1-483178ebf8emr55909675e9.7.1770377218103; Fri, 06 Feb 2026 03:26:58 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d299bfsm111548255e9.2.2026.02.06.03.26.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 03:26:57 -0800 (PST) Message-ID: <302a655c-ba75-4fe5-80ce-2a38941e25bc@linaro.org> Date: Fri, 6 Feb 2026 11:26:55 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency To: Arnd Bergmann , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab Cc: Arnd Bergmann , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260205145623.1360105-1-arnd@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260205145623.1360105-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/02/2026 14:56, Arnd Bergmann wrote: > From: Arnd Bergmann > > When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y, > the kernel fails to link: > > x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load': > iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size' > iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load' > > The problem is the conditional 'select' statement. Change this to > make the driver built-in here regardless of CONFIG_ARCH_QCOM. > > Signed-off-by: Arnd Bergmann > --- > drivers/media/platform/qcom/iris/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig > index 3c803a05305a..5498f48362d1 100644 > --- a/drivers/media/platform/qcom/iris/Kconfig > +++ b/drivers/media/platform/qcom/iris/Kconfig > @@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS > depends on VIDEO_DEV > depends on ARCH_QCOM || COMPILE_TEST > select V4L2_MEM2MEM_DEV > - select QCOM_MDT_LOADER if ARCH_QCOM > + select QCOM_MDT_LOADER > select QCOM_SCM > select VIDEOBUF2_DMA_CONTIG > help > -- > 2.39.5 > Reviewed-by: Bryan O'Donoghue