From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FB43E7175 for ; Tue, 17 Mar 2026 14:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758803; cv=none; b=cEfcV8c1aQdjshvWuWT30nU/HKPEoPVQYq1Kit2y5YmWHe2h6drIhuCA1fnyYZcJAC4Aw9F1Ot/baDrTy/ME4nk26k+LCzwKR+UgEsQi5XBqH3GS6jitguXblLe2pUrndfcD7tAioNfHi70BhAf/K9fxtKFd0XeVYu0MkycONbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758803; c=relaxed/simple; bh=PJwDGvf6trB943jn00qkBQDhhgwKxS7QkCVGOozd50M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CWQqDYknNtVI5ktO7entiS0elZGgzCrn3QrCjWXG/RR3M2A6RvDDwNcn7Y/ZG8wyZJdeN711jkCgENZ9Z7oL9OKps/yhy6ZkUatclfSRmoi8vcYmbv+GwzXnqQsAvDpH55jgNaz8FZ6YUXRE0C4Nj21emPcZg3l9dB2PaCG8XPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EPpY5Q7r; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=pMlPTG9P; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EPpY5Q7r"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="pMlPTG9P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773758801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYgcgasxNaCa6wbkN3+j7gIOt+KWXemXDliasEJTpOA=; b=EPpY5Q7rKbsFq12yyx8xGUJjJvc2B1SiqsbPWZS11RI8WxYTHyiYQUmDcV30tmpianbnJo 9nnaQmjSQfLISqmW+kkv/uuHeQJ+qXGywSR+VD39HN2Lx4it0MSK/kactgk7fPQRCMCWEy vuFSNXH6m4tLTaucRIADgyLqM309GKg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14-HjF1dr4MOAKUp9Vpm-PhYA-1; Tue, 17 Mar 2026 10:46:39 -0400 X-MC-Unique: HjF1dr4MOAKUp9Vpm-PhYA-1 X-Mimecast-MFC-AGG-ID: HjF1dr4MOAKUp9Vpm-PhYA_1773758799 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-899eacb58a5so596618436d6.1 for ; Tue, 17 Mar 2026 07:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773758799; x=1774363599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PYgcgasxNaCa6wbkN3+j7gIOt+KWXemXDliasEJTpOA=; b=pMlPTG9PVkskqz/dOz3RrAN0rica3bqhcGOP1yr90IjXf0/wzBFNlX8jYoHw+Otgmc s+twZKY8zKjhRPjpJiEPYi1vL1yAr35Lc5KCsic0TxSoHFVWTjkW8oDz+t0dHZX7hdvQ Uy27x7kXIUazrKO2i2Hpyxw+Ilsl0xL/okDwchS4VyUB/jyOXSwsK7G2PaY7pKILbzwV DjrKfH9XyY0SFPj1oHEM5YHxzunlBsVxSR6wF9L8OjJzSTfz1SwGJ8UBjnKSmDD9gVhl Ikt2C61WByxfkov9D2mOUi45zzizXx7jYZWGgeJa7/Fe+5NKzxfgI+3/P3RuAVRWaxFA iTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773758799; x=1774363599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PYgcgasxNaCa6wbkN3+j7gIOt+KWXemXDliasEJTpOA=; b=OYjy+kWmEgCrWI9PyWx5i8pv6pfz02rSSnCvIqUWI/7IG/XMkpZdzHr7zhrb1JUjMN q+cecQaDiceGaWIh8v14A2RykgBPgq0ThPRIfMrwr8jtAVwYYINPVXqetrjh2YH1BpK2 x1O5NEG5DmHfNg1B+jrNWXi+yUOycFbTFuisE0QdEAhskMDhFLvvdlF5uvgmB1oQ7vwD RaeLQtnFaquTfqb9Yc0Z7mT3Oo5Z4aBOCKIpFfAqk4ZXN4uffvMQ2yROZfjC/MiA5rhp ujXRWRPW6KhzQYTM1U2yzUVSJ1jG1+eYPDBQ/wAX/gApMIf2HgnW5QXaDd4PBcMzUDfY g9kA== X-Forwarded-Encrypted: i=1; AJvYcCVqbLpzHOHl5ZLNxQiEX7/1afGDPG4AAoZ12a35UUPmroXA9DqTMmGs7HnxGRZTAMiBAxFkYG5b25wWVwI=@vger.kernel.org X-Gm-Message-State: AOJu0YyLSRTLci23E46Pdo/ioYQ/ZlZC6fTH129ZdCbJ8qT+Ty3DCAq2 /JN3OqG9Yy6f7LqaNGTnpdQHHya1UVUMf6W4IOQ7bm9VCOFWVXJINS5xj9zREuytEUeovi2c5IH bJrjESZFVvAAdJ9+Ff+mzqqtJGWHiGm0fIW7N5h/7KwuASYIHvwsm69lrmobikLE01A== X-Gm-Gg: ATEYQzw8WFG4aYQUikCjQ3N206fsNR8YHfBtD0k4Le282ZG3GoUnUlf83+5PtW1Ylx4 S2k0Yki8VBueG7XFhUSqJkYuTUFNxPnHP4Jy+fWWsuTdacZcreh7gLgR8oTpX8yZYcMj9ElnQPD mNG/CYmq2/gXu5UL+rRNBiaiSC/8/wy1X/JaVIWiqxPoUf6x5w9p98YTGkEo5pmjAYQLMhgDEA4 wyzL3ZKeubNcUqoZ3XFC44Qh60qqRWSWopqWjjHU07PPgdRHEcDejW3BW2LReVEFyYHw3t2aKCp 77fcGQ3sE4ppbChtYBx5MbWHaMzgAh+ssivFB3lLPs4kP87Ej4ne6SrdIeU+Zig+ByY+wCre50y xDJmUDRZOABt/xVB9zNgVNq8gP/AU5AHoGSLXcKXf7lgKrlOA3TqRxZA= X-Received: by 2002:a05:6214:130d:b0:899:ee4e:63b6 with SMTP id 6a1803df08f44-89a81f6062fmr268303386d6.44.1773758799353; Tue, 17 Mar 2026 07:46:39 -0700 (PDT) X-Received: by 2002:a05:6214:130d:b0:899:ee4e:63b6 with SMTP id 6a1803df08f44-89a81f6062fmr268302936d6.44.1773758798845; Tue, 17 Mar 2026 07:46:38 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c4feaaebasm49171566d6.37.2026.03.17.07.46.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:46:38 -0700 (PDT) Message-ID: <302d1a45-dd5d-4d50-a99c-ce73de196d0c@redhat.com> Date: Tue, 17 Mar 2026 15:46:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] selftests/vsock: fix vmtest.sh for read-only nested VM runners To: Bobby Eshleman , Stefano Garzarella , Shuah Khan Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski , Bobby Eshleman References: <20260313-vsock-vmtest-nested-fixes-v1-0-d0e6274c3193@meta.com> <20260313-vsock-vmtest-nested-fixes-v1-1-d0e6274c3193@meta.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260313-vsock-vmtest-nested-fixes-v1-1-d0e6274c3193@meta.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/26 1:00 AM, Bobby Eshleman wrote: > tools/testing/selftests/vsock/vmtest.sh | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh > index 86e338886b33..c2cfcdf05d99 100755 > --- a/tools/testing/selftests/vsock/vmtest.sh > +++ b/tools/testing/selftests/vsock/vmtest.sh > @@ -42,6 +42,8 @@ readonly KERNEL_CMDLINE="\ > virtme.ssh virtme_ssh_channel=tcp virtme_ssh_user=$USER \ > " > readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log) > +readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX) shellcheck complains: In vmtest.sh line 45: readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. > @@ -451,11 +464,14 @@ vm_start() { > --run \ > ${kernel_opt} \ > ${verbose_opt} \ > + --rwdir=/root=${TEST_HOME} \ And here, too: In vmtest.sh line 467: --rwdir=/root=${TEST_HOME} \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: --rwdir=/root="${TEST_HOME}" \ The first occurrence could possibly be explicitly silenced explicitly, but it's probably better to really address the latter. /P