From: Rijo Thomas <Rijo-john.Thomas@amd.com>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tee: amdtee: Make use of the helper macro LIST_HEAD()
Date: Wed, 9 Feb 2022 12:46:36 +0530 [thread overview]
Message-ID: <302e8426-5a22-23dd-2b3b-7eb6d0ee2e8d@amd.com> (raw)
In-Reply-To: <20220209032745.38570-1-cai.huoqing@linux.dev>
On 2/9/2022 8:57 AM, Cai Huoqing wrote:
> Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> "LIST_HEAD(head)" to simplify the code.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> drivers/tee/amdtee/call.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
> index 07f36ac834c8..cec6e70f0ac9 100644
> --- a/drivers/tee/amdtee/call.c
> +++ b/drivers/tee/amdtee/call.c
> @@ -122,7 +122,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
> }
>
> static DEFINE_MUTEX(ta_refcount_mutex);
> -static struct list_head ta_list = LIST_HEAD_INIT(ta_list);
> +static LIST_HEAD(ta_list);
>
Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Thanks,
Rijo
> static u32 get_ta_refcount(u32 ta_handle)
> {
>
next prev parent reply other threads:[~2022-02-09 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 3:27 Cai Huoqing
2022-02-09 7:16 ` Rijo Thomas [this message]
2022-02-15 6:49 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=302e8426-5a22-23dd-2b3b-7eb6d0ee2e8d@amd.com \
--to=rijo-john.thomas@amd.com \
--cc=Devaraj.Rangasamy@amd.com \
--cc=cai.huoqing@linux.dev \
--cc=dan.carpenter@oracle.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®