From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbcAZWs6 (ORCPT ); Tue, 26 Jan 2016 17:48:58 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:48549 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750851AbcAZWs4 (ORCPT ); Tue, 26 Jan 2016 17:48:56 -0500 From: "Rafael J. Wysocki" To: Juri Lelli Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, "# v4 . 2+" , open list , Juri Lelli Subject: Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data Date: Tue, 26 Jan 2016 23:49:48 +0100 Message-ID: <30317803.WdZJECVyOY@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160126180119.GK10898@e106622-lin> References: <1297c8fc8135f8b5359f9c49d220a939c0ee640e.1453741314.git.viresh.kumar@linaro.org> <20160126095751.GJ10898@e106622-lin> <20160126180119.GK10898@e106622-lin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 26, 2016 06:01:19 PM Juri Lelli wrote: > On 26/01/16 09:57, Juri Lelli wrote: > > Hi Viresh, > > > > On 25/01/16 22:33, Viresh Kumar wrote: > > > There is a little race discovered by Juri, where we are able to: > > > - create and read a sysfs file before policy->governor_data is being set > > > to a non NULL value. > > > OR > > > - set policy->governor_data to NULL, and reading a file before being > > > destroyed. > > > [cut] > > So, this goes away with your patch (that I forward ported) and a small > additional fix on top of that. Which patch exactly is that? Thanks, Rafael