From: "David Ellingsworth" <david@identd.dyndns.org>
To: "Hans Verkuil" <hverkuil@xs4all.nl>
Cc: "Hans de Goede" <j.w.r.degoede@hhs.nl>,
v4l <video4linux-list@redhat.com>,
"Laurent Pinchart" <laurent.pinchart@skynet.be>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
linux-kernel@vger.kernel.org, "Mike Isely" <isely@isely.net>
Subject: Re: V4L2: switch to register_chrdev_region: needs testing/review of release() handling
Date: Sun, 17 Aug 2008 18:27:17 -0400 [thread overview]
Message-ID: <30353c3d0808171527n6c4c6546iddf8f55253373508@mail.gmail.com> (raw)
In-Reply-To: <200808172340.02280.hverkuil@xs4all.nl>
I like what you've done with this, it's very close to the patch I had
in mind. I especially like the way you hijacked cdev's kobj release..
I hadn't considered that. I would have sent you my version, but it was
based on the old videodev.c and needed to be redone after the videodev
split. The associated patch which moves cdev_del to video_release is
definitely the right thing to do. I don't know if it means much, but I
ACK this patch with the associated patch that moves cdev_del to
video_release.
ACKed by David Ellingsworth
next prev parent reply other threads:[~2008-08-17 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 15:09 Hans Verkuil
2008-08-17 18:30 ` Hans de Goede
2008-08-17 19:46 ` Hans Verkuil
2008-08-17 21:29 ` Hans de Goede
2008-08-17 21:40 ` Hans Verkuil
2008-08-17 22:27 ` David Ellingsworth [this message]
2008-08-23 14:01 ` Laurent Pinchart
2008-08-23 14:31 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30353c3d0808171527n6c4c6546iddf8f55253373508@mail.gmail.com \
--to=david@identd.dyndns.org \
--cc=hverkuil@xs4all.nl \
--cc=isely@isely.net \
--cc=j.w.r.degoede@hhs.nl \
--cc=laurent.pinchart@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®