From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47EFBC004D4 for ; Thu, 19 Jan 2023 21:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbjASVYg (ORCPT ); Thu, 19 Jan 2023 16:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbjASVW0 (ORCPT ); Thu, 19 Jan 2023 16:22:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 620C9A2962 for ; Thu, 19 Jan 2023 13:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674162892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i1IMCqddgWykv8AXR/YeAqVJq9PsFQed00N0J64kJGo=; b=N+XavR/d04kvy+vNmHXdROxgc6zSa1gu52k4JmGlCInBqaqV4a56nO74nl7efG96BZ1Yuu jYppticNL32L/kHl0dh82P71m+qmi17pZAfpHMZdn+YMZOfFe89bTU6YauZ9gXD1uwbmbB QIs0Y1IK7NjSKbHCf2indjYjliyE9bU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-hi1FagP5OzO-eBN77YCRog-1; Thu, 19 Jan 2023 16:14:49 -0500 X-MC-Unique: hi1FagP5OzO-eBN77YCRog-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BAE92181E3F4; Thu, 19 Jan 2023 21:14:48 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id D291A51EF; Thu, 19 Jan 2023 21:14:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391048988.2311931.1567396746365286847.stgit@warthog.procyon.org.uk> <2731230.1674128066@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3037548.1674162886.1@warthog.procyon.org.uk> Date: Thu, 19 Jan 2023 21:14:46 +0000 Message-ID: <3037549.1674162886@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > So what about deferring this whole cleanup for now? So you'd rather I stick with the direction indicator in the iov_iter struct for now? I still want to add iov_iter_extract_pages(), netfs_extract_user_iter() and netfs_extract_iter_to_sg(), even if it's only cifs and netfslib that use them for the moment. David