mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	kernel-janitors@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM
Date: Wed, 06 May 2020 13:59:48 -0700	[thread overview]
Message-ID: <303818f9b6dc16880b3bc715c16144e4245022b8.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2005062232330.23358@felia>

On Wed, 2020-05-06 at 22:37 +0200, Lukas Bulwahn wrote:
> 
> On Wed, 6 May 2020, Andy Shevchenko wrote:
> 
> > On Wed, May 6, 2020 at 8:46 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > > Hi Pierre,
> > > 
> > > with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"),
> > > visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS
> > > complains:
> > > 
> > > WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order
> > > #14723: FILE: MAINTAINERS:14723:
> > > +F:     drivers/pci/hotplug/s390_pci_hpc.c
> > > +F:     Documentation/s390/pci.rst
> > > 
> > > 
> > > This is due to wrong ordering of the entries in your submission. If you
> > > would like me to send you a patch fixing that, please just let me know.
> > > 
> > > It is a recent addition to checkpatch.pl to report ordering problems in
> > > MAINTAINERS, so you might have not seen that at submission time.
> > 
> > Why not to send a patch?
> > Same for the rest of similar mails from you.
> > 
> 
> Well, the checkpatch warning is new, so I want to find out if and make 
> sure that the involved developers are generally okay getting those patches 
> or if there is a better way handling those patches to MAINTAINERS.
> 
> I do not expect that there are too many further cases of this warning 
> appearing soon in linux-next now that checkpatch already warns about it.

Hey Lukas.

Don't expect _too_ much as checkpatch has for a long time
has done add/delete/move tests for files and emitted a
"Does MAINTAINERS need updating" message that most have
ignored or not seen as many patches are submitted without
running checkpatch.



      reply	other threads:[~2020-05-06 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  5:45 Lukas Bulwahn
2020-05-06 10:51 ` Andy Shevchenko
2020-05-06 17:09   ` Joe Perches
2020-05-06 20:37   ` Lukas Bulwahn
2020-05-06 20:59     ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=303818f9b6dc16880b3bc715c16144e4245022b8.camel@perches.com \
    --to=joe@perches.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gor@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=pmorel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®