From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ewsoutbound.kpnmail.nl (ewsoutbound.kpnmail.nl [195.121.94.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD8C36920F for ; Sun, 12 Jul 2026 18:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.121.94.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783880637; cv=none; b=jY9bDpmiG5J4wEVoprBfspB8lCzTEGzRSDTgaYHquM/Sk4E/vwQDRSqOY+Q5Az+vqgHRhV9GuHzdyrg5rQGkrbk1EYBa635I3aPPfJS3hgZHC5tEkPdb6iAo4/K6mhdQBp+ACdlxYt6C4hVNYCddc0wTODX7TOK8f0cBGZAxNzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783880637; c=relaxed/simple; bh=1ht5Xi7NqZEOsCXukCa4rXgRnRL+wPnYzotnuGAEM0o=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=sfdDrk0mW4G5X/GwGDexyHqAmUSNJgtcvo0aQYsp7vrOpM3TtwKFEIf6TjOcrj1yjJKFY01xrx2bUCmM1foWsKTH1kU3Wlv0vv/blgX9/4z5PxXQJdwliPJc/dsMRWyUKUsLl60hwOpLOVhPV0S59I22LvppCE5KLL4awQ0Z5lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl; spf=pass smtp.mailfrom=xs4all.nl; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b=YZSuFshK; arc=none smtp.client-ip=195.121.94.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="YZSuFshK" X-KPN-MessageId: d60dc0e8-7e1e-11f1-bfba-00505699b430 Received: from mta.kpnmail.nl (unknown [10.31.161.188]) by ewsoutbound.so.kpn.org (Halon) with ESMTPS id d60dc0e8-7e1e-11f1-bfba-00505699b430; Sun, 12 Jul 2026 20:23:53 +0200 (CEST) Received: from mtaoutbound.kpnmail.nl (unknown [10.128.135.189]) by mta.kpnmail.nl (Halon) with ESMTP id d60ce0f0-7e1e-11f1-9b0c-00505699693e; Sun, 12 Jul 2026 20:23:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=xs4all01; h=content-type:mime-version:subject:message-id:to:from:date; bh=8wgP3O8n0kcAv/voUODxDUkCGHcLdFCenE1jmdQGu8U=; b=YZSuFshKfCwzGZGu9t/GxZgfWal6HyJgj55otMW9io2N8xdGphyrybcN+n6DnlxjifbPLr2XHoqHw VIdSGpJ1VXCjluFqSVF4w7Ll63/T4+JMb71xIIJxv64HgGSk8hun6v0xmpRc3auS1zXlD3Jy/vV+oo eJfbbBFNIl2HPCqbwtZk/UFvkZFpMZXrKOGHjyEnBBVpMmEwMJ91ZUoOsE8jqobX6sWaCPIkAoqPGS XDUQV/CN1QgU8aGKMAjWOo8v7mVGENz0pAnxnSDH/Z493WBnya6iUA3ERMRF2lAct1DcrEmixPp+XC AfuCkBOlwieIOnkFfn1Qyybx3o4zVlQ== X-KPN-MID: 33|K86OQZ7RwL1vhn6psIUSJp8fwJLrkbpI0VqPVDlEW4sGmlDTDlh7NG6LfwSYTS8 gvihfIhSqoUtKSSfiPNma04lpDTrP1M7xPr23fqpWWhk= X-CMASSUN: 33|hg/ushXay+X2g+I7BHPmY4Na1O5jvEFukCTq6eRb7EHWHp4VyeZPljSyf2KseJ8 7IeM7Bxsqvm5kKrOGEQ1q1g== X-KPN-VerifiedSender: Yes Received: from cpxoxapps-mh02 (cpxoxapps-mh02.personalcloud.so.kpn.org [10.128.135.208]) by mtaoutbound.kpnmail.nl (Halon) with ESMTPSA id d5f3b3bc-7e1e-11f1-8edb-00505699eff2; Sun, 12 Jul 2026 20:23:53 +0200 (CEST) Date: Sun, 12 Jul 2026 20:23:52 +0200 (CEST) From: Jori Koolstra To: Christian Brauner Cc: Aleksa Sarai , Kuniyuki Iwashima , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <30383245.772147.1783880632879@kpc.webmail.kpnmail.nl> In-Reply-To: <20260707-sinnieren-versichern-heuballen-e86897d216c3@brauner> References: <20260705123826.3818443-1-jkoolstra@xs4all.nl> <20260705123826.3818443-4-jkoolstra@xs4all.nl> <20260707-sinnieren-versichern-heuballen-e86897d216c3@brauner> Subject: Re: [PATCH net-next v4 3/3] selftest: Add tests for useful handling of LSM denials on SCM_RIGHTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal > Op 07-07-2026 13:02 CEST schreef Christian Brauner : > > > + > > +TEST_F(scm_rights_denial_bpf, all_allowed) > > +{ > > + int slots[NR_FILES], nr_slots, flags, i; > > + > > + ASSERT_EQ(0, set_notrunc(self->sk[SK_RECEIVER])); > > + ASSERT_NE(-1, send_fds(self->sk[SK_SENDER], self->files, NR_FILES)); > > + nr_slots = recv_fd_slots(self->sk[SK_RECEIVER], slots, &flags); > > + > > + ASSERT_EQ(NR_FILES, nr_slots); > > + EXPECT_EQ(0, flags & MSG_CTRUNC); > > + > > + for (i = 0; i < NR_FILES; i++) { > > + ASSERT_LE(0, slots[i]); > > Why do you assert less-or-equal? You want a valid fd so you should > expect >= 0? > This says 0 <= slots[i], or equivalently slots[i] >= 0. > > + > > +TEST_F(scm_rights_denial_bpf, denied_without_notrunc) > > +{ > > + int slots[NR_FILES], nr_slots, flags; > > + > > + /* > > + * Baseline behaviour without SO_RIGHTS_NOTRUNC: the fd array is > > + * truncated at the first denied fd and MSG_CTRUNC is set. > > + */ > > + ASSERT_EQ(0, deny_inode(self->map_fd, self->inos[1])); > > + > > + ASSERT_NE(-1, send_fds(self->sk[SK_SENDER], self->files, NR_FILES)); > > + nr_slots = recv_fd_slots(self->sk[SK_RECEIVER], slots, &flags); > > + > > + ASSERT_EQ(1, nr_slots); > > + EXPECT_NE(0, flags & MSG_CTRUNC); > > + > > + ASSERT_LE(0, slots[0]); > > Why do you expect less-equal than zero? Don't you need ASSERT_GE() > because you want slots[0] to be a valid file desscriptor? > Idem. But I do think ASSERT_GE() read a bit better here, so I have changed it. > And even the other way around... Zero is a valid file descriptor so on > failure you must expect ASSERT_LT()? > > -- > Christian Brauner Thanks, Jori.