mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Woodhouse, David" <dwmw@amazon.co.uk>
To: "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Cc: "jmattson@google.com" <jmattson@google.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"wanpengli@tencent.com" <wanpengli@tencent.com>
Subject: Re: [PATCH] KVM: x86/xen: Use hva_t for holding hypercall page address
Date: Mon, 8 Feb 2021 20:20:44 +0000	[thread overview]
Message-ID: <303f907814d75e2f3bdec01564be745d312356d1.camel@amazon.co.uk> (raw)
In-Reply-To: <20210208201502.1239867-1-seanjc@google.com>

On Mon, 2021-02-08 at 12:15 -0800, Sean Christopherson wrote:
> Use hva_t, a.k.a. unsigned long, for the local variable that holds the
> hypercall page address.  On 32-bit KVM, gcc complains about using a u64
> due to the implicit cast from a 64-bit value to a 32-bit pointer.
> 
>   arch/x86/kvm/xen.c: In function ‘kvm_xen_write_hypercall_page’:
>   arch/x86/kvm/xen.c:300:22: error: cast to pointer from integer of
>                              different size [-Werror=int-to-pointer-cast]
>   300 |   page = memdup_user((u8 __user *)blob_addr, PAGE_SIZE);

Thanks.

Acked-by: David Woodhouse <dwmw@amazon.co.uk>

> Cc: Joao Martins <joao.m.martins@oracle.com>
> Cc: David Woodhouse <dwmw@amazon.co.uk>
> Fixes: 23200b7a30de ("KVM: x86/xen: intercept xen hypercalls if enabled")
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/kvm/xen.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
> index 2cee0376455c..deda1ba8c18a 100644
> --- a/arch/x86/kvm/xen.c
> +++ b/arch/x86/kvm/xen.c
> @@ -286,8 +286,12 @@ int kvm_xen_write_hypercall_page(struct kvm_vcpu *vcpu, u64 data)
>                                 return 1;
>                 }
>         } else {
> -               u64 blob_addr = lm ? kvm->arch.xen_hvm_config.blob_addr_64
> -                                  : kvm->arch.xen_hvm_config.blob_addr_32;
> +               /*
> +                * Note, truncation is a non-issue as 'lm' is guaranteed to be
> +                * false for a 32-bit kernel, i.e. when hva_t is only 4 bytes.
> +                */
> +               hva_t blob_addr = lm ? kvm->arch.xen_hvm_config.blob_addr_64
> +                                    : kvm->arch.xen_hvm_config.blob_addr_32;
>                 u8 blob_size = lm ? kvm->arch.xen_hvm_config.blob_size_64
>                                   : kvm->arch.xen_hvm_config.blob_size_32;
>                 u8 *page;
> --
> 2.30.0.478.g8a0d178c01-goog
> 




Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.



  reply	other threads:[~2021-02-08 21:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 20:15 Sean Christopherson
2021-02-08 20:20 ` Woodhouse, David [this message]
2021-02-08 20:40 ` Joao Martins
2021-02-09  9:22 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=303f907814d75e2f3bdec01564be745d312356d1.camel@amazon.co.uk \
    --to=dwmw@amazon.co.uk \
    --cc=jmattson@google.com \
    --cc=joao.m.martins@oracle.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®