From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752994AbdLEN7g (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 08:59:36 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:47244 "EHLO
        mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752693AbdLEN7e (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 08:59:34 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171205135932epoutp014c0678240b1c35ea67189354c3559781~9arQ5c4MG0343503435epoutp01m
X-AuditID: b6c32a45-e63ff700000010f7-f0-5a26a6431bc5
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tj@kernel.org, sergei.shtylyov@cogentembedded.com,
        linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v3] pata_pdc2027x: Remove unnecessary error check
Date: Tue, 05 Dec 2017 14:59:44 +0100
Message-id: <3041820.Z4NqBeWCEa@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <a6bc518e67419242f1409206972590c22f34ba5b.1511604820.git.arvind.yadav.cs@gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7bCmha7zMrUogw/dMhbXehcyWxzb8YjJ
        4vKuOWwWZ1bdYrf4tfwoowOrx4Op/5k8ds66y+6xaVUnm8fnTXIBLFFcNimpOZllqUX6dglc
        GXs2LmQvuMFU0XfQsoFxBlMXIyeHhICJxKH/IDYXh5DADkaJHc9OsUI43xklDt1/AFf1+tIm
        qKoNjBIdF1YxQjhfGSUWL/rCDlLFJmAlMbEdJMHJISKgI7Fp5m8wm1mgQOJW829WEFtYwFXi
        2eTVbCA2i4CqxPkVS8F6eQU0JX6+ngVWIyrgJbFlXzvYZk6BJImZP98xQtQISvyYfI8FYqa8
        xL79U1khbB2Js8fWgR0kIbCETeLRj5/sEGe7SKzauo0FwhaWeHV8C1RcWuLZqo2MEPZ0Ront
        vyUgmjczSqzaPQGqyFri8PGLUBv4JDoO/wWKcwDFeSU62oQgSjwklp2cxgZhO0q8apwBDTug
        OVPuNzBOYJSdheTwWUgOn4Xk8AWMzKsYxVILinPTU4uNCgz1ihNzi0vz0vWS83M3MYITgZbr
        DsYZ53wOMQpwMCrx8K6YpRYlxJpYVlyZe4hRgoNZSYSXuR8oxJuSWFmVWpQfX1Sak1p8iFGa
        g0VJnLd+27UIIYH0xJLU7NTUgtQimCwTB6dUA6MBR9qyOUX/DbK6Unb+UuZie3fZOULy8WlZ
        S7PCXFPzLzc/LIiPlTFo2bXJrvnC61jn+3XaKotdL4efDqxRPK40fVekg5n9u/cbBRgMN23/
        YMJgK2GwpmdOwI2IVYZ39dwf79V7fkvhuuKeN88/HvUMmOXRdWV2crv1vVXzavLVDuqX73p2
        yF2JpTgj0VCLuag4EQC2p3s3AAMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t9jQV3nZWpRBteusVlc613IbHFsxyMm
        i8u75rBZnFl1i93i1/KjjA6sHg+m/mfy2DnrLrvHplWdbB6fN8kFsERx2aSk5mSWpRbp2yVw
        ZezZuJC94AZTRd9BywbGGUxdjJwcEgImEq8vbQKyuTiEBNYxSqx+t5kZwvnKKPF+2yt2kCo2
        ASuJie2rGEFsEQEdiU0zf4PZzAIFEkcnTAWbJCzgKvFs8mo2EJtFQFXi/IqlYL28ApoSP1/P
        YgWxRQW8JLbsaweq5+DgFEiSuPKSFyQsJLCVUeLP/lCIckGJH5PvsUCMl5fYt38qK4StJbF+
        53GmCYz8s5CUzUJSNgtJ2QJG5lWMkqkFxbnpucVGBUZ5qeV6xYm5xaV56XrJ+bmbGIFBu+2w
        Vv8OxsdL4g8xCnAwKvHwBsxQixJiTSwrrsw9xCjBwawkwsvcDxTiTUmsrEotyo8vKs1JLT7E
        KM3BoiTOy59/LFJIID2xJDU7NbUgtQgmy8TBKdXAOF1yRtkso5MHPk5gnrB15vNZjNnKVkL7
        nu0y8lXy781jD2sNNyqzclD/c7Wx/2BjiVAM2/p1P3t7Cg6afnM/wLdRyd/f0U2u+u11xamP
        U7eeWcVzxu9EuKJT3tu/LT0CBU9u21qeWpkmmzhX+EOXsrJl6a+CrQbvnrb72kZ7zJPMNQwu
        S+dVYinOSDTUYi4qTgQAV9i/clYCAAA=
X-CMS-MailID: 20171205135931epcas2p26296be577a59a329c2cf94b331b52a04
X-Msg-Generator: CA
CMS-TYPE: 102P
X-CMS-RootMailID: 20171125102004epcas1p37d88a9f8b55c84e6573a0f11443a6d56
X-RootMTR: 20171125102004epcas1p37d88a9f8b55c84e6573a0f11443a6d56
References: <CGME20171125102004epcas1p37d88a9f8b55c84e6573a0f11443a6d56@epcas1p3.samsung.com>
        <a6bc518e67419242f1409206972590c22f34ba5b.1511604820.git.arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday, November 25, 2017 03:49:49 PM Arvind Yadav wrote:
> Here, The function pdc_hardware_init always return zero. So it is not
> necessary to check its return value.

Please fix pdc_adjust_pll() to return the error value instead.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics