From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9118C282DD for ; Fri, 10 Jan 2020 22:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 989D72082E for ; Fri, 10 Jan 2020 22:03:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="Fq+MP69W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727488AbgAJWDU (ORCPT ); Fri, 10 Jan 2020 17:03:20 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44332 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727319AbgAJWDP (ORCPT ); Fri, 10 Jan 2020 17:03:15 -0500 Received: by mail-pg1-f195.google.com with SMTP id x7so1600718pgl.11 for ; Fri, 10 Jan 2020 14:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0Abg147KGItynyBfHEl7b67Xp6iR3DdAKc0n7Z2WsdA=; b=Fq+MP69WGga+3DgUs/c3imZJTB2FGSls1TCtzh3aqFMF4g096k27iXsNFnGQxP4LY8 zUkrWlxicfOaC7OJI79DLRwDtMdTp+TSp/XUyyltmSu+ixbOgFZnr6FURS4nZaQCoQom gIiDHMM04gRcYN3d/q5z8mp5CVrwgZZXp/+k85e1KSx09ESoDbrl0UBPttJ3usB4PrPk eYhgvPwDLS0qHBq4/hayxxXlVFJu/RVfNlFsab5OvwHq6w05gq4/1vfuU1oNyJjeFd01 Ue4Wi+4gsTD6XEjKU3REt9mjEjm5eddJBcfqqlNx2P70cIva0oP2Ey7/su81gHU/BVY8 rSYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Abg147KGItynyBfHEl7b67Xp6iR3DdAKc0n7Z2WsdA=; b=jWLVZgxWxg5BYQfGeqF8eYbmZ7nv8VY+vegy63QuGl3mlzLeB6ltbI+ml3o8TGziKx 7YFcdFWAl8LDv6TyHfdL7+8trfqYuYbfauufF0+gZ5U62MJSVoCaEXdiGYVoNW/6LzFv ziQG6kyJ3kHkN+NK5c3lfoOFsVVpFnKE/Gw514N5nNRGxzKphI/oAaHA5a0XbPqS8x12 miHOM1SKsxbj/8IdMxnPY23rKpfIxYrk5YL1YXV9ZAa4jdPIFs2A1ierVLFBX3Sx8ztQ 7VIyFYjXX1SQ5lOgOUHu3bP82uETHv5feOfDbYGHs3HPLHr+YveybSU/uWSyx29M06Lj LMng== X-Gm-Message-State: APjAAAXutdtvp6i6vGyOy3zPUd+jyBNk0BFPmMIZ2aUb7Zh9EinKZTV9 J7fgnFfgnjJjAuWpyGfm3VeN5g== X-Google-Smtp-Source: APXvYqzLcGmK3wvhN4M2dOlmvl0d8H+nrBoejtJBxn2csJnNOxvNjLW+wP9F+IdwdH/QfNSa86sMjA== X-Received: by 2002:a63:cf55:: with SMTP id b21mr6880362pgj.69.1578693794465; Fri, 10 Jan 2020 14:03:14 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id m3sm4058655pfh.116.2020.01.10.14.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2020 14:03:13 -0800 (PST) Subject: Re: [PATCH-next 3/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Greg Kroah-Hartman , Jiri Slaby , Vasiliy Khoruzhick , linux-serial@vger.kernel.org References: <20200109215444.95995-1-dima@arista.com> <20200109215444.95995-4-dima@arista.com> <9e622d11-0eb7-274e-8f0a-132d296420fe@infradead.org> From: Dmitry Safonov Message-ID: <30427484-7e1d-7112-1714-7947f4145db1@arista.com> Date: Fri, 10 Jan 2020 22:02:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <9e622d11-0eb7-274e-8f0a-132d296420fe@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 1/9/20 11:53 PM, Randy Dunlap wrote: > Hi, > > On 1/9/20 1:54 PM, Dmitry Safonov wrote: >> >> Based-on-patch-by: Vasiliy Khoruzhick >> Signed-off-by: Dmitry Safonov >> --- >> drivers/tty/serial/serial_core.c | 52 ++++++++++++++++++++++++++++---- >> include/linux/serial_core.h | 2 +- >> lib/Kconfig.debug | 8 +++++ >> 3 files changed, 55 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c >> index 6ac9dfed3423..f70eba032d0b 100644 >> --- a/drivers/tty/serial/serial_core.c >> +++ b/drivers/tty/serial/serial_core.c >> @@ -3081,6 +3081,38 @@ void uart_insert_char(struct uart_port *port, unsigned int status, >> } >> EXPORT_SYMBOL_GPL(uart_insert_char); >> >> +const char sysrq_toggle_seq[] = CONFIG_MAGIC_SYSRQ_SERIAL_SEQUENCE; >> + >> +static void uart_sysrq_on(struct work_struct *w) >> +{ >> + sysrq_toggle_support(1); >> + pr_info("SysRq is enabled by magic sequience on serial\n"); > > typo: sequence Thanks on catching this, Dmitry