From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8349D1C1F00 for ; Mon, 13 Jan 2025 13:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776334; cv=none; b=uO9cQV2DyTziBZ7mzwHnfBW3ZbVdmh+hqGEYQgYv3oZuO8m57Q25Jbw7EYeWx2ZqWqrYECFnQGw3y0XnOle661l3wr1ycI+/GPNkerwVVao2Hkb0LVYXLU6QpKqWR5QQqQV5TOQe4taXkvgWuDO3rG9h6Nne2KSgS12hJ74i4qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776334; c=relaxed/simple; bh=6Q+The925tuHPhvAnv5LO64YiMOqCKwEdkamakY5Z4I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I7aqemXGgdMCPq05plBHPRDYJZM9WeF9DVQjUbucALKl0E98ksUW+ifTbLjNWXYZrxCSsH4CjfQLukJu8EdsVJlBDkMaeAIF6mNx4y2okAQY8uGepFRxkNjqbePckA5Nw3eYhkblW886rPq0Ev8QDKN9hPx6SqRFyQ4RsDiOrfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=fYWXyz1M; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="fYWXyz1M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736776330; bh=6Q+The925tuHPhvAnv5LO64YiMOqCKwEdkamakY5Z4I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fYWXyz1Mttr7No6f5/eapSOII1atDaZhCQwSLp8jahAFulKcDtTjNavtN6YZ+/Ca1 T1FHLqcEMkWR2w6C56JijVzC4M7VrK8bL2qee37RAQ1x9jlDQfmX1Z0OJGwYodMWpx Jb1wxHln6hZIfwywl/7pr7O2xOOnNrlY7RBvpHWSC2F1y8tUkrrjLtc/YXWpkEvq+O kFE96yNAJWRxVS3YRzlFfbph70J5bPfxl7V1TCkNoQY7QHPvaQNK9N/rcXWPwrNIS5 RMSTEk/jYV1NGfQxAGOpvS3zatvhTNqgmLHFmwoXpSAPAdt3U6eQY6FrLt8IY06UMe wdpAkgLQNqPTw== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0A7CE17E0DB7; Mon, 13 Jan 2025 14:52:09 +0100 (CET) Message-ID: <30474eee-cb88-4250-838a-3969073e0e8d@collabora.com> Date: Mon, 13 Jan 2025 14:52:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage To: Konrad Dybcio , Mauro Carvalho Chehab , Stephen Boyd , Joe Hattori , Matthias Brugger Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Johan Hovold , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Konrad Dybcio References: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 13/01/25 14:02, Konrad Dybcio ha scritto: > From: Konrad Dybcio > > On some platforms, like recent Qualcomm SoCs with multi-bus SPMI > arbiters, controller->node must be assigned to the individual buses' > subnodes, as the slave devices are children of these, like so: > > arbiter@c400000 > spmi@c42d000 > pmic@0 > > spmi@c432000 > pmic@0 > > The commit referenced in Fixes changed that assignment, such that > spmi_controller_alloc() always assumes the PMICs come directly under > the arbiter node (which is true when there's only a single bus per > controller). > > Make controller->node specifiable to both benefit from Joe's refcount > improvements and un-break the aforementioned platforms. > > Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup") > Signed-off-by: Konrad Dybcio for spmi.c/.h, spmi-devres and for MediaTek: Reviewed-by: AngeloGioacchino Del Regno Cheers!