From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jon Ringle <jon@ringle.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael.j.wysocki@intel.com
Subject: Re: Ethernet controller not starting
Date: Tue, 04 Mar 2014 00:43:14 +0100 [thread overview]
Message-ID: <3049227.1OEyu61877@vostro.rjw.lan> (raw)
In-Reply-To: <CAMwGMjwjyZkj3_bKUcx4GXNP764UaUG=d6V1us8GgMKj=HoXVw@mail.gmail.com>
On Monday, March 03, 2014 02:41:01 PM Jon Ringle wrote:
> I'm working on porting an ARM board from linux-3.10 to linux-3.12 (now
> the latest LTS kernel).
> I found that Ethernet controller on the board no longer comes up on linux-3.12.
> I was able to bisect the issue I'm having to the following commit:
>
> > 45f0a85c8258741d11bda25c0a5669c06267204a is the first bad commit
> > commit 45f0a85c8258741d11bda25c0a5669c06267204a
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date: Mon Jun 3 21:49:52 2013 +0200
> >
> > PM / Runtime: Rework the "runtime idle" helper routine
> >
> > The "runtime idle" helper routine, rpm_idle(), currently ignores
> > return values from .runtime_idle() callbacks executed by it.
> > However, it turns out that many subsystems use
> > pm_generic_runtime_idle() which checks the return value of the
> > driver's callback and executes pm_runtime_suspend() for the device
> > unless that value is not 0. If that logic is moved to rpm_idle()
> > instead, pm_generic_runtime_idle() can be dropped and its users
> > will not need any .runtime_idle() callbacks any more.
> >
> > Moreover, the PCI, SCSI, and SATA subsystems' .runtime_idle()
> > routines, pci_pm_runtime_idle(), scsi_runtime_idle(), and
> > ata_port_runtime_idle(), respectively, as well as a few drivers'
> > ones may be simplified if rpm_idle() calls rpm_suspend() after 0 has
> > been returned by the .runtime_idle() callback executed by it.
> >
> > To reduce overall code bloat, make the changes described above.
> >
> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Tested-by: Kevin Hilman <khilman@linaro.org>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Acked-by: Kevin Hilman <khilman@linaro.org>
> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Can anyone offer any suggestions on what I should be looking for to
> fix this on my board?
Any pointers to the driver in question?
Rafael
next prev parent reply other threads:[~2014-03-03 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 19:41 Jon Ringle
2014-03-03 23:43 ` Rafael J. Wysocki [this message]
2014-03-04 0:39 ` Jon Ringle
2014-03-04 9:06 Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3049227.1OEyu61877@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=jon@ringle.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®