mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulfh@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sdhci-msm: Enable ICE before enabling crypto support
Date: Mon, 16 Nov 2026 12:27:03 +0530	[thread overview]
Message-ID: <304e72a9-2def-40c0-9314-0b7413e45e17@oss.qualcomm.com> (raw)
In-Reply-To: <20261113035858.GD1742@sol>

On 13-11-2026 09:28, Eric Biggers wrote:
> On Thu, Nov 12, 2026 at 05:00:56PM +0530, Kuldeep Singh wrote:
>> On 24-10-2026 23:59, Eric Biggers wrote:
>>> On Thu, Oct 22, 2026 at 03:21:50PM +0530, Kuldeep Singh wrote:
>>>> Remove ICE enable call from CQE path, since ICE is now enabled
>>>> during SDHCI crypto initialization only.
>>
>> Sorry for delayed response as I was away on vacation for more than
>> 2weeks and hence couldn't catchup on the thread!!
>>
>>>
>>> This change makes the low-power and "optimization" settings in
>>> QCOM_ICE_REG_ADVANCED_CONTROL be set only once, during probe.  Is that
>>> correct?  Those settings never get lost at runtime?
>>
>> Yes, the low-power and optimization settings are set once and are
>> retained over suspend/resume cycle.
> 
> What about hibernation?  We recently went through this for keyslot
> reprogramming, and it was established that keyslots need to be
> reprogrammed after a hibernation image is restored.  See the commit
> https://git.kernel.org/linus/8b190e9c0b36aac5
> Doesn't the same apply to qcom_ice_enable()?  If so, this commit breaks
> ICE upon restoring a hibernation image.

Ok, I didn't verify hibernation with this change.
Let me verify and get back with results.

-- 
Regards
Kuldeep


  reply	other threads:[~2026-11-16  6:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  9:51 [PATCH 0/3] ICE: Enable runtime PM support Kuldeep Singh
2026-10-22  9:51 ` [PATCH 1/3] mmc: sdhci-msm: Enable ICE before enabling crypto support Kuldeep Singh
2026-10-24 18:29   ` Eric Biggers
2026-11-12 11:30     ` Kuldeep Singh
2026-11-13  3:58       ` Eric Biggers
2026-11-16  6:57         ` Kuldeep Singh [this message]
2026-10-22  9:51 ` [PATCH 2/3] ufs: ufs-qcom: " Kuldeep Singh
2026-10-22  9:51 ` [PATCH 3/3] soc: qcom: ice: Add runtime PM support Kuldeep Singh
2026-10-29 14:17 ` [PATCH 0/3] ICE: Enable " Ulf Hansson
2026-11-12 11:43   ` Kuldeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=304e72a9-2def-40c0-9314-0b7413e45e17@oss.qualcomm.com \
    --to=kuldeep.singh@oss.qualcomm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=abelvesa@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andersson@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mkp@kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®