From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kurt Borja <kuurtb@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>, Armin Wolf <W_Armin@gmx.de>,
platform-driver-x86@vger.kernel.org,
Dell.Client.Kernel@dell.com, LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Gal Hammer <galhammer@gmail.com>
Subject: Re: [PATCH v2] platform/x86: alienware-wmi-wmax: Fix null pointer derefence in sleep handlers
Date: Tue, 14 Oct 2025 12:50:38 +0300 (EEST) [thread overview]
Message-ID: <305092f3-7901-0a69-3459-b9f6b7d198db@linux.intel.com> (raw)
In-Reply-To: <DDHY8FVSX42E.1SG926NXKG2FL@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
On Tue, 14 Oct 2025, Kurt Borja wrote:
> On Mon Oct 13, 2025 at 10:10 AM -05, Ilpo Järvinen wrote:
> > On Mon, 13 Oct 2025 00:26:26 -0500, Kurt Borja wrote:
> >
> >> Initialize `awcc` with empty quirks to avoid a null pointer dereference
> >> in sleep handlers for devices without the AWCC interface.
> >>
> >> This also allows some code simplification in alienware_wmax_wmi_init().
> >>
> >>
> >
> >
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-fixes branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > local branch there, which might take a while.
> >
> > The list of commits applied:
> > [1/1] platform/x86: alienware-wmi-wmax: Fix null pointer derefence in sleep handlers
> > commit: 5ae9382ac3c56d044ed065d0ba6d8c42139a8f98
> >
> > --
> > i.
>
> Hi Ilpo,
>
> Gal has just noticed this approach prevents the old driver interface
> from loading, which is a huge regression.
>
> Do you prefer to drop this commit or should I submit a revert?
>
> Thank you for your patience!
Okay, thanks for the information. I'll drop it, it's very easy to drop as
it's the HEAD commit.
--
i.
prev parent reply other threads:[~2025-10-14 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 5:26 Kurt Borja
2025-10-13 15:10 ` Ilpo Järvinen
2025-10-13 19:27 ` [v2] " Markus Elfring
2025-10-14 8:18 ` Ilpo Järvinen
2025-10-14 9:48 ` [PATCH v2] " Kurt Borja
2025-10-14 9:50 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=305092f3-7901-0a69-3459-b9f6b7d198db@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=galhammer@gmail.com \
--cc=hansg@kernel.org \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®