From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D132144D9 for ; Tue, 4 Feb 2025 15:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738684131; cv=none; b=FOJxu9QZFam5+bfksfZjRTvfDnE3zyHI41759x+jAgvm/uhl0odHHl8wKVZ/dIro1jVupgBzQYAKV9CUghc9MT08/dpTGXLnMPqKLoqxnzGfNfDpwrCiV/8JOBCwKrckdf3H0L1Ux2gC7XEGxVBAQ7v/R6ppHD58KoCxmtOUMG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738684131; c=relaxed/simple; bh=FGGctlzC44xvBWHrrn+JVpW35WCb22AnKmNPRocYuC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KLeR2Fo0cBMwf5S2pdYw7admQKm/hDmvpPZkr7sAoH86Lk8Fr+WsFbWigUTf4KLdHupOyAgSp21QGkoJHfG15V/8HXLBzpvry7Nr863kWJpu3i3/MQNIBC9jOLktQX0kGFMCVTClSsGnq5SAAEGPuXdtFSuGUA2NXKH0cwRch9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mVa/WVw2; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mVa/WVw2" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-38db29f090dso1237f8f.2 for ; Tue, 04 Feb 2025 07:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738684127; x=1739288927; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gU8TkOLaJsHF42Jr0I2/13286opa6qB6pqpOwuEjyOo=; b=mVa/WVw2YSmkgDwTGn6QXzGATcYKGPaLBLw6niRnuDbLnPdvH7bPc+udFmmtdT8IID JK4bMEyNiQakLGtkUSAVo/0vDLcZkCayVVpQdq/MkG3b0EuIB6t+vI7PmSlP1CQWhQVk Lce3GUGZReqLB40bKAnYxIqNd65Wy/SPpv991bQPXlTNemrEDbBXXiGphXoOMwc6IJS8 kKGNUvIKIDr/TP0O8VeANTaErAK0NDUcE8J7oKDH1J02/AlT22lbHqHl6mdJKd1cl29n GfHk3aVufA1iC1Zdj6H5v1OctN7R0tRZ3VzOY/1tMGIavCxlc3grZ0WFmTpVK80lnxfW cDPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738684127; x=1739288927; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gU8TkOLaJsHF42Jr0I2/13286opa6qB6pqpOwuEjyOo=; b=Go5FcVl0oAPweUZBxMlIsYCiL2i8zNNw5ooRQGMd1PJY0Suy9RyDqbFUiIyV05OTX+ CrNA6FMr+zGqRzed8ScqiQIZaATS0wuJTaPHfTS6iHyJsbFWvHAe1UkPMDnBmjL3KmyY FAut8OgCmfZ33QV2SQS0luTp1LByMPgzTfIYDgYZ9JyLe5j9x3ZwzHdhf34Q7YYqcVgC RBHuGBFQs8UTyID7joKmXdNvNFW7VLevfkxBWbUyh0Zf4w6Zeo6ge75u8xWV4xChNwvj eH/1ppqLf8+tkMU45xb7Wg3JW9K1+IYHLAHuKktNjCTmejtp5IxcvXEBV3wYaHc5nCeE WEvA== X-Forwarded-Encrypted: i=1; AJvYcCUgR6M/Mvz7h6xl5pyq2oL2kIdQ+NXKwm0+AYehOx+gnv+ksSakKd1Q50gYZbyZyyKxuquklGIzaH9EXYk=@vger.kernel.org X-Gm-Message-State: AOJu0YylEOEhmCUsZjC8++rPuMoSbIVNK4Ge/OxP2ix2oAhsEpWGjsnk 5qW/4xJBNRcT3hyrRmiAMckqLQxkXBFkAC7gkBOy22TXA9UOnl3uWU8DDCYiMrA= X-Gm-Gg: ASbGnctVxCWbxoECS0oW/H/YWD/rtDYt0nurcH7gXqS2rs67OlEulC5rAL0Kfi9SKAn GL+nkqfd3oO2X9OF+mz7JOzECn6y0XcxP7tPE/RkKK5NxyygNYei6k6O38JrVBjN4w7NpfziXa/ Rr9IDQWOt2r8EVGRF2+cp8lebIiLyTI3Ag3+FQXRI/TUgOOGwfpXAh6Vstv5zck2+pw+xUNollc GO8FgpfgSrrY+ayyvygff8PyOx2IuG9lMmV+lRewcHkkAU2qQESq7E2oquWCEDCLwtunaTicy4A Tay+LjCddyrOdqaa0qFdnPyOxdBtL35yn7w= X-Google-Smtp-Source: AGHT+IGveqdu2JixWRUhsUl00uKh2Op+HVMUCQsDgohpXpwMPeoN8qwI4EsRYKpKAjwTtITIgvSlug== X-Received: by 2002:a5d:584a:0:b0:38c:1496:2d44 with SMTP id ffacd0b85a97d-38c5a4d87b9mr6729049f8f.6.1738684125187; Tue, 04 Feb 2025 07:48:45 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23e6a4dsm192729835e9.21.2025.02.04.07.48.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 07:48:44 -0800 (PST) Message-ID: <30518b66-71c5-43ed-a770-e3ecbfdb1f58@linaro.org> Date: Tue, 4 Feb 2025 16:48:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] drm/msm/dsi/phy: Define PHY_CMN_CLK_CFG[01] bitfields and simplify saving To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250203-drm-msm-phy-pll-cfg-reg-v2-0-862b136c5d22@linaro.org> <20250203-drm-msm-phy-pll-cfg-reg-v2-4-862b136c5d22@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/02/2025 15:28, Dmitry Baryshkov wrote: >>>> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 31 ++++++++++++---------- >>>> .../gpu/drm/msm/registers/display/dsi_phy_7nm.xml | 12 +++++++-- >>>> 2 files changed, 27 insertions(+), 16 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c >>>> index 926fd8e3330b2cdfc69d1e0e5d3930abae77b7d8..b61e75a01e1b69f33548ff0adefc5c92980a15d7 100644 >>>> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c >>>> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c >>>> @@ -67,8 +67,7 @@ struct dsi_pll_config { >>>> >>>> struct pll_7nm_cached_state { >>>> unsigned long vco_rate; >>>> - u8 bit_clk_div; >>>> - u8 pix_clk_div; >>>> + u8 clk_div; >>>> u8 pll_out_div; >>>> u8 pll_mux; >>>> }; >>>> @@ -401,12 +400,12 @@ static void dsi_pll_cmn_clk_cfg1_update(struct dsi_pll_7nm *pll, u32 mask, >>>> >>>> static void dsi_pll_disable_global_clk(struct dsi_pll_7nm *pll) >>>> { >>>> - dsi_pll_cmn_clk_cfg1_update(pll, BIT(5), 0); >>>> + dsi_pll_cmn_clk_cfg1_update(pll, DSI_7nm_PHY_CMN_CLK_CFG1_CLK_EN, 0); >>>> } >>>> >>>> static void dsi_pll_enable_global_clk(struct dsi_pll_7nm *pll) >>>> { >>>> - u32 cfg_1 = BIT(5) | BIT(4); >>>> + u32 cfg_1 = DSI_7nm_PHY_CMN_CLK_CFG1_CLK_EN | DSI_7nm_PHY_CMN_CLK_CFG1_CLK_EN_SEL; >>>> >>>> writel(0x04, pll->phy->base + REG_DSI_7nm_PHY_CMN_CTRL_3); >>>> dsi_pll_cmn_clk_cfg1_update(pll, cfg_1, cfg_1); >>>> @@ -572,15 +571,17 @@ static void dsi_7nm_pll_save_state(struct msm_dsi_phy *phy) >>>> cached->pll_out_div &= 0x3; >>>> >>>> cmn_clk_cfg0 = readl(phy_base + REG_DSI_7nm_PHY_CMN_CLK_CFG0); >>>> - cached->bit_clk_div = cmn_clk_cfg0 & 0xf; >>>> - cached->pix_clk_div = (cmn_clk_cfg0 & 0xf0) >> 4; >>>> + cached->clk_div = cmn_clk_cfg0 & (DSI_7nm_PHY_CMN_CLK_CFG0_DIV_CTRL_3_0__MASK | >>>> + DSI_7nm_PHY_CMN_CLK_CFG0_DIV_CTRL_7_4__MASK); >>> >>> Could you rather store these two fields separately by using FIELD_GET? >> >> So make the code again more complicated? OK. > > It was already there, bit_clk_div and pix_clk_div. Yes and I (believe) simplified it. It is subjective, so I don't mind going back to two fields, as you asked. Best regards, Krzysztof