From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759389AbdEONL2 (ORCPT ); Mon, 15 May 2017 09:11:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53156 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758488AbdEONL0 (ORCPT ); Mon, 15 May 2017 09:11:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1BF5A80F8F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1BF5A80F8F Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170511194134.31183-4-Jason@zx2c4.com> References: <20170511194134.31183-4-Jason@zx2c4.com> <20170511194134.31183-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <30528.1494853879.1@warthog.procyon.org.uk> Date: Mon, 15 May 2017 14:11:19 +0100 Message-ID: <30529.1494853879@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 15 May 2017 13:11:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason A. Donenfeld wrote: > + if (unlikely(skb_to_sgvec(skb, sg, offset, 8) < 0)) > + goto nomem; > ... > + if (unlikely(skb_to_sgvec(skb, sg, offset, len) < 0)) { > + if (sg != _sg) > + kfree(sg); > + goto nomem; skb_to_sgvec() can return -EMSGSIZE in some circumstances. You shouldn't return -ENOMEM here in such a case. David