From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 252DA3D3CFF for ; Wed, 5 Aug 2026 05:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785906014; cv=fail; b=JNWU0zkzgMYBQV8WFOevDMhX6oECpAfrZ7bvA4kVxzF1sg0hEwxEsET9Z7ngR2+3J5ocw59goMOpClJh2uE5f1NABSzVL42a9O7lMRKzwC23iFmKyKieg0Uh2f7mHJABAlPRR2Qlxf7sKhhWvqdvK21xwdIwqXcMkfAWVSVQOBQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785906014; c=relaxed/simple; bh=Lc01jHgGwIzNWlc5Frwr9bb/0IsbjefeQ4DdN++8hMg=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=V3F6bGykE3yFJbnEL6dgVTn/Vp1wNRG+cHZad0NaNaOMT/qfUTSIetyv7BqlAn6rasjEJPZAt2VmT91czcXka5oJOaBTVVQMAfgcsq9rWoCQ5TtEWCXERso2tL6sWzxwnya0OFTp89wVewsIXHQuqHqfNCt7t7sq00/p5+Zq9Kw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k+Z39x8b; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k+Z39x8b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785906012; x=1817442012; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Lc01jHgGwIzNWlc5Frwr9bb/0IsbjefeQ4DdN++8hMg=; b=k+Z39x8bTlbG4Ez0McM0+lnulntTQwuSYHhEtnaKIJVxFOX9LH/al3PE wszuH86HdowIawpX81B3lQbuhNNtmLxW7WltrdW+e0qF8RS0hD7sQBWAl M7vwNmsSD7BEtDhFUAJ6LJW1AlQx8JdF8CGcMm+dVKpWPlgov52wMhdwQ 87/0lWi3VnArA4Qzuz55Zs6IvmZQonyMITWHgPeS1MtfU4T/+h2TeiHpl 5JeINT37a6fouyOUHUveyh8l31Y85sBV+FRAqwtU6cb/P1TKwz99MtCMo Ajw0PSLNLf3vr+Tr2ELtXj33cMKiGMTAaqIqHbgfNzURxPMfVSFZUdF4H g==; X-CSE-ConnectionGUID: XKzF64TwRnqj+U1JJFBSXQ== X-CSE-MsgGUID: gE1f3dc2Q5qFHD54D0xUzw== X-IronPort-AV: E=McAfee;i="6800,10657,11865"; a="97063657" X-IronPort-AV: E=Sophos;i="6.25,205,1779174000"; d="scan'208";a="97063657" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 22:00:11 -0700 X-CSE-ConnectionGUID: tsWg5KbrR76F0yg4Ehs8RQ== X-CSE-MsgGUID: TM1RBrjjSveO+1CTNHagIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,205,1779174000"; d="scan'208";a="286346745" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 22:00:11 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 4 Aug 2026 22:00:10 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 4 Aug 2026 22:00:10 -0700 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.59) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 4 Aug 2026 22:00:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pL8Zq4R9EaPkuMXwUO2tTlzpU79N3+5BSDiIxhoMKMoGg4PFpoQrigK+azmtgxAfnkN2gQzGiT+zeY3bv6CZVCdEbeZp28E4840sQWG+vjMohRczPXFlh+Lh0Uzrsj572dp9evgKgwFDVCs8OX7GhgiFFscj8zgHlcOztSAut29euxzotr1RwEvL39riffi7kBn9/xmw/Jx6umu/bD7SvTJJQVt6cPREXaxKJgYfLKebDmtJujcnKzbyT3/3mXAHpCb+9eVzwl6/Iyq0pfoRYlJbJeKxe106Ux5BISewdskvPOYiksftCbBHAqJIWbryRil07PbE9hQgiZeiiJdpTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wqVbJr2GduT+tIex4tsnkngZnDIqf32qTO5fIQfZXG4=; b=ORR5dygukERXav2FaiLF1wvwKCf5HlpQ8u6tAitVaIQfXAenWrtv9yvvB1/YCoFdQeNVuGfvYUdBvEpc/eapJiY31Oc8R+leEGjz/5D1uBjW9Ue+pTx3tS0uOolj82/vc89Zd8QfBAYnUajEzsG7jw8V6rZdjYNr44wA8TtH3OA+L0AGWZ32cD4eR2PwKCI6yxNk7MXZjCm1+e8dxsKudl8933h8eTYYT/ZtfZChn5UbmlOXs6HJi/3ahX3VezZMJ0aEqwMDQVv9W6/5pynHAIWrr0dsA3h/9jcAhwMt3+dAwj3VmIHANie1KJ3Iz3+bsLmF/5HHEZoqKsSuYWnO1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by MN6PR11MB8193.namprd11.prod.outlook.com (2603:10b6:208:47a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Wed, 5 Aug 2026 05:00:03 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0292.015; Wed, 5 Aug 2026 05:00:03 +0000 Message-ID: <3053f498-1eb8-4c64-8d52-847829f48a1b@intel.com> Date: Wed, 5 Aug 2026 12:59:52 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/31] x86/resctrl: Parse ACPI CMRC table To: "Luck, Tony" CC: Reinette Chatre , Ben Horgan , James Morse , Dave Martin , Babu Moger , Fenghua Yu , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Newman , , , References: <0189d930c672498480557c5c16efe42940a06b5e.1785680802.git.yu.c.chen@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI1PR02CA0041.apcprd02.prod.outlook.com (2603:1096:4:1f6::18) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|MN6PR11MB8193:EE_ X-MS-Office365-Filtering-Correlation-Id: c6bb6499-2a7b-4927-7089-08def2ae6889 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|7416014|366016|56012099006|4143699003|11063799006|6133799003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: g+99TW6PGLDyM1xDKfFTUp/8z44kjXd1aPe4JLUnRuWzqqdFqeFhEM75OBIRKs5nvHLVj0e8Kq0NaE258ZQzE/bNNWjgTMX90A5SikGbZ5rmGzhdZ+q9GtaVGufy6UCqVR96q75gHrNSfb3an+WC/LLbuKLayd4GNmS/YH9/0V+ndO8glNlkyZKIZe1DmHLvPgJyUMGIJlaUOcWv/Za/+O3IhlDZNO9hGqr44uisd53X3Vjz8cp+inK0r33CIm1JfdzzhLDqwuuDRYP02PRQCtBmxRsDfGS8P3Q5OaWfvT49GVS1n8HV+9HDThh29gGYIhIPUOS892c4qstNMwp1CCP574vZdeHX1d52fVlNZx66vrW1I3jq5n2ui4NJctLRBbuZi2/ZwdT3j8Af6EendhoR4teNWiFOdDVuWv787T1RhJL9qpvzEWSw3CdYrigwL7YepsawW/ViHR5i6QB6UoSq4y07VHZrerNv+Fq2h07VpUvftcUEzW3J5dQa7rlImfjeyjRWnb3du532iJiPbIxSwh3eJVz5mpOdQPt/n2pHBVGKv06TdNsxhtVJBRlEJ1W52M9jPp767RiSYn6csa6YaZWG7znDJN4UZXU8gUgYA0ZlS9A13ilwolvK+c11inPVX821zZix1dTPoYw5e9fkuNwS1ekq1JDlYlYL5c0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(7416014)(366016)(56012099006)(4143699003)(11063799006)(6133799003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9hY0lGZWhSZnd2MC9lcjNod0JsM3JTTEhrNmNIUVowY2cvMG1FUmNlRW16?= =?utf-8?B?Z2RhSGMzVlJ3eUxWZHpSM2h1NlZiYnpnWjZLcGJKdUN2eFlWNnpMQjRXYTRm?= =?utf-8?B?dzU5NTJxWFIxbWRScDBkT09uejFNYVNDc3JCelZScXJpQWpTTE5EMGNwRUJZ?= =?utf-8?B?Sjg5bEdUdy9TVGsycnNvNnRIaDMyQXFUcWVxRTJUNytMUUtUM2FHR0VFRDlN?= =?utf-8?B?V1g0aDBXMnNQbmVITS8wSEplU3J5M2ltSkZxWGVzTlREb3FYblZ0SUpVV1ZG?= =?utf-8?B?cWc3bmJIWkJ2bjlBemcrT2xNU0tiTFVBMm5GNHp1Y1ZPaDZ5Ump3bVdPazVN?= =?utf-8?B?UDBpZC9scWJObVRWRUsvaVdtd0ZnVEhkb0ZGS3lrM1FEY2ozWW1EWllaTWpQ?= =?utf-8?B?Vm5YMUlRYlhkdEZ0U1VaSlI2YS9WcWlzalpOSDNCWW5VVm51RU1GN09RRldl?= =?utf-8?B?ekxzdkx5OTRkNitzL0xWVnBkQ2VlSmlwVGZHQ3I0ZmpIeXN4TVgyL0Vzd2dq?= =?utf-8?B?VnI0MlV5ak85RkNPeFlGc1BuUExxVEpOK2FqNE9XZmFmYjVhemhqcEhqZVR1?= =?utf-8?B?b2Y3VkFkQms5RG5UUTZxVURRcTd4SzlwelpOclAwVFVmdFJhSCsxblZydkZG?= =?utf-8?B?TWdqZU5QM2Uya1hEaFdrWTZYLzlNN3F2cE1XdE43QzVmK1FxU29tV2xJenY4?= =?utf-8?B?QktIVkJRY055WmwyeFNaT0k2RWRpcWtMQ2gySmlUS3E1UldmeDhaRzdrK1Jr?= =?utf-8?B?SFk5OWlXUmpYeVNGU2czVkRhS1RBU0UwYmNQdmN2ZTY3R1lIdWczOG1DVmc3?= =?utf-8?B?SElTYUlxT3VDQTAySEZKNkc1emxEaHN6ZUtFOXdSS3FRUjVCajdjd0E4RGRs?= =?utf-8?B?elJjeWxMTVNYRVMrL2pKbXkzcUhqZHo0TGJpUC9rV01VUHZlb3c2eHM1ckFE?= =?utf-8?B?U0NtSFZQZjJDMmUvaVorWHNXbkIvdjY1ZXdCMjIrbTh2T2hBZ0xQd01YRGxN?= =?utf-8?B?NHpIZm8vWUVNVUZKMG9GSmlsRU9JeUdkNlVHWndNejV3R2hxeGJuRk96SmNN?= =?utf-8?B?eWIyak4xSFJFQ3hKYmN0dlRjQU4wNjI3YUNNL2tSeHN4d2lLVVpmWTZmYlpK?= =?utf-8?B?K3pseGR1VUV0anJOczFRZmZnaXFqM1V1eHVFM0xPQUtIVEtvNTN1MzhtZFZz?= =?utf-8?B?MVBnc3phb014VmFJMTNCdDZOdEdyN0x2YVpLQzEyL0I4QkJiNVRZL2xxNXI4?= =?utf-8?B?V3YrMDJnMEUxNjBYNWZXRnMwRHZzT0dBZExLT3A2bFE4aSt0U21ZZlhmdUZC?= =?utf-8?B?Sy9aSGx0YjQrQ3FMcnhWREJVdkJEQzgwWVoraUg5b0RLclI5Z24wWllXc2kw?= =?utf-8?B?L2lpWVUwTGFpUTliQStrSzBJTjBNMXRQZjJOWURvRTEwWGVDa21wb0JsZTZo?= =?utf-8?B?NE92bkFjR0hud1Nxa0htd3kreW9wZ1pkR1daQm5SSzM1RUdQZmoyY1A0bHRR?= =?utf-8?B?Vk4vRGF3OFVacTlpL05VQVh0YjhTOGV1bFFnbDh2QVFVbWxQcjhYVFdQc0RH?= =?utf-8?B?YmdzeFFUeFNRcVNiM1NlR1BVOWIxcFJjSXA2aWVlSjJqRCtKdiszSm9HVXZU?= =?utf-8?B?L0R0ZGpZZkpUUVdDSmlLRmJIMlZ0UGRsK3IyVHZocC9MeUlkR01EVlAxUElk?= =?utf-8?B?U3VkMTNKSTBONlR3c1lxQXNCWHcrbjBhWWhDYUZiSEkzellPZmgzcjZ5R1JJ?= =?utf-8?B?aDROayttYUNUaGVJZFZ5M3ZLd3NRVGFiOEl0U0pIaGFUa2syUmEvLzd6QWYx?= =?utf-8?B?ZUp6eXFmWmRUbFBIeXBWUWVPYXA0c3g3YkJHR1doMEdXUHg5RndYWVFKcUd5?= =?utf-8?B?ekpNNGk2cHE3NFdjbnRkUnRWZ05xR1lxRDl0RXdoQ2ZHMmNHVzhJNGhGS3Vh?= =?utf-8?B?Z1BYWkRJcW9rZ1dacW1JYmY2VkZpaEpaV1JPdE9YQ3NGeUw5V0ZURXZvZWdv?= =?utf-8?B?bmhCajRlVzJNSWJkd1VHWFJSemUvZWdUb0Mwcy8veGJ3YlRQbldwdDlCazZk?= =?utf-8?B?Wmt2MSsrY01WWkM5YVNEK3AxaGtrdW9vSmVRd3dMZmxyR1lxc0tQVkNvTlBj?= =?utf-8?B?VU8xMWhMckQ4L0pYWVdjakNFTlQ0d2ZwVEhYak4zc0x3Z3RHa0U2Z1hiVEdR?= =?utf-8?B?S1gxL1c4VmNRKzVXeC9qaitOT1hPRit6QUZxdjk2ZHZPKytld2F3Q0xTUVpp?= =?utf-8?B?V09FclFsUjNnMFVFL3dZdnUyeFhVT0dPYWc3akZ0U29JOFpIVzlRMVlyME5W?= =?utf-8?B?Qm9RMTQ4YjBieGpybW1pQzBPTGtlajRFQ2VCL0RSVlZ0ck05ZWMyQT09?= X-Exchange-RoutingPolicyChecked: paVvxC3AQKqZP3ecG983P2KrKn1O0NtK+Pk6OK5Zr267TXERiwPyRY3rnBpXEHCnr445a5O+qxVX66EXIfuwB0cMUrAOQwv3Q4Rw4hF5Yicn74I+pagsjF5UDuZhsp8i5SZ1BJKhzM2mZtkYKcbdNNE4t6/pWWxak1a1Lvk/+vhw/+8A3VsaFMoXI+CQlbOeiPh0FqXGuMep0o7tYvILEv50btP+trdi4u2iXolC224kI8ij75FrHM7a+Mv9QRQ6RhPaEg7K4rwQAexqhydzmXuVpML1tOT7u2Tf0UbkFsuWix6si5QN2/rmwp2NTWH2ENQEsuTz+qupz2PXLLhlEA== X-MS-Exchange-CrossTenant-Network-Message-Id: c6bb6499-2a7b-4927-7089-08def2ae6889 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 05:00:02.9021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qQLI5o95hAjgRl9zoMrQESEYCChVYVYwqd/Ry8iRg2uo5FskOjQs/+MCW/SEOscOVQJy/sCKbu7LxmhrdZe9nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8193 X-OriginatorOrg: intel.com Hi Tony, On 8/5/2026 2:13 AM, Luck, Tony wrote: > On Tue, Aug 04, 2026 at 10:19:26AM -0700, Luck, Tony wrote: >> On Mon, Aug 03, 2026 at 12:03:48AM +0800, Chen Yu wrote: > >>> >>> +/* Scale to bytes for the monitoring counters when ERDT is enabled. */ >>> +static int erdt_scale; >> >> Single value for scale? See below. > > Now I've read ahead to patch 9 and see how this is used to set > resctrl_rmid_realloc_threshold. Needs better comments here and > for above erdt_get_scale() OK, will add comment here. resctrl_rmid_realloc_threshold is a single global value, and resctrl_arch_round_mon_val() takes no domain argument, so a single scale has to be derived from the per-domain cmrc->up_scale. max() was chosen because the rounding is a floor: a larger scale yields a slightly lower threshold, i.e. an RMID has to drop to a slightly lower occupancy before it is reused. >> >>> + >>> int erdt_get_max_rmid(void) >>> { >>> return erdt_max_rmid; >>> } >>> >>> +int erdt_get_scale(void) >>> +{ >>> + return erdt_scale; >>> +} >>> + >>> + erdt_scale = max_t(int, erdt_scale, cmrc->up_scale); >> >> I'd expect that on a machine all CMRC tables would report the same >> up_scale factor. But RDT architecture allows them to be different. Two >> ways to handle this: >> >> 1) Check that they are all the same. Complain if they are different and >> don't enable cache occupancy events. >> >> 2) Save the value for each domain and use that value to upscale when >> reporting to user. > > I see in patch 9 that you do use this option "2" with "cmrc->up_scale". > >> Picking the max value doesn't feel like a good answer. > > Given how this is actually used, seems like the best option. OK, the erdt_mon_read() reads via the per domain cmrc->up_scale. thanks, Chenyu >> >>> + >>> + return 0; >>> +} >> > -Tony