From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B14C4315F for ; Fri, 26 Jun 2026 03:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782445807; cv=none; b=Dm7q4ByrkvpqIBWguA6AbUmoOOMziXbMKLw4y0QVyljWubAXPcB1T+jH4dXwVoLKbhJOXLuHBQNzdPQN21qIhWXG+0MFgGcpu5NdiBG5Gk8y/Rkcmaz/4Wxb6Mpu07nBIQ9J/6NEpAnkU39DVZec3MsYG843YmHBhEDSJVxX9MA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782445807; c=relaxed/simple; bh=1VzFqNg6GJ8+ZV9aDmd+OgNldjkFCxjAz1iu71agHFI=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=FdVn0ZINLQrSOAZTjgfyHwwifiiM41r5vv0o8+i4+P1Tev6EB2yxSqcAkICho9tVjAO9Spr/3hxJjoD5Q/dlw9yazaFQLBQChW80s4GEgFjpFQhDJxUTwd2kcFMaq93YFjS4ElsUjYwCO7gCwwzsmxqBF0pAMubgiy8l6Bu9Mqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hOg3vx6x; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hOg3vx6x" Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782445803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AEwCP01McVKkFzs5YSXKWYRkZR0LtHlb/C4tjHs60HU=; b=hOg3vx6xYD5XyIJ+WJ/sCCoGoBDrcAq6WxNmMTei3tyeQ50pt7z9DLMlID0PiwESQ65zVR l5fKf5tnZtNDXMx2tjHNvVRuCABmKJ5Ft9OXBttwdBtZaF3eA7SD9EVObVaEvzROubayWH iIRBjQ5GbnNa3evdT/lRRVj0wys+kXA= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH 1/1] mm/shrinker: add NULL checks after rcu_dereference() in shrinker bit functions X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <6l2gs76zo6zf-6l2n5wa2xbvg@nsmail8.2--kylin--1> Date: Fri, 26 Jun 2026 11:49:13 +0800 Cc: fffsqian , Andrew Morton , Dave Chinner , Roman Gushchin , Qi Zheng , linux-kernel , linux-mm Content-Transfer-Encoding: quoted-printable Message-Id: <305C42A2-1359-4998-A95C-49998B4660DB@linux.dev> References: <923f391a-d760-4d78-92d4-2e765aa226f3@linux.dev> <6l2gs76zo6zf-6l2n5wa2xbvg@nsmail8.2--kylin--1> To: =?utf-8?B?5YKF5riF54i9?= X-Migadu-Flow: FLOW_OUT > On Jun 25, 2026, at 11:01, =E5=82=85=E6=B8=85=E7=88=BD = wrote: >=20 > Hi Qi,=20 > =20 > Thank you very much for your detailed analysis and patient = explanation.=20 > I fully understand your point that the existing caller constraints = guarantee shrinker_info cannot be NULL here, and this NULL check is = unnecessary defensive code. Thanks for your contribution! I have a couple of quick suggestions to help things go smoother: - Please take a closer look at our community communication guidelines, as we rely on plain-text-based replies here. - For any issues you're not completely sure about, it would be awesome if you could run a quick validation yourself before sending out a = patch. Maintainers' time is quite limited, so this helps everyone save a lot of energy and speeds up the review process. Thanks for understanding, and looking forward to your next patch! Thanks, Muchun