From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 096B2136353 for ; Mon, 13 Jan 2025 19:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736795177; cv=none; b=s5QOLp9zf0R2ckqmzyrawkLfUc4IMwlrL/l6tkG2TK41JACF/XU9FFvkWoaRr8CJ0d/fgvXi+Uf04Ezgj4r5o0qm0gtfI++iHKc2Y2RUqHQY7Hb9YprSF1fzq8K7g5XPWbYMHW/dKrf4zTp7OriSB1qq3rbIc3ZLbeyQ6tR+/Dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736795177; c=relaxed/simple; bh=VuTi0i8w/336nHSerV1QPi7WHrJZu8tjcb3Edf18Uc0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FuWroxoyNTuLIrupbUE2z36+zb3NVx436BxsNNSVc3LxMskLmNhxwDwoSBaNYg5NB0y7TDrrEZMp/xlWZ9sCySOlV5C65gGKK1myipzK5sfQ+zQTra74yscpgl+PnJSibEreqNynaZzxn1t/QkQHD7W43lEDErTPRzcULlaKRe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bCOZDHhR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bCOZDHhR" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DDWVlo007206 for ; Mon, 13 Jan 2025 19:06:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NLTcoE+VMXCCGxqPcej9L/vrCBnQDEflE4ZGobqOCPk=; b=bCOZDHhRZQGEaByk qes3l+6TUZWtrYvmBxrYPDVT+Bh6SBl05WvwaCXxu3Yt2vwOAyyT/IOKLQpddryk Sb8ubU97evsx+/48fVvXeEOaagkBv4xgIVEpLMs70pe2IuyP9QRrtGXxWpWgmfsT t4zh6R9ZF3Uovhj7HhOhWqAl6EhSIMF5m53a4R28hqRNybRvur+aDEfd5paM15kh j96IEN4t53iN5UiWimn6AliiWXwGEIoGq4YYtvAc4PbjMuJC3DY51qco+BmjG7lX PPq8w9u20Ng20bqYBwPYWJ6ZdM9YJjo695nZKCwDyQe+iKYM5njUbODSWg8PfCKs 1ibcQQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4453tarthq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Jan 2025 19:06:15 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2166f9f52fbso141869335ad.2 for ; Mon, 13 Jan 2025 11:06:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736795174; x=1737399974; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NLTcoE+VMXCCGxqPcej9L/vrCBnQDEflE4ZGobqOCPk=; b=RmOyiXqozQP1TO0f0gZTKVcfaEclRF/Cr7H8N8Um+p499KPV5as6+k5zoau3EiBMxW XcodOltIoAu3JuAqkh5DSSdWs489BoynisDrQoavW4nCyN3naCz2auYwhMFRUrhUufpi NiZHWmtvwmvvbSq7gyUCMXhrnF4NjPR7jZ3UtIXQkKEbgtvgx+ELihcOE/V1UjJZEtgI aqsLeA7fIZW79BbVuxhneMoUYsEpWySaTfQyTcK6rqUpwuW1y/QiIseW4XI65snFr5cC 1Rk0paoFfbx+hM7h4hgOyQ8jaxREigc3njzLZR0TbneJHkrV5ASJeohdraG9yQoeDHvd nDzg== X-Forwarded-Encrypted: i=1; AJvYcCW9gH4E4EbD9/nUOcxq108A6CsYcUXks+Ou7nKwAV3OjzUfOeSo/szjkY5RrFA7jvxwopWxafqfMgVUJ50=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9lbt3LrmB2ZiTFJhYoWo/aCwDFSvsPw78ClAdTKsVF7vefj1e 6GP/t0Tc8UAHbrIZcocN4ZY6UIvSupRUR3xR6HU2sxAC/xC6MpyfY3K0cJrFQX5uIt+228SfprL j746bForcEeK3Vi/YjxGq997s88Fee67DL0HhSDELjWKQm1LVrqjOWWIupe50ax0= X-Gm-Gg: ASbGncv0I2WutyDFQCPFUogCHfkMKyCR3yH3xk4T4cWVHTouhvk9Q//S2mT+LlVevwl HNR7V2xineqJmJa15K1p5AT9FVtnb9eZH6+WwIY4zdj2QpxSfqW7e3mBkKaLAWY0n1FibEj1ZJy B9Osr1bjwi8ndLSxfhSAHAu9QV8y/Hh/PLmJM6FB3nVr9sNuNxxJ2tuYtcRuGwAy1smhtwMKGja iNoPQQcFGYxNX9YLKKYEEbe2P2tvcLVXJX/TfFt76+NU/VCW4fH7s0PcmGHOqTGTuMK8iCPK09x gIcY7O94FSFnEZ5kx28X6Y59Bll9YGJ1Ewf68dKYt9qtrls9hQ== X-Received: by 2002:a17:902:da8d:b0:215:6816:6345 with SMTP id d9443c01a7336-21a83f52430mr342206715ad.16.1736795174389; Mon, 13 Jan 2025 11:06:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeMax9I6qKpzBQRg5CFiWdhyJkcJ6xzUNwIWCsJGltsh1GaKBMXyzu3MAx1PZ9GVZ97CZBqg== X-Received: by 2002:a17:902:da8d:b0:215:6816:6345 with SMTP id d9443c01a7336-21a83f52430mr342206095ad.16.1736795173831; Mon, 13 Jan 2025 11:06:13 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f234977sm56568955ad.204.2025.01.13.11.06.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 11:06:13 -0800 (PST) Message-ID: <305d7cde-adb6-430c-bf6a-e0034771ad9a@oss.qualcomm.com> Date: Mon, 13 Jan 2025 11:06:12 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] wifi: ath12k: prevent race condition in ath12k_core_hw_group_destroy() To: Aditya Kumar Singh , Kalle Valo , Jeff Johnson , Karthikeyan Periyasamy , Harshitha Prem Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com> <20250109-fix_reboot_issues_with_hw_grouping-v1-1-fb39ec03451e@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-1-fb39ec03451e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JuoPkOuuPruRaeDF8pzRHTV8HIH9PeIS X-Proofpoint-GUID: JuoPkOuuPruRaeDF8pzRHTV8HIH9PeIS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 mlxlogscore=945 mlxscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130153 On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote: > Currently, ath12k_core_hw_group_destroy() accesses its members without any > locking mechanism. This could lead to potential issues if these members are > modified by another thread concurrently. > > Hence to mitigate this, use the available mutex lock. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Fixes: 6f245ea0ec6c ("wifi: ath12k: introduce device group abstraction") > Signed-off-by: Aditya Kumar Singh Acked-by: Jeff Johnson