mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	<linux-kbuild@vger.kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nsc@kernel.org>, <linux-s390@vger.kernel.org>,
	Heiko Carstens <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Christian Marangi <ansuelsmth@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] err.h: use __always_inline on all error pointer helpers
Date: Wed, 27 May 2026 16:30:28 +0200	[thread overview]
Message-ID: <305fbfaf-a4a2-41e1-805d-5141fbfa8e57@intel.com> (raw)
In-Reply-To: <21f771b5-b8fe-4357-b081-ae83a39df485@app.fastmail.com>

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2026 16:25:41 +0200

> On Wed, May 27, 2026, at 16:06, Alexander Lobakin wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> Date: Tue, 26 May 2026 23:03:50 +0200
>>>
>>> Without CONFIG_PROFILE_ANNOTATED_BRANCHES, the changes are
>>> very small, with around 100 functions growing or shrinking
>>> by a few bytes.
>>>
>>> I don't think we care much about the size increase when that
>>> option is enabled, but I do wonder what behavior makes more
>>
>> Yup, and even without this option, __always_inline is better here
>> regardless of how it affects the size. Such oneliners must be
>> transparent to the compiler
> 
> In general I would trust the compiler to make the right
> choices here, but as I have shown it makes very little difference.

I would, but I had a couple moments when it was uninlining
almost-oneliners resulting in several Mpps network throughput
decrease =\

Thanks,
Olek

  reply	other threads:[~2026-05-27 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 10:18 Arnd Bergmann
2026-05-26 15:01 ` Alexander Lobakin
2026-05-26 21:03   ` Arnd Bergmann
2026-05-27 14:06     ` Alexander Lobakin
2026-05-27 14:25       ` Arnd Bergmann
2026-05-27 14:30         ` Alexander Lobakin [this message]
2026-05-27 22:13         ` David Laight
2026-05-26 19:37 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305fbfaf-a4a2-41e1-805d-5141fbfa8e57@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andersson@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ansuelsmth@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®