From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48ABA29713B for ; Mon, 12 May 2025 19:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747077036; cv=none; b=B2zoi/K9xPqwE/j+l9ocDCC112rpzf53POc92F+/Yh1WQJv8KoX1e5KrzZsyQI0xXo8zOELLi0T2fMKpz6Ymi+7MZUUkNH/YugR0B+uO8JhP2+k4Kq3tEfjF382321eHJEzWVCd5VJBwejtYChsnxeAaeCGmfnZoTG0KAoVkiXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747077036; c=relaxed/simple; bh=7FDvjUhQK98zhiBlhvEoWtXdnuiVq1vo4/mLb46MPuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Oi4xvn9qFY/KDX+Rt6bnppF/F24K1+gVAtkJcXXgIizW1glwu8mrNEHndTu5EEqYaTSeK/bt2Ib3/M8al69s1xQqaOrK4qkFVDPLAml+RXrxlLuJHMv3V9Pm9u3pUYlq5A8WAEToxL2eI+VEDtR9HHKzPBwPC3ZB07QmICuSfwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kB/UHNsV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kB/UHNsV" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54CCvuls029118 for ; Mon, 12 May 2025 19:10:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YYz3l97YeUs4psiEgphr3ykxMpiyvXGE8Y78//T9RF4=; b=kB/UHNsV5pmCG15/ QupdvEBHxFCXdLPF8zTKNU95oLEGz8XRpPW2VJZSd3NUmP+Cj+BnaLAudbo+c7yY h2KzdiDVo2thhgKA1LjeO1Jvn9bUV881pO2LYuPluNJs7q1C/CAnWj57BwcCgWpD Pi/yNC9qWRtZD90SYzavWAtWYLewkJ1lM9Lx8MIGxiN4DE1ciQ4O2dmN0Khep2yG iP3ETwy3hxnfG+FP5ib4of9xpAshjznNcSEk8I5SKODjujXGwVl5MQPrscaOr152 bo8xqoNy5ojMhcr0i7pHafX6o7+lsz5s/nHoQ6WNRTYK/GiVek08HrluiPjG1+Vk PBHtCg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46hxvxdbek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 12 May 2025 19:10:33 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5841ae28eso129001685a.1 for ; Mon, 12 May 2025 12:10:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747077032; x=1747681832; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YYz3l97YeUs4psiEgphr3ykxMpiyvXGE8Y78//T9RF4=; b=mm4XrWD+dj2bjVqTAQHLZExVGIW5V3lW7+giy2Ml08WW4DfRVKe3hnImWDM4k4SbBN B9vnVtD9p/5a28C6gXviR2/ubmMilN635Sfjum/5OL6BlONqZPLcTRdZY+Ffbb6KwFkj JG28iu3yQ4NgSRJe0uyRbWIzWIdCSt4clHUi8Zr6eu49nXeHcog+94WfG9G5x5J/SWgJ ioJg8HOXsQ8HFEJIVD2/MccMpHUJ8691dDEs49BD9m0WywUKVQxaZJ0ydJquTOfs9GPI 8I0rlDikFDS3d9j12CgKJEhtjy16QJxb5nUMd7lSeMBMSyiD3o/xmcg5CSI33xhpPBbt yzdw== X-Forwarded-Encrypted: i=1; AJvYcCVPoyDwGAAUt4hWOMY4NPo4u8W8zuCdnsDH9H/nG/8kU2pv/3Q4N/lgGwbqxCGetJNGCN6nVRLLQdocS+I=@vger.kernel.org X-Gm-Message-State: AOJu0YyWD56XqH5IBd64hfyYGCFPnwoSVPi4KI/0iEZmuokeQlkMtlMZ Vw7WxKKN8Mh9yG3rSz3Yzl/qqUK8MQASuK45R6E3Z1E2wRlkBpcCzE+bAxoyrmoOE1yxpBjAxwc zpNH/sjTdAwHOofMUmWf69IiWQGJIznj3phWfmHz5RTyutIg00f4CXY+hpsCOsJ0= X-Gm-Gg: ASbGncue3US9GxjK2rE731JmvT8Z3TYdEhcq+0Z4lhiub747oUJlQicEi31kKn2eccO NkT/o/uE2ezJBKKBrmdJoEWn+p5g24btf09G2UpLAwxVnajFJZ9p9FqNmaMCqMR4Lfn/Yhe21uy HfpVdLXRACp9RgmKPBsvYAOgdQFtCKPZZvbvEmGNAxPVxSYVGtdKMFvHckq1hPd64DrdEFdORPN PvdcaB3bccSTmJXYeD6DS5b7jHKqSUi+LqhI3RkIf0JE2di5V2P6rdb1YlM1O+3yaqjPNIS0PTg C2B6asQfMs/JAWQiY9m8FSUm9wAxGG7RvSmHcsj7w2/mxo3/eWJXmo732V76FHNpnpU= X-Received: by 2002:a05:620a:198a:b0:7c0:b81f:7af9 with SMTP id af79cd13be357-7cd0120a6a2mr886745485a.6.1747077032127; Mon, 12 May 2025 12:10:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2K9ql15/d4D35gN1KXzYEavsjzdHbxihDRkp7GyzeRQABAyBVS1bBH8kySfi/iFDeV7zB6g== X-Received: by 2002:a05:620a:198a:b0:7c0:b81f:7af9 with SMTP id af79cd13be357-7cd0120a6a2mr886742985a.6.1747077031702; Mon, 12 May 2025 12:10:31 -0700 (PDT) Received: from [192.168.65.222] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fc9d700e7csm6014016a12.64.2025.05.12.12.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 12:10:31 -0700 (PDT) Message-ID: <3065cdb1-30ff-4be3-8959-45e4c4edc123@oss.qualcomm.com> Date: Mon, 12 May 2025 21:10:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: qcs615: Add IMEM and PIL info region To: Lijuan Gao , Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: kernel@quicinc.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250507-add_qcs615_remoteproc_support-v2-0-52ac6cb43a39@quicinc.com> <20250507-add_qcs615_remoteproc_support-v2-4-52ac6cb43a39@quicinc.com> <64893588-544f-4cb0-8c0b-7eef588468d5@oss.qualcomm.com> <2eb4606c-16f8-4e34-8084-039c9e57bbdd@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2eb4606c-16f8-4e34-8084-039c9e57bbdd@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTEyMDE5NyBTYWx0ZWRfX6HHG2mqv84nK yzl2c0ibxyBXciMflKCKRebif7RKsMDQXvAsDRP9iVsufq9MPm+yVv4FdM2hBl89xEMwI+XMqQO Q0J9vCUOCSXF46XILDW78alZA3ZgFutDK2qNSC58DVt8hkGiJ2wUeM1BLZPKG1CkPf/nEt3fugX 6s1COv1sDGEnVtAvfMZ1wisY8eMHrS96H1gKl1wCo0g0pZ1NN3WIxIS4+WcKaYN1RMJf44VB1m0 nGJGvSSvZc9Y+nWEg7Q+dMzWy5BWlqtLGzabfawtRAYhF5db3PMxhVxXLoWxQpoFNk+MMlXez6Y +jt4uwVjrh3snvpMnl1CDS8JvWXqSm05KESdOPDEojLkVivQgaUHdS2e/Ut0QPLRRb4VIGaooh1 fhpB1lDr2Qa0P1sspFKG3lQkpqlKgUV4bAw25bJFHG57rQ04wXRCucqXFNpPzHmkunMceKKl X-Proofpoint-GUID: fmeyth4EZg8mHiP9BRglsN4ebdEBkXcH X-Authority-Analysis: v=2.4 cv=WMV/XmsR c=1 sm=1 tr=0 ts=682247a9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=BKL5ZcGrS_xDY7syMdwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: fmeyth4EZg8mHiP9BRglsN4ebdEBkXcH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-12_06,2025-05-09_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505120197 On 5/12/25 5:20 AM, Lijuan Gao wrote: > > > 在 5/9/2025 4:54 PM, Konrad Dybcio 写道: >> On 5/9/25 9:37 AM, Lijuan Gao wrote: >>> >>> >>> 在 5/8/2025 10:41 PM, Konrad Dybcio 写道: >>>> On 5/7/25 12:26 PM, Lijuan Gao wrote: >>>>> Add a simple-mfd representing IMEM on QCS615 and define the PIL >>>>> relocation info region as its child. The PIL region in IMEM is used to >>>>> communicate load addresses of remoteproc to post mortem debug tools, so >>>>> that these tools can collect ramdumps. >>>>> >>>>> Signed-off-by: Lijuan Gao >>>>> --- >>>>>    arch/arm64/boot/dts/qcom/qcs615.dtsi | 14 ++++++++++++++ >>>>>    1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>>>> index 53661e3a852e..fefdb0fd66f7 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>>>> @@ -3266,6 +3266,20 @@ sram@c3f0000 { >>>>>                reg = <0x0 0x0c3f0000 0x0 0x400>; >>>>>            }; >>>>>    +        sram@146aa000 { >>>>> +            compatible = "qcom,qcs615-imem", "syscon", "simple-mfd"; >>>>> +            reg = <0x0 0x146aa000 0x0 0x1000>; >>>> >>>> 0x14680000 0x2c000 >>> >>> I checked the latest datasheet, the Shared IMEM address is 0x146aa000 and its size is 0x1000, 0x14680000 is the start address of IMEM layout. The shared IMEM is used for debugging purposes, while the others parts are dedicated. >> >> Even if we don't use the entirety of it, it's good to describe >> the whole block >> >> Konrad > > According to the definitions on all existing upstream platforms, this imem points to the shared imem. Should we stay consistent? That is because everyone kept copying over whatever the downstream kernel did ;) Let's describe the whole region - at best, it doesn't hurt Konrad