From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8023DEB64DC for ; Mon, 26 Jun 2023 14:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbjFZOB0 (ORCPT ); Mon, 26 Jun 2023 10:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjFZOBY (ORCPT ); Mon, 26 Jun 2023 10:01:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0B5C119 for ; Mon, 26 Jun 2023 07:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687788034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R5wAW69Y9SPx+cvsoxbJGKBGWs/a2ilDi5P0yALs1Y=; b=NWSvqW3AnGLyj1wh+XM47VBOUibhMsaZRt6l3cOOS/Bl/+jPKJYV8vkodQBO6gnHyTFMyN ElhzpQPDe0iReJ/JMPeMdtC2ZfHb8k4Vvk+j11KzEiLKPpiFroQ//lV82MQEnYTG5HMric Y3m470C8JDI2QQdXteQlFU3az68oe3o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-rCQr8abpMMS8ijQ22hbUyQ-1; Mon, 26 Jun 2023 10:00:30 -0400 X-MC-Unique: rCQr8abpMMS8ijQ22hbUyQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD8988564EF; Mon, 26 Jun 2023 14:00:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0457A1121319; Mon, 26 Jun 2023 14:00:27 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> To: Ilya Dryomov Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3068220.1687788027.1@warthog.procyon.org.uk> Date: Mon, 26 Jun 2023 15:00:27 +0100 Message-ID: <3068221.1687788027@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilya Dryomov wrote: > Same here... I would suggest that you keep ceph_tcp_sendpage() function > and make only minimal modifications to avoid regressions. This is now committed to net-next. I can bring ceph_tcp_sendpage() back into existence or fix it in place for now if you have a preference. Note that I'm working on patches to rework the libceph transmission path so that it isn't dealing with transmitting a single page at a time, but it's not ready yet. David