From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C600BC76195 for ; Fri, 24 Mar 2023 07:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231477AbjCXHRr (ORCPT ); Fri, 24 Mar 2023 03:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231267AbjCXHRn (ORCPT ); Fri, 24 Mar 2023 03:17:43 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C82E910AA3 for ; Fri, 24 Mar 2023 00:17:41 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id ew6so4155841edb.7 for ; Fri, 24 Mar 2023 00:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679642260; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aXAkVT7qE3o2b6C1GZG01G7UNo5SeuZbrIlsD61ojCg=; b=WZLVM+Pvfjz9X30E2t8w3NE+GPwpnZcHc3b860wehev3NfRVUhKjczo7KpM/+Nv+aB Qe1ZdEuzfcoHXfljY1J+hOFllH3jsHTI/eX4O1i7tJKofF7J2WVA1TZh19r/Ry9PG6Sb sbiVK/XhecqUzwxRoadxoayaqwPEYt14l16rlKvhaBJ8ji8dcnZNd1hihPs5V4m9xDhb M9W5K/VvULUiC10++uH5t7hoEs6yfpyT6VKFJtkKVhQ163arDQAS+DkHysj8pn65CJao nAZKAE9Q6SZFYJ5Z7YGdl4rPE641i8GdCuQhQTg9q0SUI2mOlUviYms3O5SBepQwqlQX Vmvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679642260; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aXAkVT7qE3o2b6C1GZG01G7UNo5SeuZbrIlsD61ojCg=; b=sg6Xf58Egj/kZG4+zM1aTkVCg/P5BqDmCGbh3tLKlqzeKADuAS/QQ7fg2VRC0nuc+W z/H5LVrzgnLWI6+0DQDPSW8EK/01XHR2ginEvgbAbdvWktS5rSACQkUCxXAAtrPE+f0z SKVj4w35J07kZUj0BUHYToFwDxt/zJt3iIVF+NJGIIbqYnaub4UBaCQ9tzB7AKyz2BqD MVR5kvc5ZenFLxsv/gbImVD8FG39rjdhbhCA2Kuf+tDZr5w5bxUeYTHHvdO38h2wChXM BCnK3pye7yoZzzzQhxR2IuEO4OVXtJelybd0t9a4h9XnFAwuASumrIiFLdNIFbpDCeP8 Qf/Q== X-Gm-Message-State: AAQBX9cMqx1s01m3Zk0jdhVTeojyhID5IJQKbnpxsbEpP6xn2L1pXWrx X0YiPluYcjrnuZvy0zcIB55M/w== X-Google-Smtp-Source: AKy350Z0IEgUlLyGvvrQ30h1GQdZUzu5+nU1YNH91UDza4dmttvtndN3IIVzkTqrz4PLJOMOJ62uwg== X-Received: by 2002:a17:906:b74f:b0:92d:591f:6586 with SMTP id fx15-20020a170906b74f00b0092d591f6586mr1897064ejb.34.1679642260303; Fri, 24 Mar 2023 00:17:40 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ce50:243f:54cc:5373? ([2a02:810d:15c0:828:ce50:243f:54cc:5373]) by smtp.gmail.com with ESMTPSA id 24-20020a508758000000b004fb419921e2sm10316150edv.57.2023.03.24.00.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 00:17:39 -0700 (PDT) Message-ID: <306b02e8-72bf-3eb7-f4cc-3cc5c598993b@linaro.org> Date: Fri, 24 Mar 2023 08:17:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Content-Language: en-US To: neil.armstrong@linaro.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Stephen Boyd , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , linux-scsi@vger.kernel.org References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-6-3ead1e418fe4@linaro.org> <35e3aa8b-ccff-25fa-42da-d8934ef366c6@linaro.org> <006bf3bf-ab9a-4a08-3ba5-fa23ff4ea05a@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <006bf3bf-ab9a-4a08-3ba5-fa23ff4ea05a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/2023 14:13, Neil Armstrong wrote: > On 23/03/2023 11:47, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >>> ['mclk', 'macro', 'dcodec', 'npl'] is too long >>> >>> The implementation was checked and this npl clock isn't used for the VA macro. >>> >> >> This does not look correct. DTS looks good, you miss some patches in >> your tree. > > I'm based on today's linux-next, Which is unfortunately not enough. Several things were fixed/added/changed and are pending. I brought the topic of pending branch few times on IRC for that reason. > while the other lpass macros uses the npl clock, > the lpass vamacro bindings doesn't document the npl clock. > > And I found no fixes whatsover to add the npl clock to bindings. Really? lore finds it easily: https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@linaro.org/ Best regards, Krzysztof