From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80CCD31D735 for ; Mon, 16 Feb 2026 15:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771255039; cv=none; b=R6zDisFOZPBaOkJiyaq1XGJLUkta2rh0oevp0nUyzgJfo3ztF8uKlCC3DvK707sBR/wOcum+AcDvqJK2GwEgoTtxvAgJWuOP25r/ZGarvuLcwIS5tr0kjTv80ISnnJS6P87o1tGCVHTufGmFf+Pw9spnYuesFhZjnCBf5PcZWgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771255039; c=relaxed/simple; bh=HVqIbhWqa2dWbzKPrO+eXBu0tIwhzEG5l+aITsm6uoI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KM8QySlFo5T6IuS4GBMtBzfudWHfbZBdh1l5sSO8ezg9KsHfJvAodC/5EkTGPCTkseNRtFL7z5rjTDyFzN943JO4FEkRM0shpqW/vcha09XaKSp5FdTCCmboCUnKvFG3a0esEqaWrZ41kgGLGrEKr077shZ5tqKikiDGCnUKIc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lYzaxfOI; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lYzaxfOI" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2aad1bb5058so34161265ad.0 for ; Mon, 16 Feb 2026 07:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771255037; x=1771859837; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=dCE3gF12Qsuc0Q0S4BkQq+M+t5dj53pHezYMH10XfpU=; b=lYzaxfOI4Zr8wlkdwGOezn/+ni9zjEQwEoNrtDNJ8r8C9GQw5cNh4LBHKDc6jDfQqj BrITYa/dHg0zitjKuBiTjIy9T22QpLLc+GOHJAlobd67u7AIGFTXA9/B+PIL2/RUkxB6 IXQE1TkGxinFNpDBotgx4PcpsgTbTrXpPkGIJrgn4NWt8XqpLZ6/LvNQ16nQoBEjIwF5 Zl914immoAN7rAnMfbP8d5e3CK2Vsp6IgEJTz3V4LqMg4qW96w93vTMf5jCPYNv3qY83 bnjpOSiUphLRoM+XdnM0zXzaOBjKBPO6teFy7Ft6Co782ThrPInSfQ9iCLX4o5TqJtdj P51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771255037; x=1771859837; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dCE3gF12Qsuc0Q0S4BkQq+M+t5dj53pHezYMH10XfpU=; b=JEvHuiN1QzT+WEmUXwyL/2rXkuYP+dne5E7wyuVEd80NMKNwuGpA3CUfoM+An98h9t 2fuABkU5wd9syzPZlQsj9PwoqNAIeGXef1v1u8BkogWuk73mdQgJi+z3pfzDGFhRGdFK Q4lsrZ6HXGQIgx0XiHBD0fkTdxJLOoSmjijzBd3oOcoVofJ7JyYkz6f2+uAg9SzpuBrP N7q/heV0n4DtnjdMTTZMw9S0QgkfaxCTVt36mnRKYUjyoBNjH0HPSq9BVjdILjUMu5bl Zvvnb+YN8rN0ppwb5Fc/FTv36yvaG+0FocoheU9v3miQkSpn3pvxPZpUx46TTQJmgDWO SLmA== X-Forwarded-Encrypted: i=1; AJvYcCXUV+yO/iO7qQzRNupwadjuVa/ePGgJ/F075IrJI60WtecmtoswvVogpoumubJLGyd1D3YQo4nmGSZ+1d0=@vger.kernel.org X-Gm-Message-State: AOJu0YzlhPcbEwhoyDzgpqeC83Wbxo0KAnGLM7d+u2+21ex2NJTevcGa yzcYoKVj9D2fYGz/DzaGtU0bx980uzVBC2JKF4F9L7Di1ugNsKnElcOh X-Gm-Gg: AZuq6aJ7m2CFn/fvvLCxjySk5A7WPECGNz49m+cx+9WU7NOhl8vIl5oAyH+Mps73TEv suLtyEVXjC0iL/iSwz66tXn/i6chYUxG4KR4GNBWPP1/s32usGnkUAXrBVqYgkM9s2Nhu6wODVT /Mlclp04OAdNG96HzigJzoO2IUCmRIo+87obENdsNXnpaGGDMagk/1+l4hZI6rAVMm23alfZtsV EhA1xRlhZndo9wo94n/+6OoFXrElolecX3sOmlE/rc444IY+AzqILPyh9anvaOFOg2+seopw3Up q7VaWn/PoNvQV+s/4tjSmLUYDK9GhoxmPNQeyaDAFY3uncQdyR7dhYscLqtfVhNo9RFt/253fE1 s+urJ1SAY9n2dSRZCUWh/nZGXEd9yanMNWTO1RASQq2ObxfYaybPc5gc5ZrddcAJZCcS6zteynL gSAZ+CXfB9l3lnwWQAjlcMuIBeXd+LgSWhha79yjs+Jm6qS4JEIars8xW8qE8zah3ADmCnczvS7 6ySpmbfVsk= X-Received: by 2002:a17:90a:e18b:b0:354:a1b8:24a6 with SMTP id 98e67ed59e1d1-356aad7a8f0mr9075642a91.31.1771255036757; Mon, 16 Feb 2026 07:17:16 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-356a6b17c47sm5781823a91.2.2026.02.16.07.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 07:17:16 -0800 (PST) Sender: Guenter Roeck Message-ID: <306e79fb-f3ee-434e-a90e-547e97d2a5aa@roeck-us.net> Date: Mon, 16 Feb 2026 07:17:14 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: dsa: MxL862xx: don't force-enable MAXLINEAR_GPHY To: Daniel Golle , Arnd Bergmann Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org References: <20260216105522.2382373-1-arnd@kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/16/26 04:15, Daniel Golle wrote: > On Mon, Feb 16, 2026 at 11:55:17AM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The newly added dsa driver attempts to enable the corresponding PHY driver, >> but that one has additional dependencies that may not be available: >> >> WARNING: unmet direct dependencies detected for MAXLINEAR_GPHY >> Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && (HWMON [=m] || HWMON [=m]=n [=n]) >> Selected by [y]: >> - NET_DSA_MXL862 [=y] && NETDEVICES [=y] && NET_DSA [=y] >> aarch64-linux-ld: drivers/net/phy/mxl-gpy.o: in function `gpy_probe': >> mxl-gpy.c:(.text.gpy_probe+0x13c): undefined reference to `devm_hwmon_device_register_with_info' >> aarch64-linux-ld: drivers/net/phy/mxl-gpy.o: in function `gpy_hwmon_read': >> mxl-gpy.c:(.text.gpy_hwmon_read+0x48): undefined reference to `polynomial_calc' > > I assume this happens in case CONFIG_MAXLINEAR_GPHY=y and > CONFIG_HWMON=m, right? > > None of the PHY drivers seem to adequately prevent such situations, > which in my opinion would be worth correcting, ie. by preventing any > PHY driver using HWMON from being built-in while CONFIG_HWMON=m. > Technically, with "select MAXLINEAR_GPHY", NET_DSA_MXL862 should depend on "depends on HWMON || HWMON=n". That would prevent NET_DSA_MXL862=y and with it MAXLINEAR_GPHY=y. Maybe it is time to implement dummy functions for hwmon API calls to avoid all this. Guenter >> >> There is actually no compile-time dependency, as DSA correctly uses the >> PHY abstractions. Remove the 'select' statement to reduce the complexity. >> >> Fixes: 23794bec1cb6 ("net: dsa: add basic initial driver for MxL862xx switches") >> Signed-off-by: Arnd Bergmann > > As there is no compile-time dependency, this change is fine. > > Reviewed-by: Daniel Golle > >> --- >> drivers/net/dsa/mxl862xx/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/dsa/mxl862xx/Kconfig b/drivers/net/dsa/mxl862xx/Kconfig >> index 4db7bab21a71..3e772298cc89 100644 >> --- a/drivers/net/dsa/mxl862xx/Kconfig >> +++ b/drivers/net/dsa/mxl862xx/Kconfig >> @@ -2,7 +2,6 @@ >> config NET_DSA_MXL862 >> tristate "MaxLinear MxL862xx" >> depends on NET_DSA >> - select MAXLINEAR_GPHY >> select NET_DSA_TAG_MXL_862XX >> help >> This enables support for the MaxLinear MxL862xx switch family. >> -- >> 2.39.5 >> >