From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6D0EB64D7 for ; Mon, 26 Jun 2023 15:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbjFZPNI (ORCPT ); Mon, 26 Jun 2023 11:13:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjFZPNG (ORCPT ); Mon, 26 Jun 2023 11:13:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86C94130 for ; Mon, 26 Jun 2023 08:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687792344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z1slXFtt+G0ex6dm14v502Z751krJvUwrnDBAKAckFY=; b=HR/mAtQE46+zJ1gtS04FMo5dOKOswVbCDyMBM4/FVvTYNtK0vxQIiMYBUm5N25KDDwzECp tpHymXnWTyiikgoTXN654BQIVjnKndqWc6hRc9nrORGbswnjOJVEvDxy/OSjgeEE3vhZGQ VgqizLcMm7J93DKOd7lMnFxAx+6nbU0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-Nl8n0UMiMmuAUl-8QQKKKg-1; Mon, 26 Jun 2023 11:12:19 -0400 X-MC-Unique: Nl8n0UMiMmuAUl-8QQKKKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80E0985A58A; Mon, 26 Jun 2023 15:12:14 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5A7D40C6F5A; Mon, 26 Jun 2023 15:12:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> To: Ilya Dryomov Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3070679.1687792331.1@warthog.procyon.org.uk> Date: Mon, 26 Jun 2023 16:12:11 +0100 Message-ID: <3070680.1687792331@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilya Dryomov wrote: > > - int flags = MSG_DONTWAIT | MSG_NOSIGNAL | more; Btw, why are you setting MSG_DONTWAIT? If you're in the middle of transmitting a message on a TCP socket, surely you can't just switch to transmitting a different message on the same socket without doing some sort of reframing? David