From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbbIKIg3 (ORCPT ); Fri, 11 Sep 2015 04:36:29 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54032 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbbIKIg0 (ORCPT ); Fri, 11 Sep 2015 04:36:26 -0400 From: Arnd Bergmann To: Viresh Kumar Cc: "Rafael J. Wysocki" , Pi-Cheng Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: cpufreq: mediatek: allow modular build Date: Fri, 11 Sep 2015 10:36:19 +0200 Message-ID: <3071823.f1VzTWVMmV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150911082536.GL9650@linux> References: <1768766.yu1lxjsjLL@wuerfel> <2329563.MhTbBXHVz1@wuerfel> <20150911082536.GL9650@linux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rqJYLG84SedXBkQrj8jS/F+E1ztFg6jX/5B9az9KeXRSLHENb4E R91TbKIBDE31mQ4im4jCkrwLcQjxqfQWKynahBtp7OWxBdJ2WTW6/hbrh/VFRoveMEf7UP0 PMFExaNYN3it4BPMj/tNc78uLdame7od73uNekN1R7vThYy0LnatBeLSaL/PDjRppAe1PSK uOBl1z3S2y1FH+kmvKBjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8Rx/WlJm7cA=:PpR6VEGl9n76SIi7nwFEtJ cCtd0Ng25d56FbK2DfzD99TgS1cK+1MYMHWUK9fGEAnuXy5pQtwX1Le84sMzkDFZYNupyBQf/ vW7YDUbW3UoQ9PoIlzI5meUfMpVEW68PN2Q98VdQKp7pvNxDGT3auNRENDo1GZhYp5OFGDC5S lYdq8IgoEZeEgiM++vVQy14F+XFvycRRrFgofsqaQira1IT/UDZGif4ZC9kJnZSmrRcbAMMfk DQsb/NeCsI2/+R5X+Fal8LTteTTpBSLzOJup3TDq/lvy18han1pOPCnnpRsbFMWFC5zvYIRQg EKMSJ1pNOspgKBry5YtVJvPt9xyhlG7W9mLcbjX33ouM32m+WFWj2xhoIE7ULXzZ6x2oWycgW qq3UU8ctZ8zInzyNWqw5jP8gqrJQf+fsXUDqnl81hLXjYOBqlxVMnuo3UaTwklura4wpunhG9 6xMz44pSMJzek6JrtPzzC6gvrekJhy40W1pFEyWg1zgUiZoq1PlZ2gYGr2wjVD+7VjZnVHrkf z+QydqxXtKUc+UzPO+NIJ20I0fKz1s1VXcqikuh9Bi4cwRu3DYU7jo9QtY7s5j0d9zj5JSoEh UAlwEwRSsu/cTBDSmDX8/uJjeOcs31Ridu3ms/cqvg7xEM+PEgGTyU9AIBnQ5P5Kwx1rTkgRC FqoheMyemJNvOXD+dvQeEW/nPqDXlVG/k5JVzSdU9sVnF66fG/uRTyNZGbDmJVBYtAcbbyveR LTvkC2tgwAFs/6Yx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 11 September 2015 13:55:36 Viresh Kumar wrote: > On 11-09-15, 10:22, Arnd Bergmann wrote: > > In my approach, I decided to allow the driver to be a module, as that > > seems nicer for multi_v7_defconfig, but I now see that there are > > several other drivers that can only be built-in, so if we decided to > > make that the general strategy we should change them all. > > And we need to do that with a proper module_exit() function, otherwise > we are really adding a BUG. Which you just did with your patch I don't consider that a bug: a module with just an init function and no exit function can be loaded once and never unloaded, which is not nice for debugging, but is otherwise fully functional. Arnd