From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbbGOJ5R (ORCPT ); Wed, 15 Jul 2015 05:57:17 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50727 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbbGOJ5P (ORCPT ); Wed, 15 Jul 2015 05:57:15 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Yuan Yao , vinod.koul@intel.com, stefan@agner.ch, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Date: Wed, 15 Jul 2015 11:56:40 +0200 Message-ID: <3074236.7KNCYXgBBY@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1436952778-28000-2-git-send-email-yao.yuan@freescale.com> References: <1436952778-28000-1-git-send-email-yao.yuan@freescale.com> <1436952778-28000-2-git-send-email-yao.yuan@freescale.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:LDJn7kwcUN9/PNVK0ijDS1tohvcUu9xe+NTmYLYzKF4PW1m09qJ RugyaFGekYXzb9gEmZn0Vcu9+izBjs2EInkcr7V3Se6SOnnSW8npkyn6l88em/8T29bOkEG 2FAQ66dEpG/gVIxbVTi04Cg/HMx2KTKdar/EllG0t9wkZoq88jxQFuJ5vZAMCvPQLefnSWj TBnzLZIwkbbeU5FPTBXkA== X-UI-Out-Filterresults: notjunk:1;V01:K0:21QCl33EcDI=:9AnjnlNkYIiA+EbkWJtABX 1ANbEQj0hHREyEN9dBL/McqjSMsPAKGPq7ullaDcgohdaugWT9SDIBpm8IpVsyhn31ex4YMLv blZHHngGqbh+iPnMLkT3i6Yrn48hSmaBHX/P+MDhteXTi2zvu3xAP2WkbPRGdFbz11URlEyjg eKkkY242tWrtC1xZ3n5ERl5c/TsH8NQxuq7RCRjpdZq+4prh1nFV7H29I/fDiZojf05IIQXvf KTBz+tSXtyCy9hhMVLAsKrPOQWV2IYEt6RfbJzCSk8X1suiKmJ/5qMRO3MFjYeZoCl8OVJJAd lQG6KVTSLxbS285VdVtn9E8Tp9ScAOV4Kdt6wFiYXVFQtU8Ubq4CYUucQlFb+K6N2994r87MG SbQDw23StC+ey2j3ZbdJEVmQJC+yQv2MuyP2ILaOK8q0Bdwx4WGK0CJGREtYoYRNNqLQBn8iU zZBcfUaA6Bc7zLW5iEgqOHENaov77HOw5YQ7t5CUllYH16Q3oUVdS1oy+v2+q4i29D6aSKX3p rLQDzCDmpx1iUKdFQ9M7CHB56609843d6mHP2PKNn2yOydcnnf7bIY40HOe/fjIvSuQkKuwp+ yljsXMQXytcW+PKHmGDTyFpkKlaXBJyyDcn9pvACo11S+PPROaFEUwqfeE96TFjJhKqK5m01r Y2UMEqL8ZbKZCexbrFc4zoyfw/m/bkJfJZY4uNhMa5fuGIQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote: > +#ifdef CONFIG_PM > +enum fsl_edma_pm_state { > + RUNNING = 0, > + SUSPENDED, > +}; > +#endif > > struct fsl_edma_hw_tcd { > The #ifdefs here seem unnecessary, at least most of them, better just do this all unconditionally. Arnd