From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757509AbbEVT7G (ORCPT ); Fri, 22 May 2015 15:59:06 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:55139 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757169AbbEVT7D (ORCPT ); Fri, 22 May 2015 15:59:03 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Greg Kroah-Hartman , Jiri Slaby , mathieu.poirier@linaro.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] tty: remove platform_sysrq_reset_seq Date: Fri, 22 May 2015 21:58:56 +0200 Message-ID: <3075531.er6Vo6bmpE@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <2397446.P9RRJqoFo7@wuerfel> References: <2397446.P9RRJqoFo7@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AyUBRui/rmJcXMEcQRX1gyhPu4HArLKUCqJpDL9Q6JEnQxgTmq0 UaWEKjYxxSfQ1xEZyVnsdYO4ZJ1YqkdW8zJnsaK3PlFg5EDCuVdjbK3z6urU2IDRGErf/7d MhjogZzIBAnx4ftPNiIoWsRvyoojcIUGGe2IWrHb660O+h5r+lpuj36GL+IKBEd+GqyFxnJ Qxr2SJoNtR70BxjUJQQEw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 May 2015 11:11:28 Arnd Bergmann wrote: > diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c > index 8ba52e56bb8b..9c5395db6a57 100644 > --- a/drivers/tty/sysrq.c > +++ b/drivers/tty/sysrq.c > @@ -55,8 +55,7 @@ > static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE; > static bool __read_mostly sysrq_always_enabled; > > -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; > -int sysrq_reset_downtime_ms __weak; > +static int sysrq_reset_downtime_ms; > > static bool sysrq_on(void) > { > It turns out that the variable is now potentially unused, and we get a warning when CONFIG_INPUT is disabled. I'll send a fixed v2 of this patch. Arnd