mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
	Pavel Machek <pavel@ucw.cz>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	vishwa@linux.ibm.com
Subject: Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip
Date: Mon, 13 Jul 2020 09:29:51 -0500	[thread overview]
Message-ID: <3077dcbb-70e3-f460-b957-95d11c47be2a@linux.ibm.com> (raw)
In-Reply-To: <CAHp75VcE9skpqa32bZ4AAcOa08WYSqqZodnveLSF+sZej5KnWw@mail.gmail.com>


On 7/9/20 3:50 PM, Andy Shevchenko wrote:
> On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@linux.ibm.com> wrote:
>> IBM created an implementation of the PCA9552 on a PIC16F
>> microcontroller. The I2C device addresses are different from the
>> hardware PCA9552, so add a new compatible string and associated
>> platform data to be able to probe this device.
> This is weird. I would rather expect ibm prefix with corresponding part number.


Yep I agree now, see my note to Pavel just now.


Thanks,

Eddie


>
>> +       pca9552_ibm,
>> +       [pca9552_ibm] = {
>> +       { "pca9552-ibm", pca9552_ibm },
>> +       { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm },
>

      reply	other threads:[~2020-07-13 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation " Eddie James
2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James
2020-07-11 13:48   ` Pavel Machek
2020-07-13 14:28     ` Eddie James
2020-07-20 22:25       ` Rob Herring
2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James
2020-07-09 20:50   ` Andy Shevchenko
2020-07-13 14:29     ` Eddie James [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3077dcbb-70e3-f460-b957-95d11c47be2a@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=vishwa@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®