From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87B82C0284 for ; Tue, 6 Jan 2026 08:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687366; cv=none; b=tUEiKXaCxfDaqSWlyhTawL7ZUWmZD00psQ3meGRY5Bp7Py6A9x+/oeafGDAOd6aiLrPU7mE0S9qk5jWOb17It74LY6qeDfrIouMbm3stypJnk0DkhYdWowdpMJroWcU+6L/Q44oLkPWKsfUcOIXOEBgJ6HHez4qz8luVWjMAZps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767687366; c=relaxed/simple; bh=T6+gOqVhpJd7Lm7k4/kzZF1tSLTzilvnZgXHsGQi9DI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=toGpH8Tzm7VzBBj5mTOK29ULfCRxaia30A20IVKxxMqHgPFoS6NuqeuZf6juJp3TXKloXMB3h6lF5GJrTa6b5ruWm1X38ETdOlk0UZM1qZDRaJ/8g2njL4QHk+U4pOA0Bx0Yj2f0YkS0wEdcP1LSjky/4IjMOicaoGJd8Sj9j/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x2/N86RV; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x2/N86RV" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47aa03d3326so5706515e9.3 for ; Tue, 06 Jan 2026 00:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767687363; x=1768292163; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=2RXzUF1ln5+oulmXk/n680HR54Be5PwLRIBrC3MX2Ps=; b=x2/N86RVZVpJKQvuVI4+7dHHlt/r3+ZbGxV1pCa5EMFGPwgSg/bJFNepu6Uh3lUA2+ t2XF9z6BBkz8kLi+amYWwp1ha79WViHx8zUu3BzG0Wr2n7P0HYSndsb0AMoG4Oz7oX+M 5+IDnTJwiXop0DM21q0MHChoo5FmlQBiQhVetxhZQDUm9qj0DRj1iXktT0dQKgiI6jRT nH87zwwOTRwI6Otk5qdqgQwMZEyU0Zc2WDXacNpmmCxgdd6ZU6jJLslUNgHkMZGNeYWQ oV0ZtKE5OF6umQPnKwHpXaffg0YJMZhGjFMUPy6rrUGCn5d8fW5b9r9PlY07zYv6On0F b74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767687363; x=1768292163; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2RXzUF1ln5+oulmXk/n680HR54Be5PwLRIBrC3MX2Ps=; b=CkfGtL1Pc6SyZtNUD96cObyZIC+613iIX7jZj5Mkfo52MAC6pj6/J3LRrUS5ZMjp4p xyEiMEuNYW3ueEh0ST1/Fm/zV53r+EOaDTurhajoIOSPSBKPLxVsn2DrPNaQrwmN4wda piw8YParGtaO0d6iFuabVPFHsW2I3Aolf9mj1LrQeRYX2yeNxeHp/2GCaEL6O3tUlHZp +VD2H1pYr92G3rWKcqr8VB6CT1LAfpNv4ghyQj7dW/dJ6HZD6NyTxbIDtufldgKS2Eo4 OZvILkt4RhuSO9NupIt62b1MSiPC4N+0s3xju2rJY82DGLuj81kI4jJFt2xJr6PP0Hjx wZbw== X-Forwarded-Encrypted: i=1; AJvYcCVMdeeMkdQ3y+bz7ZJQcvD0dfBxnz+AZqoDekguujDZTwrQpRTc+k/1Bmpdyx/KtsXd4HPHaZij6zV7USw=@vger.kernel.org X-Gm-Message-State: AOJu0YxWc+56+nBM/kMs6y4BdLtX6WZWGuQHp9bDSMs/2n2Vfvi596N3 ynA/s/BJDao/mHLMTzPateD68pm1BaYEmg3pji28NsNesj3OG7WIG+M1CzMTWNxNrjo= X-Gm-Gg: AY/fxX500lLcAsEL3i0RLsVFyCHVGrq9gmzDPID+TXqQ+Ec0DbJ4lIbC2jWB7ORDWv1 PkwXccvx0qen351ohfARfbE11MwE3e79mLNSRgougSKqazjjnKq7ZaUCwMe9PYXuiJ1f64FiP26 nPXZvei7OkzcV9Cl6B/Z7LhzGIIS1Yy1U3pSZWaIMthDgAxT8lC3NwrKdztIlUfNvl17xizzND7 7xDKf4EECfSMO59/JEahelakr6wREVYYCFYZ0DhhkgEdlyU30Fk6vDdmea5QuNejOJm5URFTx9H ebiyDU/27Eq3iLDxmIPSJcDenOLvpWOTR5bJ8MqHyqg7hbt/DxEB9Mt9jmy20k/HLucl9ehKEmR pHk+ym/ZMwtjVl4/zRGLn1q5+mECrWWZ2wAQaVPEo09IscBhgkA7QYBV06k6ZJV/BlZteDEAdf1 taXs59yFOG46MkS77mRQq3VgxN1uiTqTFC7XUY49Py3NwcWu4jdCuHIddZzqfRGRM= X-Google-Smtp-Source: AGHT+IH60kuK/PXY0IqMZE4Sd9cXHxZGsJIz5+sRgLkn7IO6l5nc253rglz2ZxZzrX/dYgPe7W1yWQ== X-Received: by 2002:a05:600c:8b72:b0:475:e007:baf1 with SMTP id 5b1f17b1804b1-47d7f0a3af9mr22232555e9.34.1767687362860; Tue, 06 Jan 2026 00:16:02 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f6ef885sm28607805e9.9.2026.01.06.00.16.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 00:16:02 -0800 (PST) Message-ID: <307ea449-c8a1-4fd7-a67b-7c6777eb4669@linaro.org> Date: Tue, 6 Jan 2026 09:16:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 4/5] drm/panel: mantix: Drop bank 9 initialization To: sebastian.krzyszkowiak@puri.sm, =?UTF-8?Q?Guido_G=C3=BCnther?= , Purism Kernel Team , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260105-mantix-halo-fixes-v1-0-1ebc9b195a34@puri.sm> <20260105-mantix-halo-fixes-v1-4-1ebc9b195a34@puri.sm> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260105-mantix-halo-fixes-v1-4-1ebc9b195a34@puri.sm> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/5/26 21:24, Sebastian Krzyszkowiak via B4 Relay wrote: > From: Sebastian Krzyszkowiak > > This command is part of LIC sequence included in FT8006P firmware. > There's no need to repeat it here. > > Signed-off-by: Sebastian Krzyszkowiak > --- > drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > index 0e66ee7a727d..30e378faafcd 100644 > --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c > @@ -53,11 +53,9 @@ static void mantix_init_sequence(struct mipi_dsi_multi_context *dsi_ctx) > mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a); > > mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_INT_CANCEL, 0x03); > - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x03); > - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00); > > - mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x09); > - mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0x64, 0x00, 0x64, 0x00, 0x00); > + mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x5a, 0x03); > + mipi_dsi_generic_write_seq_multi(dsi_ctx, 0x80, 0xa9, 0x00); /* VCOM */ > > mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_SPI_FINISH, 0xa5); > mipi_dsi_generic_write_seq_multi(dsi_ctx, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x00, 0x2f); > Reviewed-by: Neil Armstrong Thanks, Neil