From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: aspeed: Fix/add I2C device vendor prefixes
Date: Wed, 03 Sep 2025 15:01:20 +0930 [thread overview]
Message-ID: <307fa87eb552ac4a1f6dd6139450786195e3892a.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250815230841.3487764-1-robh@kernel.org>
Hi Rob,
On Fri, 2025-08-15 at 18:08 -0500, Rob Herring (Arm) wrote:
> The ASpeed DTS files have various I2C devices with missing or incorrect
> vendor prefixes in their compatible strings. This hasn't really mattered
> and doesn't impact ABI compatibility as I2C devices get matched with their
> vendor prefix stripped.
>
> With this, the "maxim,max31790" nodes now validate and have some
> warnings. Remove the spurious "#address-cells" and "#size-cells"
> properties to fix the warnings.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../aspeed-bmc-arm-stardragon4800-rep2.dts | 2 +-
> .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 8 ++-----
> .../aspeed/aspeed-bmc-facebook-minerva.dts | 24 +++++--------------
> .../aspeed/aspeed-bmc-facebook-tiogapass.dts | 2 +-
> .../dts/aspeed/aspeed-bmc-lenovo-hr855xg2.dts | 2 +-
> .../dts/aspeed/aspeed-bmc-opp-palmetto.dts | 2 +-
> .../boot/dts/aspeed/aspeed-bmc-quanta-s6q.dts | 4 ++--
> 7 files changed, 14 insertions(+), 30 deletions(-)
>
I see you've applied this to your tree. Sorry for being slow on the up-
take, I've been focusing on other things recently. Happy to take it
though, if you're happy to drop it?
Andrew
next prev parent reply other threads:[~2025-09-03 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 23:08 Rob Herring (Arm)
2025-09-03 5:31 ` Andrew Jeffery [this message]
2025-09-03 6:51 ` Andrew Jeffery
2025-09-03 14:05 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307fa87eb552ac4a1f6dd6139450786195e3892a.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®