From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF094F1EE; Mon, 3 Jun 2024 21:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717451098; cv=none; b=mkhAV9HPZVrDWAbBE8+g2Y5wNttS09daP1xwK+MJ9If5xxubrhn59L3etz5+ycnrb8HcqP5+B+FRX422H57d+WtPe8omKGFrBzP1rlMEDz3G271dVTe9xCsSyfwKTJatMO5Duud2MONLdaOzjQnFqcNJdoC3OqhGPVq0XjD0Evw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717451098; c=relaxed/simple; bh=V+eRnbzwdBwo8OctlnXdHtmZ7QaU0mnEoUfANzfunQM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=MTQ9vIg4jGk6wyvF/u3jv+a/D2hD9ybxn23ieZJBZRNxtGNSZPChsWrWV01bwCmfJDRNQgmnmCJibqfpLfE6NB75Yvhw+zizR8na9farYNqaL8ZDZS91FH1u0e2leeMdjSn0WS3Y0870fSndL//HZSJD+fNyHICm+kOnAhm8B/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=RD9suWTc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="RD9suWTc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 453DBsO5018795; Mon, 3 Jun 2024 21:44:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= czllgLJwquvsPz4sMdKe9Cr+PUHyUtH4Jy9GtsmUfqk=; b=RD9suWTctLFQFOX+ zrb1U6FuUeY/NcBiFVuJVjqMR8v+ljOd+gYk8Kn4k9+SQbCdh+owVB3+mT8Vh/lL //goHxLcLLxZfNg+5Qozco/fsu+Po8nxFZpYiMlpaq4s6H1svahTn5WbqoflFYzg CiCzIjVxDPiPx/ZzJkDUm2kKpEmET58a5/+mGGu+x+uzul85lpAvmceQhSHbbq9I XfqveNlhMc/Tqjy+x6AxF83kWYdXGsEOU0xRUX9DPVgSBWvVf8BoXeXf7Y7U2ytv zcKfrTQHm0Hh3QzX8F3XzH3LqWyLENzgrwie/XEv3s8dPSiBMpPGWcKunYtbJBS+ kzS3RQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yfw4bd22p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jun 2024 21:44:50 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 453LinSq021933 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 3 Jun 2024 21:44:49 GMT Received: from [10.110.31.89] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 3 Jun 2024 14:44:45 -0700 Message-ID: <30842f0c-0197-ef13-5880-4425e92eac65@quicinc.com> Date: Mon, 3 Jun 2024 14:44:43 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] drm/msm/dpu: fix encoder irq wait skip Content-Language: en-US To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter CC: , , , References: <20240509-irq_wait-v2-1-b8b687b22cc4@gmail.com> From: Abhinav Kumar In-Reply-To: <20240509-irq_wait-v2-1-b8b687b22cc4@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: I8w1bmFclYIoTOctYoR9qa5HE_kxvE9i X-Proofpoint-GUID: I8w1bmFclYIoTOctYoR9qa5HE_kxvE9i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-06-03_17,2024-05-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=880 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406030176 On 5/9/2024 12:40 PM, Barnabás Czémán wrote: > The irq_idx is unsigned so it cannot be lower than zero, better > to change the condition to check if it is equal with zero. > It could not cause any issue because a valid irq index starts from one. > > Fixes: 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1") > Signed-off-by: Barnabás Czémán > --- > Changes in v2: > - Add Fixes in commit message. > - Link to v1: https://lore.kernel.org/r/20240509-irq_wait-v1-1-41d653e3784e@gmail.com > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > To make patchwork happy, I am re-adding the tags this patch for previously as they got lost. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar